Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 17 | View Code Duplication | trait ElementTrait |
|
| 18 | { |
||
| 19 | /** |
||
| 20 | * Returns WebDriver session |
||
| 21 | * |
||
| 22 | * @return \PHPWebDriver_WebDriverSession |
||
| 23 | */ |
||
| 24 | abstract protected function getSession(); |
||
| 25 | |||
| 26 | /** |
||
| 27 | * Returns page element by class name |
||
| 28 | * |
||
| 29 | * @param string $className |
||
| 30 | * @return \PHPWebDriver_WebDriverElement|WebDriver\ElementInterface |
||
| 31 | */ |
||
| 32 | protected function elementByClassName($className) |
||
| 36 | |||
| 37 | /** |
||
| 38 | * Returns page element by CSS selector |
||
| 39 | * |
||
| 40 | * @param string $selector |
||
| 41 | * @return \PHPWebDriver_WebDriverElement|WebDriver\ElementInterface |
||
| 42 | */ |
||
| 43 | protected function elementByCssSelector($selector) |
||
| 47 | |||
| 48 | /** |
||
| 49 | * Returns page element by ID |
||
| 50 | * |
||
| 51 | * @param string $id |
||
| 52 | * @return \PHPWebDriver_WebDriverElement|WebDriver\ElementInterface |
||
| 53 | */ |
||
| 54 | protected function elementById($id) |
||
| 58 | |||
| 59 | /** |
||
| 60 | * Returns page element by link text |
||
| 61 | * |
||
| 62 | * @param string $text |
||
| 63 | * @return \PHPWebDriver_WebDriverElement|WebDriver\ElementInterface |
||
| 64 | */ |
||
| 65 | protected function elementByLinkText($text) |
||
| 69 | |||
| 70 | /** |
||
| 71 | * Returns page element by its name |
||
| 72 | * |
||
| 73 | * @param string $name |
||
| 74 | * @return \PHPWebDriver_WebDriverElement|WebDriver\ElementInterface |
||
| 75 | */ |
||
| 76 | protected function elementByName($name) |
||
| 80 | |||
| 81 | /** |
||
| 82 | * Returns page element by partial link text |
||
| 83 | * |
||
| 84 | * @param string $name |
||
| 85 | * @return \PHPWebDriver_WebDriverElement|WebDriver\ElementInterface |
||
| 86 | */ |
||
| 87 | protected function elementByPartialLinkText($name) |
||
| 91 | |||
| 92 | /** |
||
| 93 | * Returns page element by its tag name |
||
| 94 | * |
||
| 95 | * @param string $tag |
||
| 96 | * @return \PHPWebDriver_WebDriverElement|WebDriver\ElementInterface |
||
| 97 | */ |
||
| 98 | protected function elementByTagName($tag) |
||
| 102 | |||
| 103 | /** |
||
| 104 | * Returns page element by XPath |
||
| 105 | * |
||
| 106 | * @param string $xpath |
||
| 107 | * @return \PHPWebDriver_WebDriverElement|WebDriver\ElementInterface |
||
| 108 | */ |
||
| 109 | protected function elementByXpath($xpath) |
||
| 113 | } |
||
| 114 |