DebuggerFactory::createService() - Code Metrics - webino/WebinoDebug - Measure and Improve Code Quality continuously with Scrutinizer

DebuggerFactory::createService() A
last analyzed 2019-12-25 16:04 UTC

↳ Parent: DebuggerFactory

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	6
rs	10
cc	2
nc	2
nop	1

<?php
/**
 * Webino (http://webino.sk/)
 *
 * @link        https://github.com/webino/WebinoDebug/ for the canonical source repository
 * @copyright   Copyright (c) 2014-2018 Webino, s. r. o. (http://webino.sk/)
 * @license     BSD-3-Clause
 */

namespace WebinoDebug\Factory;

use WebinoDebug\Debugger\DebuggerInterface;
use WebinoDebug\Options\ModuleOptions;
use WebinoDebug\Service\Debugger;
use WebinoDebug\Service\NullDebugger;
use Zend\ServiceManager\FactoryInterface;
use Zend\ServiceManager\ServiceLocatorInterface;

/**
 * Factory for a debugger
 */
class DebuggerFactory implements FactoryInterface
{
    /**
     * Debugger service name
     */
    const SERVICE = 'Debugger';

    /**
     * @param ServiceLocatorInterface $services
     * @return DebuggerInterface
     */
    public function createService(ServiceLocatorInterface $services)
    {
        /* @var $modules ModuleOptions */
        $options = $services->get(ModuleOptions::class);
        return $options->isEnabled() ? new Debugger($options) : new NullDebugger;
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }
}


1			<?php
2			/**
3			* Webino (http://webino.sk/)
4			*
5			* @link https://github.com/webino/WebinoDebug/ for the canonical source repository
6			* @copyright Copyright (c) 2014-2018 Webino, s. r. o. (http://webino.sk/)
7			* @license BSD-3-Clause
8			*/
9
10			namespace WebinoDebug\Factory;
11
12			use WebinoDebug\Debugger\DebuggerInterface;
13			use WebinoDebug\Options\ModuleOptions;
14			use WebinoDebug\Service\Debugger;
15			use WebinoDebug\Service\NullDebugger;
16			use Zend\ServiceManager\FactoryInterface;
17			use Zend\ServiceManager\ServiceLocatorInterface;
18
19			/**
20			* Factory for a debugger
21			*/
22			class DebuggerFactory implements FactoryInterface
23			{
24			/**
25			* Debugger service name
26			*/
27			const SERVICE = 'Debugger';
28
29			/**
30			* @param ServiceLocatorInterface $services
31			* @return DebuggerInterface
32			*/
33			public function createService(ServiceLocatorInterface $services)
34			{
35			/* @var $modules ModuleOptions */
36			$options = $services->get(ModuleOptions::class);
37			return $options->isEnabled() ? new Debugger($options) : new NullDebugger;
			0 ignored issues – show Bug introduced 2018-05-21 17:35 UTC by Report Bug Copy Issue Report It seems like `$options` defined by `$services->get(\WebinoDe...s\ModuleOptions::class)` on line `36` can also be of type `object`; however, `WebinoDebug\Service\Debugger::__construct()` does only seem to accept `array\|object<WebinoDebug...s\DebuggerOptions>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
38			}
39			}
40

webino / WebinoDebug

DebuggerFactory::createService() A last analyzed 2019-12-25 16:04 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

DebuggerFactory::createService() A
last analyzed 2019-12-25 16:04 UTC