Issues in Canonicalizer.php (develop) - Issues in develop - webino/WebinoCanonicalRedirect - Measure and Improve Code Quality continuously with Scrutinizer

Issues (4)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/WebinoCanonicalRedirect/Uri/Canonicalizer.php (1 issue)

Labels

Coding Style 1

Severity

Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Webino (http://webino.sk)
 *
 * @link        https://github.com/webino/WebinoCanonicalRedirect for the canonical source repository
 * @copyright   Copyright (c) 2014-2017 Webino, s. r. o. (http://webino.sk)
 * @author      Peter Bačinský <[email protected]>
 * @license     BSD-3-Clause
 */

namespace WebinoCanonicalRedirect\Uri;

use Zend\Uri\UriInterface;

/**
 * URI Canonicalizer
 */
class Canonicalizer
{
    /**
     * @var UriInterface
     */
    protected $uri;

    /**
     * @var string
     */
    protected $baseUrl;

    /**
     * @var bool
     */
    protected $isCanonicalized = false;

    /**
     * @param UriInterface $uri
     * @param null $baseUrl
     */
    public function __construct(UriInterface $uri, $baseUrl = null)
    {
        $this->uri     = $uri;
        $this->baseUrl = $baseUrl;
        $uriPath       = $this->uri->getPath();

        if (false !== strpos($uriPath, '/index.php')) {


            $this->uri->setPath(str_replace('/index.php', '', $uriPath));
            $this->isCanonicalized = true;
        }
    }

    /**
     * Return true if URI was canonicalized
     *
     * @return bool
     */
    public function isCanonicalized()
    {
        return $this->isCanonicalized;
    }

    /**
     * Canonicalize URI to use www or not
     *
     * @param bool $useWww
     * @return self
     */
    public function www($useWww)
    {
        $host        = $this->uri->getHost();
        $has         = (0 === strpos($host, 'www'));
        $dotsCount   = substr_count($host, '.');
        $isSubdomain = (!$has && 2 <= $dotsCount);
        $isLocalhost = (!$has && 0 === $dotsCount);

        if (($has && $useWww) || (!$has && !$useWww)
            || $isSubdomain
            || $isLocalhost
        ) {
            return $this;
        }

        $host = $useWww ? 'www.' . $host : preg_replace('~^www\.~', '', $host);
        $this->uri->setHost($host);
        $this->isCanonicalized = true;

        return $this;
    }

    /**
     * Canonicalize URI to use trailingSlash or not
     *
     * @param bool $useTrailingSlash
     * @return self
     */
    public function trailingSlash($useTrailingSlash)
    {
        $fullUriPath = $this->uri->getPath();
        $uriPath     = trim($fullUriPath, '/');
        $baseUrl     = trim($this->baseUrl, '/');

        if (empty($uriPath) || $uriPath === $baseUrl) {
            return $this;
        }

        $has = ('/' === $fullUriPath[strlen($fullUriPath) - 1]);
        $use = ($useTrailingSlash && !preg_match('~\.[a-zA-Z0-9]{1,}$~', $uriPath));

        if (($has && $use) || (!$has && !$use)) {
            return $this;
        }

        $newUriPath = $use ? '/' . $uriPath . '/' : '/' . $uriPath;
        $this->uri->setPath($newUriPath);
        $this->isCanonicalized = true;

        return $this;
    }

    /**
     * Return URI as string
     *
     * @return string
     */
    public function toString()
    {
        return $this->uri->toString();
    }

    /**
     * Magic method to convert the URI to a string
     *
     * @return string
     */
    public function __toString()
    {
        try {
            return $this->toString();
        } catch (\Exception $exc) {
            return '';
        }
    }
}


1			<?php
2			/**
3			* Webino (http://webino.sk)
4			*
5			* @link https://github.com/webino/WebinoCanonicalRedirect for the canonical source repository
6			* @copyright Copyright (c) 2014-2017 Webino, s. r. o. (http://webino.sk)
7			* @author Peter Bačinský <[email protected]>
8			* @license BSD-3-Clause
9			*/
10
11			namespace WebinoCanonicalRedirect\Uri;
12
13			use Zend\Uri\UriInterface;
14
15			/**
16			* URI Canonicalizer
17			*/
18			class Canonicalizer
19			{
20			/**
21			* @var UriInterface
22			*/
23			protected $uri;
24
25			/**
26			* @var string
27			*/
28			protected $baseUrl;
29
30			/**
31			* @var bool
32			*/
33			protected $isCanonicalized = false;
34
35			/**
36			* @param UriInterface $uri
37			* @param null $baseUrl
38			*/
39			public function __construct(UriInterface $uri, $baseUrl = null)
40			{
41			$this->uri = $uri;
42			$this->baseUrl = $baseUrl;
43			$uriPath = $this->uri->getPath();
44
45			if (false !== strpos($uriPath, '/index.php')) {
			0 ignored issues – show Coding Style introduced 2016-11-26 11:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this Blank line found at start of control structure Loading history...
46
47			$this->uri->setPath(str_replace('/index.php', '', $uriPath));
48			$this->isCanonicalized = true;
49			}
50			}
51
52			/**
53			* Return true if URI was canonicalized
54			*
55			* @return bool
56			*/
57			public function isCanonicalized()
58			{
59			return $this->isCanonicalized;
60			}
61
62			/**
63			* Canonicalize URI to use www or not
64			*
65			* @param bool $useWww
66			* @return self
67			*/
68			public function www($useWww)
69			{
70			$host = $this->uri->getHost();
71			$has = (0 === strpos($host, 'www'));
72			$dotsCount = substr_count($host, '.');
73			$isSubdomain = (!$has && 2 <= $dotsCount);
74			$isLocalhost = (!$has && 0 === $dotsCount);
75
76			if (($has && $useWww) \|\| (!$has && !$useWww)
77			\|\| $isSubdomain
78			\|\| $isLocalhost
79			) {
80			return $this;
81			}
82
83			$host = $useWww ? 'www.' . $host : preg_replace('~^www\.~', '', $host);
84			$this->uri->setHost($host);
85			$this->isCanonicalized = true;
86
87			return $this;
88			}
89
90			/**
91			* Canonicalize URI to use trailingSlash or not
92			*
93			* @param bool $useTrailingSlash
94			* @return self
95			*/
96			public function trailingSlash($useTrailingSlash)
97			{
98			$fullUriPath = $this->uri->getPath();
99			$uriPath = trim($fullUriPath, '/');
100			$baseUrl = trim($this->baseUrl, '/');
101
102			if (empty($uriPath) \|\| $uriPath === $baseUrl) {
103			return $this;
104			}
105
106			$has = ('/' === $fullUriPath[strlen($fullUriPath) - 1]);
107			$use = ($useTrailingSlash && !preg_match('~\.[a-zA-Z0-9]{1,}$~', $uriPath));
108
109			if (($has && $use) \|\| (!$has && !$use)) {
110			return $this;
111			}
112
113			$newUriPath = $use ? '/' . $uriPath . '/' : '/' . $uriPath;
114			$this->uri->setPath($newUriPath);
115			$this->isCanonicalized = true;
116
117			return $this;
118			}
119
120			/**
121			* Return URI as string
122			*
123			* @return string
124			*/
125			public function toString()
126			{
127			return $this->uri->toString();
128			}
129
130			/**
131			* Magic method to convert the URI to a string
132			*
133			* @return string
134			*/
135			public function __toString()
136			{
137			try {
138			return $this->toString();
139			} catch (\Exception $exc) {
140			return '';
141			}
142			}
143			}
144

webino / WebinoCanonicalRedirect

Issues (4)

Security Analysis no request data

src/WebinoCanonicalRedirect/Uri/Canonicalizer.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like