DispatchEvent::resetResponse() - Code Metrics - Inspection of "Enhanced" - webino/Webino - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — prototype ( 3bfdd7...aec713 )

by Peter

created 2017-10-27 17:15 UTC

DispatchEvent::resetResponse() A

↳ Parent: DispatchEvent

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	5
nc	2
nop	1
dl	0
loc	9
rs	9.6666
c	0
b	0
f	0

<?php
/**
 * Webino (http://webino.sk)
 *
 * @link        https://github.com/webino for the canonical source repository
 * @copyright   Copyright (c) 2015-2017 Webino, s.r.o. (http://webino.sk)
 * @author      Peter Bačinský <[email protected]>
 * @license     BSD-3-Clause
 */

namespace WebinoAppLib\Event;

use WebinoAppLib\Application\AbstractApplication;
use WebinoAppLib\Application\ConfiguredApplicationInterface;
use WebinoBaseLib\Util\ToString;
use Zend\Http\AbstractMessage;
use Zend\Stdlib\RequestInterface;
use Zend\Stdlib\ResponseInterface;

/**
 * Class DispatchEvent
 */
class DispatchEvent extends AppEvent implements
    DispatchEventInterface
{
    /**
     * @param ConfiguredApplicationInterface|AbstractApplication $app
     */
    public function __construct(ConfiguredApplicationInterface $app)
    {
        parent::__construct(AppEvent::DISPATCH);
        $this->setApp($app);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * @return RequestInterface
     */
    public function getRequest()
    {
        return $this->getEventParam($this::REQUEST);
    }

    /**
     * @param RequestInterface $request
     * @return $this
     */
    public function setRequest(RequestInterface $request)
    {
        $this->setEventParam($this::REQUEST, $request);
        return $this;
    }

    /**
     * @return ResponseInterface|AbstractMessage
     */
    public function getResponse()
    {
        return $this->getEventParam($this::RESPONSE);
    }

    /**
     * Set response
     *
     * It sets response content when response is a string.
     * It joins values to a string when response is an array.
     * It converts to string when response is an object.
     * It sets response object when response is an interface.
     *
     * @param string|array|ResponseInterface $response
     * @return $this
     */
    public function setResponse($response)
    {
        if ($response instanceof ResponseInterface) {
            $this->setEventParam($this::RESPONSE, $response);
            return $this;
        }

        $_response = $this->getResponse();
        $_response->setContent($_response->getContent() . $this->normalizeResponseContent($response));
        return $this;
    }

    /**
     * Reset response
     *
     * @param string|array|ResponseInterface $response
     * @return $this
     */
    public function resetResponse($response = null)
    {
        if ($response instanceof ResponseInterface) {
            // TODO implement??
            return $this;
        }
        $this->getResponse()->setContent($this->normalizeResponseContent($response));

        return $this;
    }

    /**
     * @param string|array $content
     * @return string
     */
    private function normalizeResponseContent($content)
    {
        return ToString::value($content);
    }
}


1			<?php
2			/**
3			* Webino (http://webino.sk)
4			*
5			* @link https://github.com/webino for the canonical source repository
6			* @copyright Copyright (c) 2015-2017 Webino, s.r.o. (http://webino.sk)
7			* @author Peter Bačinský <[email protected]>
8			* @license BSD-3-Clause
9			*/
10
11			namespace WebinoAppLib\Event;
12
13			use WebinoAppLib\Application\AbstractApplication;
14			use WebinoAppLib\Application\ConfiguredApplicationInterface;
15			use WebinoBaseLib\Util\ToString;
16			use Zend\Http\AbstractMessage;
17			use Zend\Stdlib\RequestInterface;
18			use Zend\Stdlib\ResponseInterface;
19
20			/**
21			* Class DispatchEvent
22			*/
23			class DispatchEvent extends AppEvent implements
24			DispatchEventInterface
25			{
26			/**
27			* @param ConfiguredApplicationInterface\|AbstractApplication $app
28			*/
29			public function __construct(ConfiguredApplicationInterface $app)
30			{
31			parent::__construct(AppEvent::DISPATCH);
32			$this->setApp($app);
			0 ignored issues – show Documentation introduced 2017-10-26 13:11 UTC by Report Bug Copy Issue Report `$app` is of type `object<WebinoAppLib\Appl...edApplicationInterface>`, but the function expects a `object<WebinoAppLib\Appl...on\AbstractApplication>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
33			}
34
35			/**
36			* @return RequestInterface
37			*/
38			public function getRequest()
39			{
40			return $this->getEventParam($this::REQUEST);
41			}
42
43			/**
44			* @param RequestInterface $request
45			* @return $this
46			*/
47			public function setRequest(RequestInterface $request)
48			{
49			$this->setEventParam($this::REQUEST, $request);
50			return $this;
51			}
52
53			/**
54			* @return ResponseInterface\|AbstractMessage
55			*/
56			public function getResponse()
57			{
58			return $this->getEventParam($this::RESPONSE);
59			}
60
61			/**
62			* Set response
63			*
64			* It sets response content when response is a string.
65			* It joins values to a string when response is an array.
66			* It converts to string when response is an object.
67			* It sets response object when response is an interface.
68			*
69			* @param string\|array\|ResponseInterface $response
70			* @return $this
71			*/
72			public function setResponse($response)
73			{
74			if ($response instanceof ResponseInterface) {
75			$this->setEventParam($this::RESPONSE, $response);
76			return $this;
77			}
78
79			$_response = $this->getResponse();
80			$_response->setContent($_response->getContent() . $this->normalizeResponseContent($response));
81			return $this;
82			}
83
84			/**
85			* Reset response
86			*
87			* @param string\|array\|ResponseInterface $response
88			* @return $this
89			*/
90			public function resetResponse($response = null)
91			{
92			if ($response instanceof ResponseInterface) {
93			// TODO implement??
94			return $this;
95			}
96			$this->getResponse()->setContent($this->normalizeResponseContent($response));
			0 ignored issues – show Bug introduced 2017-10-27 17:23 UTC by Report Bug Copy Issue Report It seems like `$response` defined by parameter `$response` on line 90 can also be of type `null`; however, `WebinoAppLib\Event\Dispa...malizeResponseContent()` does only seem to accept `string\|array`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
97			return $this;
98			}
99
100			/**
101			* @param string\|array $content
102			* @return string
103			*/
104			private function normalizeResponseContent($content)
105			{
106			return ToString::value($content);
107			}
108			}
109

webino / Webino

Push — prototype ( 3bfdd7...aec713 )

DispatchEvent::resetResponse() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like