WebinoConfigLib\Router\AbstractRoute

Complexity

Total Complexity

25

Size/Duplication

Total Lines	190
Duplicated Lines	8.42 %

Coupling/Cohesion

Components	2
Dependencies	2

Importance

Changes

0

17 Methods

Rating	Name	Duplication	Size	Complexity
A	hasName()	0	4	1
A	getName()	0	4	1
A	setName()	0	5	1
A	hasPath()	0	4	1
A	getPath()	0	4	1
A	setPath()	0	6	2
A	setRouteOption()	0	5	1
A	getType()	0	4	1
A	setType()	0	5	1
A	setMayTerminate()	0	5	1
A	getDefaults()	0	4	1
A	setDefaults()	8	8	2
A	setChild()	0	7	2
A	chain()	0	7	2
A	setHandlers()	8	8	2
A	appendRoute()	0	15	3
A	appendChildRoute()	0	9	2

<?php
/**
 * Webino (http://webino.sk)
 *
 * @link        https://github.com/webino for the canonical source repository
 * @copyright   Copyright (c) 2015-2017 Webino, s.r.o. (http://webino.sk)
 * @author      Peter Bačinský <peter@bacinsky.sk>
 * @license     BSD-3-Clause
 */

namespace WebinoConfigLib\Router;

use WebinoConfigLib\AbstractConfig;
use WebinoConfigLib\Exception\InvalidArgumentException;

/**
 * Class AbstractRoute
 */
abstract class AbstractRoute extends AbstractConfig implements
    RouteInterface
{
    /**
     * @var string
     */
    private $name;

    /**
     * @var string
     */
    private $path;

    /**
     * @return bool
     */
    public function hasName()
    {
        return !empty($this->name);
    }

    /**
     * @return string
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * {@inheritdoc}
     */
    public function setName($name)
    {
        $this->name = (string) $name;
        return $this;
    }

    /**
     * @return bool
     */
    protected function hasPath()
    {
        return !is_null($this->path);
    }

    /**
     * @return string
     */
    protected function getPath()
    {
        return $this->path;
    }

    /**
     * {@inheritdoc}
     */
    public function setPath($path)
    {
        $this->path = (string) $path;
        $path and $this->setRouteOption($path);

It seems like $path defined by parameter $path on line 76 can also be of type array; however, WebinoConfigLib\Router\AbstractRoute::setRouteOption() does only seem to accept string, maybe add an additional type check?

Using logical operators such as and instead of && is generally not recommended.

        return $this;
    }

    /**
     * @param string $route
     * @return $this
     */
    protected function setRouteOption($route)
    {
        $this->getData()->options['route'] = (string) $route;

The property options does not seem to exist in ArrayObject.

        return $this;
    }

    /**
     * @return string
     */
    public function getType()
    {
        return $this->getData()->type;

The property type does not seem to exist in ArrayObject.

    }

    /**
     * {@inheritdoc}
     */
    public function setType($type = self::LITERAL)
    {
        $this->getData()->type = (string) $type;

The property type does not seem to exist in ArrayObject.

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function setMayTerminate($mayTerminate = true)
    {
        $this->getData()->may_terminate = $mayTerminate;

The property may_terminate does not seem to exist in ArrayObject.

        return $this;
    }

    /**
     * @return array
     */
    protected function getDefaults()
    {
        return $this->getData()->options['defaults'];

The property options does not seem to exist in ArrayObject.

    }

    /**
     * {@inheritdoc}
     */
    public function setDefaults(array $defaults)

This method seems to be duplicated in your project.

    {
        $data = $this->getData();
        foreach ($defaults as $key => $value) {
            $data->options['defaults'][$key] = $value;

The property options does not seem to exist in ArrayObject.

        }
        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function setChild(array $routes)
    {
        foreach ($routes as $route) {
            $this->appendChildRoute($route);
        }
        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function chain(array $routes)
    {
        foreach ($routes as $route) {
            $this->appendRoute('chain_routes', $route);
        }
        return $this;
    }

    /**
     * @param array $handlers
     * @return $this
     */
    protected function setHandlers(array $handlers)

This method seems to be duplicated in your project.

    {
        $data = $this->getData();
        foreach ($handlers as $key => $value) {
            $data->options['defaults']['handlers'][$key] = $value;

The property options does not seem to exist in ArrayObject.

        }
        return $this;
    }

    /**
     * @param string $section
     * @param self $route
     * @return $this
     */
    protected function appendRoute($section, self $route)
    {
        if ($route->hasName()) {
            $this->mergeArray([$section => [$route->getName() => $route->toArray()]]);
            return $this;
        }

        if ($this->getData()->offsetExists($section)) {
            $this->getData()->{$section}[] = $route->toArray();
            return $this;
        }

        $this->mergeArray([$section => [$route->toArray()]]);
        return $this;
    }

    /**
     * @param RouteInterface $route
     * @return $this
     */
    protected function appendChildRoute(RouteInterface $route)
    {
        if (!($route instanceof self)) {
            throw (new InvalidArgumentException('Expected route of type %s but got %s'))
                ->format(self::class, get_class($route));
        }
        $this->appendRoute('child_routes', $route);

$route is of type object<WebinoConfigLib\Router\AbstractRoute>, but the function expects a object<self>.

        return $this;
    }
}