WebinoDomLib\Dom\Renderer::render()

Complexity

Conditions	5
Paths	5

Size

Total Lines	37
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function render(NodeLocatorInterface $doc, Config $cfg, RenderEvent $parentEvent = null, callable $callback = null)
    {
        /** @var Config\Spec $spec */
        foreach ($cfg->getQueue() as $spec) {
            // TODO skip if locator or node owner document empty

            $events = $this->getEvents();
            $nodes  = $doc->locate($spec->getLocator());

            $callback and call_user_func($callback, $spec, $nodes);

Using logical operators such as and instead of && is generally not recommended.

            /** @var NodeInterface $node */
            foreach ($nodes as $node) {

                $event = new RenderEvent($this, $node, $spec, $parentEvent);

It seems like $parentEvent defined by parameter $parentEvent on line 21 can also be of type object<WebinoDomLib\Event\RenderEvent>; however, WebinoDomLib\Event\RenderEvent::__construct() does only seem to accept null|object<self>, maybe add an additional type check?

                $events->attach(RenderEvent::class, function (RenderEvent $subEvent) use ($spec, $event) {
                    $view = $spec->getView();
                    if (empty($view)) {
                        return;
                    }

                    $this->render(
                        $subEvent->getNode(),
                        new Config($view),
                        $event,
                        function(Config\Spec $spec, NodeList $nodes) use ($subEvent) {
                            $subEvent->setNode($nodes, $spec->getKey());

$nodes is of type object<WebinoDomLib\Dom\NodeList>, but the function expects a object<WebinoDomLib\Dom\NodeInterface>.

                        }
                    );
                }, RenderEvent::FINISH);


                $events->trigger($event);
            }
        }
    }
}