Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 11 | View Code Duplication | class Link extends AbstractBaseViewComponent |
|
|
|
|||
| 12 | { |
||
| 13 | /** |
||
| 14 | * @var string |
||
| 15 | */ |
||
| 16 | private $href; |
||
| 17 | |||
| 18 | /** |
||
| 19 | * @var string |
||
| 20 | */ |
||
| 21 | private $name; |
||
| 22 | |||
| 23 | /** |
||
| 24 | * @param string|null $href Stylesheet source URL |
||
| 25 | * @param string|null $name Config spec key name |
||
| 26 | */ |
||
| 27 | public function __construct($href = null, $name = null) |
||
| 32 | |||
| 33 | /** |
||
| 34 | * {@inheritdoc} |
||
| 35 | */ |
||
| 36 | protected function getSpecName() |
||
| 40 | |||
| 41 | /** |
||
| 42 | * @param NodeView $node |
||
| 43 | */ |
||
| 44 | public function configure(NodeView $node) |
||
| 51 | } |
||
| 52 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.