SmtpMailer - Code Metrics - webino/Webino - Measure and Improve Code Quality continuously with Scrutinizer

SmtpMailer A
last analyzed 2017-12-02 21:12 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
dl	0
loc	33
rs	10
c	0
b	0
f	0
wmc	3
lcom	1
cbo	2

3 Methods

Rating	Name	Size	Complexity
A	__construct()	5	1
A	setSsl()	5	1
A	setTls()	5	1

<?php
/**
 * Webino™ (http://webino.sk)
 *
 * @link        https://github.com/webino for the canonical source repository
 * @copyright   Copyright (c) 2015-2017 Webino, s.r.o. (http://webino.sk)
 * @author      Peter Bačinský <[email protected]>
 * @license     BSD-3-Clause
 */

namespace WebinoConfigLib\Feature;

use WebinoConfigLib\Mail\Transport;

/**
 * Class SmtpMailer
 */
class SmtpMailer extends AbstractMailer
{
    /**
     * @param string $host
     * @param string $username
     * @param string $password
     */
    public function __construct($host, $username, $password)
    {
        parent::__construct();
        $this->transport = new Transport\Smtp($host, $username, $password);
    }

    /**
     * @param int $port
     * @return $this
     */
    public function setSsl($port = 465)
    {
        $this->transport->setSsl($port);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        return $this;
    }

    /**
     * @param int $port
     * @return $this
     */
    public function setTls($port = 587)
    {
        $this->transport->setTls($port);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        return $this;
    }
}


SmtpMailer A
last analyzed 2017-12-02 21:12 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Available Fixes

Available Fixes

1			<?php
2			/**
3			* Webino™ (http://webino.sk)
4			*
5			* @link https://github.com/webino for the canonical source repository
6			* @copyright Copyright (c) 2015-2017 Webino, s.r.o. (http://webino.sk)
7			* @author Peter Bačinský <[email protected]>
8			* @license BSD-3-Clause
9			*/
10
11			namespace WebinoConfigLib\Feature;
12
13			use WebinoConfigLib\Mail\Transport;
14
15			/**
16			* Class SmtpMailer
17			*/
18			class SmtpMailer extends AbstractMailer
19			{
20			/**
21			* @param string $host
22			* @param string $username
23			* @param string $password
24			*/
25			public function __construct($host, $username, $password)
26			{
27			parent::__construct();
28			$this->transport = new Transport\Smtp($host, $username, $password);
29			}
30
31			/**
32			* @param int $port
33			* @return $this
34			*/
35			public function setSsl($port = 465)
36			{
37			$this->transport->setSsl($port);
			0 ignored issues – show Bug introduced 2017-10-26 13:11 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `WebinoConfigLib\Mail\Transport\AbstractTransport` as the method `setSsl()` does only exist in the following sub-classes of `WebinoConfigLib\Mail\Transport\AbstractTransport`: `WebinoConfigLib\Mail\Transport\Smtp`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
38			return $this;
39			}
40
41			/**
42			* @param int $port
43			* @return $this
44			*/
45			public function setTls($port = 587)
46			{
47			$this->transport->setTls($port);
			0 ignored issues – show Bug introduced 2017-10-26 13:11 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `WebinoConfigLib\Mail\Transport\AbstractTransport` as the method `setTls()` does only exist in the following sub-classes of `WebinoConfigLib\Mail\Transport\AbstractTransport`: `WebinoConfigLib\Mail\Transport\Smtp`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
48			return $this;
49			}
50			}
51

webino / Webino

SmtpMailer A last analyzed 2017-12-02 21:12 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

SmtpMailer A
last analyzed 2017-12-02 21:12 UTC