AppBundle\ConsolidateUsedFiles\Task

Complexity

Total Complexity

3

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
B	consolidate()	0	26	3

<?php

namespace AppBundle\ConsolidateUsedFiles;

use Helper\FileSystem;
use Helper\NullStyle;
use Symfony\Component\Console\Style\StyleInterface;

/**
 * Consolidate the list of used files by removing duplicates and sorting them. Improves performance for later tasks.
 */
final class Task
{
    /**
     * @param string $userProvidedPathToConsolidate
     * @param StyleInterface|null $ioStyle
     */
    public function consolidate($userProvidedPathToConsolidate, StyleInterface $ioStyle = null)
    {
        if ($ioStyle === null) {
            $ioStyle = new NullStyle();
        }
        $ioStyle->progressStart(4);

        $pathToConsolidate = FileSystem::getRealPathToReadableAndWritableFile($userProvidedPathToConsolidate);
        if (!$pathToConsolidate) {

The expression $pathToConsolidate of type null|string is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === null instead.

            $message = $userProvidedPathToConsolidate . ' has to be a file both readable and writable.';
            $ioStyle->error($message);
            throw new \InvalidArgumentException($message);
        }
        $ioStyle->progressAdvance();

        $usedFiles = FileSystem::readFileIntoArray($pathToConsolidate);
        $ioStyle->progressAdvance();

        $usedFiles = array_unique($usedFiles);

It seems like $usedFiles can also be of type boolean; however, parameter $array of array_unique() does only seem to accept array, maybe add an additional type check?

        sort($usedFiles);
        $ioStyle->progressAdvance();

        FileSystem::writeArrayToFile($usedFiles, $pathToConsolidate);
        $ioStyle->progressFinish();

        $ioStyle->success('Finished consolidating ' . $pathToConsolidate);
    }
}