OpeningHoursAttribute::parseOpeningHoursForDB() - Code Metrics - Inspection of "add scopes trait and tests" - webfactor/laravel-openinghours - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 518ca5...423f94 )

by Oliver

created 2018-02-09 10:45 UTC

OpeningHoursAttribute::parseOpeningHoursForDB() A

↳ Parent: OpeningHoursAttribute

Complexity

Conditions	1
Paths	1

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	16
c	0
b	0
f	0
ccs	9
cts	9
cp	1
rs	9.4285
cc	1
eloc	9
nc	1
nop	1
crap	1

<?php

namespace Webfactor\Laravel\OpeningHours\Traits;

use Webfactor\Laravel\OpeningHours\Entities\OpeningHours;
use Webfactor\Laravel\OpeningHours\Entities\OpeningHoursForDay;
use Webfactor\Laravel\OpeningHours\Entities\TimeRange;
use Webfactor\Laravel\OpeningHours\Exceptions\Exception;
use Webfactor\Laravel\OpeningHours\Models\DayOpenTimeRange;

trait OpeningHoursAttribute
{
    public function getOpeningHoursAttribute()

    {
        if (!key_exists('opening_hours', $this->attributes) || !$this->attributes['opening_hours']) {
            $hours = $this->dayOpenTimeRanges
class MyClass { }

$x = new MyClass();
$x->foo = true;
                ->groupBy('day')->map(function ($day) {
                    return $day->map(function (DayOpenTimeRange $range) {
                        return $range->start.'-'.$range->end;
                    });
                });

            $this->attributes['opening_hours'] = OpeningHours::create($hours->toArray());
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }

        return $this->attributes['opening_hours'];

    }

    public function setOpeningHoursAttribute($data)
    {
        // clear previous open times
        $this->attributes['opening_hours'] = null;
        $this->dayOpenTimeRanges()->delete();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        if ($data == null) {
            return;
        }

        if ($data instanceof OpeningHours) {
            $this->applyOpeningHours($data);
            return;
        }

        if (is_array($data) || is_object($data)) {
            $this->applyOpeningHours(OpeningHours::create((array) $data));
            return;
        }

        throw new Exception("Invalid argument `{$data}` applied to opening hours attribute.");
    }

    private function applyOpeningHours(OpeningHours $openingHours)
    {
        $entries = $this->parseOpeningHoursForDB($openingHours);
        $this->dayOpenTimeRanges()->saveMany($entries);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->attributes['opening_hours'] = $openingHours;
    }

    private function parseOpeningHoursForDB(OpeningHours $openingHours)
    {
        $ranges = $openingHours->flatMap(function (OpeningHoursForDay $openingHoursForDay, string $day) {
            return $openingHoursForDay->map(function (TimeRange $timeRange) use ($day) {
                return [
                    'day'   => $day,
                    'start' => $timeRange->start(),
                    'end'   => $timeRange->end()
                ];
            });
        });

        return collect($ranges)->map(function ($range) {
            return new DayOpenTimeRange($range);
        });
    }
}

1		<?php
2
3		namespace Webfactor\Laravel\OpeningHours\Traits;
4
5		use Webfactor\Laravel\OpeningHours\Entities\OpeningHours;
6		use Webfactor\Laravel\OpeningHours\Entities\OpeningHoursForDay;
7		use Webfactor\Laravel\OpeningHours\Entities\TimeRange;
8		use Webfactor\Laravel\OpeningHours\Exceptions\Exception;
9		use Webfactor\Laravel\OpeningHours\Models\DayOpenTimeRange;
10
11		trait OpeningHoursAttribute
12		{
13	6	public function getOpeningHoursAttribute()
		0 ignored issues – show Documentation introduced 2018-02-09 10:48 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
14		{
15	6	if (!key_exists('opening_hours', $this->attributes) \|\| !$this->attributes['opening_hours']) {
16	4	$hours = $this->dayOpenTimeRanges
		0 ignored issues – show Bug introduced 2018-02-08 20:55 UTC by Report Bug Copy Issue Report The property `dayOpenTimeRanges` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
17		->groupBy('day')->map(function ($day) {
18	2	return $day->map(function (DayOpenTimeRange $range) {
19	2	return $range->start.'-'.$range->end;
20	2	});
21	4	});
22
23	4	$this->attributes['opening_hours'] = OpeningHours::create($hours->toArray());
		0 ignored issues – show Bug introduced 2018-02-09 10:48 UTC by Report Bug Copy Issue Report The property `attributes` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
24		}
25
26	6	return $this->attributes['opening_hours'];
27
28		}
29
30	14	public function setOpeningHoursAttribute($data)
31		{
32		// clear previous open times
33	14	$this->attributes['opening_hours'] = null;
34	14	$this->dayOpenTimeRanges()->delete();
		0 ignored issues – show Bug introduced 2018-02-09 10:48 UTC by Report Bug Copy Issue Report It seems like `dayOpenTimeRanges()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
35
36	14	if ($data == null) {
37	2	return;
38		}
39
40	12	if ($data instanceof OpeningHours) {
41	1	$this->applyOpeningHours($data);
42	1	return;
43		}
44
45	11	if (is_array($data) \|\| is_object($data)) {
46	11	$this->applyOpeningHours(OpeningHours::create((array) $data));
47	11	return;
48		}
49
50		throw new Exception("Invalid argument `{$data}` applied to opening hours attribute.");
51		}
52
53	12	private function applyOpeningHours(OpeningHours $openingHours)
54		{
55	12	$entries = $this->parseOpeningHoursForDB($openingHours);
56	12	$this->dayOpenTimeRanges()->saveMany($entries);
		0 ignored issues – show Bug introduced 2018-02-09 10:48 UTC by Report Bug Copy Issue Report It seems like `dayOpenTimeRanges()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
57	12	$this->attributes['opening_hours'] = $openingHours;
58	12	}
59
60		private function parseOpeningHoursForDB(OpeningHours $openingHours)
61		{
62		$ranges = $openingHours->flatMap(function (OpeningHoursForDay $openingHoursForDay, string $day) {
63	12	return $openingHoursForDay->map(function (TimeRange $timeRange) use ($day) {
64		return [
65	12	'day' => $day,
66	12	'start' => $timeRange->start(),
67	12	'end' => $timeRange->end()
68		];
69	12	});
70	12	});
71
72	12	return collect($ranges)->map(function ($range) {
73	12	return new DayOpenTimeRange($range);
74	12	});
75		}
76		}

webfactor / laravel-openinghours

Push — master ( 518ca5...423f94 )

OpeningHoursAttribute::parseOpeningHoursForDB() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like