LanguageFileService::buildFileContent() - Code Metrics - Inspection of "Merge pull request #12 from webfactor/3.0" - webfactor/laravel-generators - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 1f7f34...948e88 )

by Thomas

created 2018-06-24 22:55 UTC

LanguageFileService::buildFileContent() A

↳ Parent: LanguageFileService

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	13
ccs	0
cts	11
cp	0
rs	9.8333
c	0
b	0
f	0
cc	2
nc	2
nop	0
crap	6

<?php

namespace Webfactor\Laravel\Generators\Services;

use Webfactor\Laravel\Generators\Contracts\ServiceAbstract;
use Webfactor\Laravel\Generators\Contracts\ServiceInterface;
use Webfactor\Laravel\Generators\Helper\ShortSyntaxArray;
use Webfactor\Laravel\Generators\Traits\CanGenerateFile;

class LanguageFileService extends ServiceAbstract implements ServiceInterface
{
    use CanGenerateFile;

    protected $key = 'languageFile';

    /**
     * Build the language file.
     *
     * @param string $name
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return string

     */
    private function buildFileContent()

    {
        if ($this->filesystem->exists($this->naming->getFile())) {
            $translation = include $this->naming->getFile();
        }

        $translation = array_add($translation, $this->naming->getName(), [
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            'singular' => $this->naming->getSingular(),
            'plural'   => $this->naming->getPlural(),
        ]);

        $this->fileContent = $this->getTranslationFileContent($translation);
    }

    private function getTranslationFileContent(array $translation)

    {
        $content = ShortSyntaxArray::parse($translation);

        return <<<FILE
<?php
        
return {$content};
FILE;
    }
}


1			<?php
2
3			namespace Webfactor\Laravel\Generators\Services;
4
5			use Webfactor\Laravel\Generators\Contracts\ServiceAbstract;
6			use Webfactor\Laravel\Generators\Contracts\ServiceInterface;
7			use Webfactor\Laravel\Generators\Helper\ShortSyntaxArray;
8			use Webfactor\Laravel\Generators\Traits\CanGenerateFile;
9
10			class LanguageFileService extends ServiceAbstract implements ServiceInterface
11			{
12			use CanGenerateFile;
13
14			protected $key = 'languageFile';
15
16			/**
17			* Build the language file.
18			*
19			* @param string $name
			0 ignored issues – show Bug introduced 2018-03-30 17:09 UTC by Report Bug Copy Issue Report There is no parameter named `$name`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
20			*
21			* @return string
			0 ignored issues – show Documentation introduced 2018-03-30 17:09 UTC by Report Bug Copy Issue Report Should the return type not be `string\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
22			*/
23			private function buildFileContent()
			0 ignored issues – show Unused Code introduced 2018-06-24 22:56 UTC by Report Bug Copy Issue Report This method is not used, and could be removed. Loading history...
24			{
25			if ($this->filesystem->exists($this->naming->getFile())) {
26			$translation = include $this->naming->getFile();
27			}
28
29			$translation = array_add($translation, $this->naming->getName(), [
			0 ignored issues – show Bug introduced 2018-06-24 22:56 UTC by Report Bug Copy Issue Report The variable `$translation` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
30			'singular' => $this->naming->getSingular(),
31			'plural' => $this->naming->getPlural(),
32			]);
33
34			$this->fileContent = $this->getTranslationFileContent($translation);
35			}
36
37			private function getTranslationFileContent(array $translation)
			0 ignored issues – show Documentation introduced 2018-06-24 22:56 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
38			{
39			$content = ShortSyntaxArray::parse($translation);
40
41			return <<<FILE
42			<?php
43
44			return {$content};
45			FILE;
46			}
47			}
48

webfactor / laravel-generators

Push — master ( 1f7f34...948e88 )

LanguageFileService::buildFileContent() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like