webfactor / laravel-backpack-nestedmodels

src/Controllers/NestedModelsCrudController.php

<?php

namespace Webfactor\Laravel\Backpack\NestedModels\Controllers;

use Backpack\CRUD\app\Http\Controllers\CrudController;
use Backpack\CRUD\app\Http\Requests\CrudRequest as StoreRequest;
use Illuminate\Http\Request;

class NestedModelsCrudController extends CrudController
{
    public function treeSetup()
    {
        $this->crud->setListView('nestedmodels::treecrud');
        $this->crud->orderBy('lft');

        $this->crud->allowAccess('reorder');
    }

    public function index()
    {
        $this->crud->hasAccessOrFail('list');

        $this->data['crud'] = $this->crud;
        $this->data['title'] = ucfirst($this->crud->entity_name_plural);

        $entries = $this->data['crud']->getEntries();
        $this->data['entries'] = $this->crud->model::loadTree($entries);

The method loadTree cannot be called on $this->crud->model (of type string).

        return view($this->crud->getListView(), $this->data);

The expression view($this->crud->getListView(), $this->data); of type Illuminate\View\View|Illuminate\Contracts\View\Factory adds the type Illuminate\Contracts\View\Factory to the return on line 29 which is incompatible with the return type of the parent method Backpack\CRUD\app\Http\Controllers\CrudController::index of type Illuminate\View\View.

    }

    public function create()
    {
        $request = \Request::instance();

        if ($parent = $request->get('parent')) {
            $this->crud->addField([
                'name'  => 'parent_id',
                'type'  => 'hidden',
                'value' => $parent
            ]);
        }

        if ($request->wantsJson()) {
            return $this->ajaxCreate($request);
        }

        return parent::create();
    }

    public function ajaxCreate(Request $request)

The parameter $request is not used and could be removed.

    {
        $this->crud->hasAccessOrFail('create');

        // prepare the fields you need to show
        $this->data['crud'] = $this->crud;
        $this->data['saveAction'] = $this->getSaveAction();
        $this->data['fields'] = $this->crud->getCreateFields();
        $this->data['title'] = trans('backpack::crud.add').' '.$this->crud->entity_name;

        // load the view from /resources/views/vendor/backpack/crud/ if it exists, otherwise load the one in the package
        return view('nestedmodels::ajax.create', $this->data);
    }

    public function storeCrud(StoreRequest $request = null)
    {
        if ($request->wantsJson()) {

It seems like $request is not always an object, but can also be of type null. Maybe add an additional type check?

            return $this->ajaxStore($request);

It seems like $request defined by parameter $request on line 65 can be null; however, Webfactor\Laravel\Backpack\NestedModels\Controllers\NestedModelsCrudController::ajaxStore() does not accept null, maybe add an additional type check?

The return type of return $this->ajaxStore($request); (Illuminate\Database\Eloquent\Model) is incompatible with the return type of the parent method Backpack\CRUD\app\Http\Controllers\CrudController::storeCrud of type Illuminate\Http\RedirectResponse.

        }

        // your additional operations before save here
        $redirect_location = parent::storeCrud($request);
        // your additional operations after save here
        // use $this->data['entry'] or $this->crud->entry
        return $redirect_location;
    }

    public function ajaxStore(StoreRequest $request)
    {
        $this->crud->hasAccessOrFail('create');

        // fallback to global request instance
        if (is_null($request)) {
            $request = \Request::instance();
        }

        // replace empty values with NULL, so that it will work with MySQL strict mode on
        foreach ($request->input() as $key => $value) {

The expression $request->input() of type string|array|null is not guaranteed to be traversable. How about adding an additional type check?

            if (empty($value) && $value !== '0') {
                $request->request->set($key, null);
            }
        }

        // insert item in the db
        return $this->crud->create($request->except(['save_action', '_token', '_method']));
    }

    public function saveReorder()
    {
        $this->crud->hasAccess('reorder');
        $request = \Request::instance();

        $this->crud->model::rebuildTree($request->all());

The method rebuildTree cannot be called on $this->crud->model (of type string).

        return (string) true;
    }
}