NestedModelsCrudController::saveReorder() - Code Metrics - Inspection of "shows tree instead of list" - webfactor/laravel-backpack-nestedmodels - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( 2ef870...fe443a )

by Oliver

created 2018-02-03 10:51 UTC

NestedModelsCrudController::saveReorder() A

↳ Parent: NestedModelsCrudController

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	0

<?php

namespace Webfactor\Laravel\Backpack\NestedModels\Controllers;

use Backpack\CRUD\app\Http\Controllers\CrudController;
use Backpack\CRUD\app\Http\Requests\CrudRequest as StoreRequest;
use Illuminate\Http\Request;

class NestedModelsCrudController extends CrudController
{

    public function setup()
    {
        parent::setup();

        $this->crud->setListView('nestedmodels::treecrud');
        $this->crud->orderBy('lft');

        $this->crud->allowAccess('reorder');
    }

    public function index()
    {
        $this->crud->hasAccessOrFail('list');

        $this->data['crud'] = $this->crud;
        $this->data['title'] = ucfirst($this->crud->entity_name_plural);

        $entries = $this->data['crud']->getEntries();
        $this->data['entries'] = $this->crud->model::loadTree($entries);


        return view($this->crud->getListView(), $this->data);
    }

    public function create()
    {
        $request = \Request::instance();

        if ($parent = $request->get('parent')) {
            $this->crud->addField([
                'name'  => 'parent_id',
                'type'  => 'hidden',
                'value' => $parent
            ]);
        }

        if ($request->wantsJson()) {
            return $this->ajaxCreate($request);
        }

        return parent::create();
    }

    public function ajaxCreate(Request $request)

    {
        $this->crud->hasAccessOrFail('create');

        // prepare the fields you need to show
        $this->data['crud'] = $this->crud;
        $this->data['saveAction'] = $this->getSaveAction();
        $this->data['fields'] = $this->crud->getCreateFields();
        $this->data['title'] = trans('backpack::crud.add').' '.$this->crud->entity_name;

        // load the view from /resources/views/vendor/backpack/crud/ if it exists, otherwise load the one in the package
        return view('nestedmodels::ajax.create', $this->data);
    }

    public function storeCrud(StoreRequest $request = null)

    {
        if ($request->wantsJson()) {
function someFunction(A $objectMaybe = null)
{
    if ($objectMaybe instanceof A) {
        $objectMaybe->doSomething();
    }
}
            return $this->ajaxStore($request);
function notNullable(stdClass $x) { }

// Unsafe
function withoutCheck(stdClass $x = null) {
    notNullable($x);
}

// Safe - Alternative 1: Adding Additional Type-Check
function withCheck(stdClass $x = null) {
    if ($x instanceof stdClass) {
        notNullable($x);
    }
}

// Safe - Alternative 2: Changing Parameter
function withNonNullableParam(stdClass $x) {
    notNullable($x);
}
        }

        // your additional operations before save here
        $redirect_location = parent::storeCrud($request);
        // your additional operations after save here
        // use $this->data['entry'] or $this->crud->entry

        return $redirect_location;
    }

    public function ajaxStore(StoreRequest $request)

    {
        $this->crud->hasAccessOrFail('create');

        // fallback to global request instance
        if (is_null($request)) {
            $request = \Request::instance();
        }

        // replace empty values with NULL, so that it will work with MySQL strict mode on
        foreach ($request->input() as $key => $value) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            if (empty($value) && $value !== '0') {
                $request->request->set($key, null);
            }
        }

        // insert item in the db
        return $this->crud->create($request->except(['save_action', '_token', '_method']));
    }

    public function saveReorder()
    {
        $this->crud->hasAccess('reorder');
        $request = \Request::instance();

        $this->crud->model::rebuildTree($request->all());


        return (string) true;

    }

}

1			<?php
2
3			namespace Webfactor\Laravel\Backpack\NestedModels\Controllers;
4
5			use Backpack\CRUD\app\Http\Controllers\CrudController;
6			use Backpack\CRUD\app\Http\Requests\CrudRequest as StoreRequest;
7			use Illuminate\Http\Request;
8
9			class NestedModelsCrudController extends CrudController
10			{
11
12			public function setup()
13			{
14			parent::setup();
15
16			$this->crud->setListView('nestedmodels::treecrud');
17			$this->crud->orderBy('lft');
18
19			$this->crud->allowAccess('reorder');
20			}
21
22			public function index()
23			{
24			$this->crud->hasAccessOrFail('list');
25
26			$this->data['crud'] = $this->crud;
27			$this->data['title'] = ucfirst($this->crud->entity_name_plural);
28
29			$entries = $this->data['crud']->getEntries();
30			$this->data['entries'] = $this->crud->model::loadTree($entries);
			0 ignored issues – show Bug introduced 2018-02-03 10:24 UTC by Report Bug Copy Issue Report The method `loadTree` cannot be called on `$this->crud->model` (of type `string`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
31
32			return view($this->crud->getListView(), $this->data);
33			}
34
35			public function create()
36			{
37			$request = \Request::instance();
38
39			if ($parent = $request->get('parent')) {
40			$this->crud->addField([
41			'name' => 'parent_id',
42			'type' => 'hidden',
43			'value' => $parent
44			]);
45			}
46
47			if ($request->wantsJson()) {
48			return $this->ajaxCreate($request);
49			}
50
51			return parent::create();
52			}
53
54			public function ajaxCreate(Request $request)
			0 ignored issues – show Unused Code introduced 2018-02-03 10:24 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
55			{
56			$this->crud->hasAccessOrFail('create');
57
58			// prepare the fields you need to show
59			$this->data['crud'] = $this->crud;
60			$this->data['saveAction'] = $this->getSaveAction();
61			$this->data['fields'] = $this->crud->getCreateFields();
62			$this->data['title'] = trans('backpack::crud.add').' '.$this->crud->entity_name;
63
64			// load the view from /resources/views/vendor/backpack/crud/ if it exists, otherwise load the one in the package
65			return view('nestedmodels::ajax.create', $this->data);
66			}
67
68			public function storeCrud(StoreRequest $request = null)
			0 ignored issues – show Documentation introduced 2018-02-03 10:53 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
69			{
70			if ($request->wantsJson()) {
			0 ignored issues – show Bug introduced 2018-02-03 10:53 UTC by Report Bug Copy Issue Report It seems like `$request` is not always an object, but can also be of type `null`. Maybe add an additional type check? If a variable is not always an object, we recommend to add an additional type check to ensure your method call is safe: function someFunction(A $objectMaybe = null) { if ($objectMaybe instanceof A) { $objectMaybe->doSomething(); } } Loading history...
71			return $this->ajaxStore($request);
			0 ignored issues – show Bug introduced 2018-02-03 10:53 UTC by Report Bug Copy Issue Report It seems like `$request` defined by parameter `$request` on line `68` can be `null`; however, `Webfactor\Laravel\Backpa...Controller::ajaxStore()` does not accept `null`, maybe add an additional type check? It seems like you allow that null is being passed for a parameter, however the function which is called does not seem to accept null. We recommend to add an additional type check (or disallow null for the parameter): function notNullable(stdClass $x) { } // Unsafe function withoutCheck(stdClass $x = null) { notNullable($x); } // Safe - Alternative 1: Adding Additional Type-Check function withCheck(stdClass $x = null) { if ($x instanceof stdClass) { notNullable($x); } } // Safe - Alternative 2: Changing Parameter function withNonNullableParam(stdClass $x) { notNullable($x); } Loading history...
72			}
73
74			// your additional operations before save here
75			$redirect_location = parent::storeCrud($request);
76			// your additional operations after save here
77			// use $this->data['entry'] or $this->crud->entry
			0 ignored issues – show Unused Code Comprehensibility introduced 2018-02-03 10:24 UTC by Report Bug Copy Issue Report `59%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
78			return $redirect_location;
79			}
80
81			public function ajaxStore(StoreRequest $request)
			0 ignored issues – show Documentation introduced 2018-02-03 10:24 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
82			{
83			$this->crud->hasAccessOrFail('create');
84
85			// fallback to global request instance
86			if (is_null($request)) {
87			$request = \Request::instance();
88			}
89
90			// replace empty values with NULL, so that it will work with MySQL strict mode on
91			foreach ($request->input() as $key => $value) {
			0 ignored issues – show Bug introduced 2018-02-03 10:24 UTC by Report Bug Copy Issue Report The expression `$request->input()` of type `string\|array` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
92			if (empty($value) && $value !== '0') {
93			$request->request->set($key, null);
94			}
95			}
96
97			// insert item in the db
98			return $this->crud->create($request->except(['save_action', '_token', '_method']));
99			}
100
101			public function saveReorder()
102			{
103			$this->crud->hasAccess('reorder');
104			$request = \Request::instance();
105
106			$this->crud->model::rebuildTree($request->all());
			0 ignored issues – show Bug introduced 2018-02-03 10:53 UTC by Report Bug Copy Issue Report The method `rebuildTree` cannot be called on `$this->crud->model` (of type `string`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
107
108			return (string) true;
109
110			}
111
112			}

webfactor / laravel-backpack-nestedmodels

Push — master ( 2ef870...fe443a )

NestedModelsCrudController::saveReorder() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like