Issues in ImageRendererTraitTest.php (master) - Issues in master - webeweb/jquery-datatables-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Issues (117)

Tests/Renderer/Assets/ImageRendererTraitTest.php (1 issue)

Labels

Bug 1

Severity

Minor 1

<?php

/*
 * This file is part of the jquery-datatables-bundle package.
 *
 * (c) 2021 WEBEWEB
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace WBW\Bundle\JQuery\DataTablesBundle\Tests\Renderer\Assets;

use WBW\Bundle\JQuery\DataTablesBundle\Tests\AbstractTestCase;
use WBW\Bundle\JQuery\DataTablesBundle\Tests\Fixtures\Renderer\Assets\TestImageRendererTrait;

/**
 * Image renderer trait test.
 *
 * @author webeweb <https://github.com/webeweb>
 * @package WBW\Bundle\JQuery\DataTablesBundle\Tests\Renderer\Assets
 */
class ImageRendererTraitTest extends AbstractTestCase {

    /**
     * Test renderImage()
     *
     * @return void
     */
    public function testRenderImage(): void {

        $obj = new TestImageRendererTrait();

        $this->assertNull($obj->renderImage(null));
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        $this->assertEquals('<img src="src"/>', $obj->renderImage("src"));
        $this->assertEquals('<img src="src" alt="alt"/>', $obj->renderImage("src", "alt"));
        $this->assertEquals('<img src="src" alt="alt" width="width"/>', $obj->renderImage("src", "alt", "width"));
        $this->assertEquals('<img src="src" alt="alt" width="width" height="height"/>', $obj->renderImage("src", "alt", "width", "height"));
    }
}


1			<?php
2
3			/*
4			* This file is part of the jquery-datatables-bundle package.
5			*
6			* (c) 2021 WEBEWEB
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace WBW\Bundle\JQuery\DataTablesBundle\Tests\Renderer\Assets;
13
14			use WBW\Bundle\JQuery\DataTablesBundle\Tests\AbstractTestCase;
15			use WBW\Bundle\JQuery\DataTablesBundle\Tests\Fixtures\Renderer\Assets\TestImageRendererTrait;
16
17			/**
18			* Image renderer trait test.
19			*
20			* @author webeweb <https://github.com/webeweb>
21			* @package WBW\Bundle\JQuery\DataTablesBundle\Tests\Renderer\Assets
22			*/
23			class ImageRendererTraitTest extends AbstractTestCase {
24
25			/**
26			* Test renderImage()
27			*
28			* @return void
29			*/
30			public function testRenderImage(): void {
31
32			$obj = new TestImageRendererTrait();
33
34			$this->assertNull($obj->renderImage(null));
			0 ignored issues – show Bug introduced 2023-01-02 11:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$obj->renderImage(null)` targeting `WBW\Bundle\JQuery\DataTa...rerTrait::renderImage()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
35			$this->assertEquals('<img src="src"/>', $obj->renderImage("src"));
36			$this->assertEquals('<img src="src" alt="alt"/>', $obj->renderImage("src", "alt"));
37			$this->assertEquals('<img src="src" alt="alt" width="width"/>', $obj->renderImage("src", "alt", "width"));
38			$this->assertEquals('<img src="src" alt="alt" width="width" height="height"/>', $obj->renderImage("src", "alt", "width", "height"));
39			}
40			}
41

webeweb / jquery-datatables-bundle

Issues (117)

Tests/Renderer/Assets/ImageRendererTraitTest.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like