WBW\Bundle\JQuery\DataTablesBundle\Manager\DataTablesManager

Complexity

Total Complexity

6

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Importance

Changes	3
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	addProvider()	0	12	3
A	getProvider()	0	10	3

<?php

/*
 * This file is part of the jquery-datatables-bundle package.
 *
 * (c) 2018 WEBEWEB
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace WBW\Bundle\JQuery\DataTablesBundle\Manager;

use InvalidArgumentException;
use WBW\Bundle\JQuery\DataTablesBundle\Exception\AlreadyRegisteredDataTablesProviderException;
use WBW\Bundle\JQuery\DataTablesBundle\Exception\UnregisteredDataTablesProviderException;
use WBW\Bundle\JQuery\DataTablesBundle\Provider\DataTablesProviderInterface;
use WBW\Library\Symfony\Manager\AbstractManager;
use WBW\Library\Symfony\Manager\ManagerInterface;
use WBW\Library\Symfony\Provider\ProviderInterface;

/**
 * DataTables manager.
 *
 * @author webeweb <https://github.com/webeweb>
 * @package WBW\Bundle\JQuery\DataTablesBundle\Manager
 */
class DataTablesManager extends AbstractManager {

    /**
     * Service name.
     *
     * @var string
     */
    const SERVICE_NAME = "wbw.jquery.datatables.manager";

    /**
     * {@inheritdoc}
     */
    public function addProvider(ProviderInterface $provider): ManagerInterface {

        if (false === ($provider instanceof DataTablesProviderInterface)) {
            throw new InvalidArgumentException("The provider must implements " . DataTablesProviderInterface::class);
        }

        /** @var DataTablesProviderInterface $provider */
        if (true === $this->containsProvider($provider)) {
            throw new AlreadyRegisteredDataTablesProviderException($provider->getName());
        }

        return parent::addProvider($provider);
    }

    /**
     * Get a provider.
     *
     * @param string $name The name.
     * @return DataTablesProviderInterface Returns the provider.
     * @throws UnregisteredDataTablesProviderException Throws an unregistered provider exception.
     */
    public function getProvider(string $name): DataTablesProviderInterface {

        /** @var DataTablesProviderInterface $current */
        foreach ($this->getProviders() as $current) {
            if ($name === $current->getName()) {

The method getName() does not exist on WBW\Library\Symfony\Provider\ProviderInterface. It seems like you code against a sub-type of WBW\Library\Symfony\Provider\ProviderInterface such as WBW\Bundle\CoreBundle\Provider\AssetsProviderInterface or WBW\Library\Symfony\Provider\ColorProviderInterface or WBW\Bundle\CoreBundle\Provider\SkeletonProviderInterface or WBW\Bundle\JQuery\DataTablesBundle\Provider\DataTablesProviderInterface or WBW\Bundle\JQuery\DataTablesBundle\Tests\Fixtures\Provider\EmployeeDataTablesProvider or WBW\Bundle\JQuery\DataTablesBundle\Tests\Fixtures\Provider\EmployeeDataTablesProvider or WBW\Library\Symfony\Provider\Theme\ApplicationThemeProviderInterface.

                return $current;

The expression return $current returns the type WBW\Library\Symfony\Provider\ProviderInterface which includes types incompatible with the type-hinted return WBW\Bundle\JQuery\DataTablesBundle\Provider\DataTablesProviderInterface.

            }
        }

        throw new UnregisteredDataTablesProviderException($name);
    }
}