Conditions | 1 |
Paths | 1 |
Total Lines | 143 |
Code Lines | 85 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
112 | public function testToArray() { |
||
113 | |||
114 | $obj = new \WBW\Bundle\HighchartsBundle\API\Chart\Series\Pie\HighchartsDataLabels(true); |
||
115 | |||
116 | $obj->setBackgroundColor("930f2a43179a7ae5fc25ed873223e99f"); |
||
117 | |||
118 | $res1 = ["backgroundColor" => "930f2a43179a7ae5fc25ed873223e99f"]; |
||
119 | $this->assertEquals($res1, $obj->toArray()); |
||
120 | |||
121 | $obj->setBorderColor("97da935a74593c55d78be9d1295aa994"); |
||
122 | |||
123 | $res2 = ["backgroundColor" => "930f2a43179a7ae5fc25ed873223e99f", "borderColor" => "97da935a74593c55d78be9d1295aa994"]; |
||
124 | $this->assertEquals($res2, $obj->toArray()); |
||
125 | |||
126 | $obj->setBorderRadius(78); |
||
127 | |||
128 | $res3 = ["backgroundColor" => "930f2a43179a7ae5fc25ed873223e99f", "borderColor" => "97da935a74593c55d78be9d1295aa994", "borderRadius" => 78]; |
||
129 | $this->assertEquals($res3, $obj->toArray()); |
||
130 | |||
131 | $obj->setBorderWidth(47); |
||
132 | |||
133 | $res4 = ["backgroundColor" => "930f2a43179a7ae5fc25ed873223e99f", "borderColor" => "97da935a74593c55d78be9d1295aa994", "borderRadius" => 78, "borderWidth" => 47]; |
||
134 | $this->assertEquals($res4, $obj->toArray()); |
||
135 | |||
136 | $obj->setClassName("6f66e878c62db60568a3487869695820"); |
||
137 | |||
138 | $res5 = ["backgroundColor" => "930f2a43179a7ae5fc25ed873223e99f", "borderColor" => "97da935a74593c55d78be9d1295aa994", "borderRadius" => 78, "borderWidth" => 47, "className" => "6f66e878c62db60568a3487869695820"]; |
||
139 | $this->assertEquals($res5, $obj->toArray()); |
||
140 | |||
141 | $obj->setColor("70dda5dfb8053dc6d1c492574bce9bfd"); |
||
142 | |||
143 | $res6 = ["backgroundColor" => "930f2a43179a7ae5fc25ed873223e99f", "borderColor" => "97da935a74593c55d78be9d1295aa994", "borderRadius" => 78, "borderWidth" => 47, "className" => "6f66e878c62db60568a3487869695820", "color" => "70dda5dfb8053dc6d1c492574bce9bfd"]; |
||
144 | $this->assertEquals($res6, $obj->toArray()); |
||
145 | |||
146 | $obj->setConnectorColor("8bf77ed7251dc34fbae6786923398a9d"); |
||
147 | |||
148 | $res7 = ["backgroundColor" => "930f2a43179a7ae5fc25ed873223e99f", "borderColor" => "97da935a74593c55d78be9d1295aa994", "borderRadius" => 78, "borderWidth" => 47, "className" => "6f66e878c62db60568a3487869695820", "color" => "70dda5dfb8053dc6d1c492574bce9bfd", "connectorColor" => "8bf77ed7251dc34fbae6786923398a9d"]; |
||
149 | $this->assertEquals($res7, $obj->toArray()); |
||
150 | |||
151 | $obj->setConnectorPadding(23); |
||
152 | |||
153 | $res8 = ["backgroundColor" => "930f2a43179a7ae5fc25ed873223e99f", "borderColor" => "97da935a74593c55d78be9d1295aa994", "borderRadius" => 78, "borderWidth" => 47, "className" => "6f66e878c62db60568a3487869695820", "color" => "70dda5dfb8053dc6d1c492574bce9bfd", "connectorColor" => "8bf77ed7251dc34fbae6786923398a9d", "connectorPadding" => 23]; |
||
154 | $this->assertEquals($res8, $obj->toArray()); |
||
155 | |||
156 | $obj->setConnectorWidth(8); |
||
157 | |||
158 | $res9 = ["backgroundColor" => "930f2a43179a7ae5fc25ed873223e99f", "borderColor" => "97da935a74593c55d78be9d1295aa994", "borderRadius" => 78, "borderWidth" => 47, "className" => "6f66e878c62db60568a3487869695820", "color" => "70dda5dfb8053dc6d1c492574bce9bfd", "connectorColor" => "8bf77ed7251dc34fbae6786923398a9d", "connectorPadding" => 23, "connectorWidth" => 8]; |
||
159 | $this->assertEquals($res9, $obj->toArray()); |
||
160 | |||
161 | $obj->setCrop(0); |
||
162 | |||
163 | $res10 = ["backgroundColor" => "930f2a43179a7ae5fc25ed873223e99f", "borderColor" => "97da935a74593c55d78be9d1295aa994", "borderRadius" => 78, "borderWidth" => 47, "className" => "6f66e878c62db60568a3487869695820", "color" => "70dda5dfb8053dc6d1c492574bce9bfd", "connectorColor" => "8bf77ed7251dc34fbae6786923398a9d", "connectorPadding" => 23, "connectorWidth" => 8, "crop" => 0]; |
||
164 | $this->assertEquals($res10, $obj->toArray()); |
||
165 | |||
166 | $obj->setDefer(0); |
||
167 | |||
168 | $res11 = ["backgroundColor" => "930f2a43179a7ae5fc25ed873223e99f", "borderColor" => "97da935a74593c55d78be9d1295aa994", "borderRadius" => 78, "borderWidth" => 47, "className" => "6f66e878c62db60568a3487869695820", "color" => "70dda5dfb8053dc6d1c492574bce9bfd", "connectorColor" => "8bf77ed7251dc34fbae6786923398a9d", "connectorPadding" => 23, "connectorWidth" => 8, "crop" => 0, "defer" => 0]; |
||
169 | $this->assertEquals($res11, $obj->toArray()); |
||
170 | |||
171 | $obj->setDistance(21); |
||
172 | |||
173 | $res12 = ["backgroundColor" => "930f2a43179a7ae5fc25ed873223e99f", "borderColor" => "97da935a74593c55d78be9d1295aa994", "borderRadius" => 78, "borderWidth" => 47, "className" => "6f66e878c62db60568a3487869695820", "color" => "70dda5dfb8053dc6d1c492574bce9bfd", "connectorColor" => "8bf77ed7251dc34fbae6786923398a9d", "connectorPadding" => 23, "connectorWidth" => 8, "crop" => 0, "defer" => 0, "distance" => 21]; |
||
174 | $this->assertEquals($res12, $obj->toArray()); |
||
175 | |||
176 | $obj->setEnabled(0); |
||
177 | |||
178 | $res13 = ["backgroundColor" => "930f2a43179a7ae5fc25ed873223e99f", "borderColor" => "97da935a74593c55d78be9d1295aa994", "borderRadius" => 78, "borderWidth" => 47, "className" => "6f66e878c62db60568a3487869695820", "color" => "70dda5dfb8053dc6d1c492574bce9bfd", "connectorColor" => "8bf77ed7251dc34fbae6786923398a9d", "connectorPadding" => 23, "connectorWidth" => 8, "crop" => 0, "defer" => 0, "distance" => 21, "enabled" => 0]; |
||
179 | $this->assertEquals($res13, $obj->toArray()); |
||
180 | |||
181 | $obj->setFormat("1ddcb92ade31c8fbd370001f9b29a7d9"); |
||
182 | |||
183 | $res14 = ["backgroundColor" => "930f2a43179a7ae5fc25ed873223e99f", "borderColor" => "97da935a74593c55d78be9d1295aa994", "borderRadius" => 78, "borderWidth" => 47, "className" => "6f66e878c62db60568a3487869695820", "color" => "70dda5dfb8053dc6d1c492574bce9bfd", "connectorColor" => "8bf77ed7251dc34fbae6786923398a9d", "connectorPadding" => 23, "connectorWidth" => 8, "crop" => 0, "defer" => 0, "distance" => 21, "enabled" => 0, "format" => "1ddcb92ade31c8fbd370001f9b29a7d9"]; |
||
184 | $this->assertEquals($res14, $obj->toArray()); |
||
185 | |||
186 | $obj->setFormatter("f2ffc59487832cbad265a8fef2133592"); |
||
187 | |||
188 | $res15 = ["backgroundColor" => "930f2a43179a7ae5fc25ed873223e99f", "borderColor" => "97da935a74593c55d78be9d1295aa994", "borderRadius" => 78, "borderWidth" => 47, "className" => "6f66e878c62db60568a3487869695820", "color" => "70dda5dfb8053dc6d1c492574bce9bfd", "connectorColor" => "8bf77ed7251dc34fbae6786923398a9d", "connectorPadding" => 23, "connectorWidth" => 8, "crop" => 0, "defer" => 0, "distance" => 21, "enabled" => 0, "format" => "1ddcb92ade31c8fbd370001f9b29a7d9", "formatter" => "f2ffc59487832cbad265a8fef2133592"]; |
||
189 | $this->assertEquals($res15, $obj->toArray()); |
||
190 | |||
191 | $obj->setInside(1); |
||
192 | |||
193 | $res16 = ["backgroundColor" => "930f2a43179a7ae5fc25ed873223e99f", "borderColor" => "97da935a74593c55d78be9d1295aa994", "borderRadius" => 78, "borderWidth" => 47, "className" => "6f66e878c62db60568a3487869695820", "color" => "70dda5dfb8053dc6d1c492574bce9bfd", "connectorColor" => "8bf77ed7251dc34fbae6786923398a9d", "connectorPadding" => 23, "connectorWidth" => 8, "crop" => 0, "defer" => 0, "distance" => 21, "enabled" => 0, "format" => "1ddcb92ade31c8fbd370001f9b29a7d9", "formatter" => "f2ffc59487832cbad265a8fef2133592", "inside" => 1]; |
||
194 | $this->assertEquals($res16, $obj->toArray()); |
||
195 | |||
196 | $obj->setOverflow("none"); |
||
197 | |||
198 | $res17 = ["backgroundColor" => "930f2a43179a7ae5fc25ed873223e99f", "borderColor" => "97da935a74593c55d78be9d1295aa994", "borderRadius" => 78, "borderWidth" => 47, "className" => "6f66e878c62db60568a3487869695820", "color" => "70dda5dfb8053dc6d1c492574bce9bfd", "connectorColor" => "8bf77ed7251dc34fbae6786923398a9d", "connectorPadding" => 23, "connectorWidth" => 8, "crop" => 0, "defer" => 0, "distance" => 21, "enabled" => 0, "format" => "1ddcb92ade31c8fbd370001f9b29a7d9", "formatter" => "f2ffc59487832cbad265a8fef2133592", "inside" => 1, "overflow" => "none"]; |
||
199 | $this->assertEquals($res17, $obj->toArray()); |
||
200 | |||
201 | $obj->setPadding(3); |
||
202 | |||
203 | $res18 = ["backgroundColor" => "930f2a43179a7ae5fc25ed873223e99f", "borderColor" => "97da935a74593c55d78be9d1295aa994", "borderRadius" => 78, "borderWidth" => 47, "className" => "6f66e878c62db60568a3487869695820", "color" => "70dda5dfb8053dc6d1c492574bce9bfd", "connectorColor" => "8bf77ed7251dc34fbae6786923398a9d", "connectorPadding" => 23, "connectorWidth" => 8, "crop" => 0, "defer" => 0, "distance" => 21, "enabled" => 0, "format" => "1ddcb92ade31c8fbd370001f9b29a7d9", "formatter" => "f2ffc59487832cbad265a8fef2133592", "inside" => 1, "overflow" => "none", "padding" => 3]; |
||
204 | $this->assertEquals($res18, $obj->toArray()); |
||
205 | |||
206 | $obj->setRotation(87); |
||
207 | |||
208 | $res19 = ["backgroundColor" => "930f2a43179a7ae5fc25ed873223e99f", "borderColor" => "97da935a74593c55d78be9d1295aa994", "borderRadius" => 78, "borderWidth" => 47, "className" => "6f66e878c62db60568a3487869695820", "color" => "70dda5dfb8053dc6d1c492574bce9bfd", "connectorColor" => "8bf77ed7251dc34fbae6786923398a9d", "connectorPadding" => 23, "connectorWidth" => 8, "crop" => 0, "defer" => 0, "distance" => 21, "enabled" => 0, "format" => "1ddcb92ade31c8fbd370001f9b29a7d9", "formatter" => "f2ffc59487832cbad265a8fef2133592", "inside" => 1, "overflow" => "none", "padding" => 3, "rotation" => 87]; |
||
209 | $this->assertEquals($res19, $obj->toArray()); |
||
210 | |||
211 | $obj->setShadow(1); |
||
212 | |||
213 | $res20 = ["backgroundColor" => "930f2a43179a7ae5fc25ed873223e99f", "borderColor" => "97da935a74593c55d78be9d1295aa994", "borderRadius" => 78, "borderWidth" => 47, "className" => "6f66e878c62db60568a3487869695820", "color" => "70dda5dfb8053dc6d1c492574bce9bfd", "connectorColor" => "8bf77ed7251dc34fbae6786923398a9d", "connectorPadding" => 23, "connectorWidth" => 8, "crop" => 0, "defer" => 0, "distance" => 21, "enabled" => 0, "format" => "1ddcb92ade31c8fbd370001f9b29a7d9", "formatter" => "f2ffc59487832cbad265a8fef2133592", "inside" => 1, "overflow" => "none", "padding" => 3, "rotation" => 87, "shadow" => 1]; |
||
214 | $this->assertEquals($res20, $obj->toArray()); |
||
215 | |||
216 | $obj->setShape("8c73a98a300905900337f535531dfca6"); |
||
217 | |||
218 | $res21 = ["backgroundColor" => "930f2a43179a7ae5fc25ed873223e99f", "borderColor" => "97da935a74593c55d78be9d1295aa994", "borderRadius" => 78, "borderWidth" => 47, "className" => "6f66e878c62db60568a3487869695820", "color" => "70dda5dfb8053dc6d1c492574bce9bfd", "connectorColor" => "8bf77ed7251dc34fbae6786923398a9d", "connectorPadding" => 23, "connectorWidth" => 8, "crop" => 0, "defer" => 0, "distance" => 21, "enabled" => 0, "format" => "1ddcb92ade31c8fbd370001f9b29a7d9", "formatter" => "f2ffc59487832cbad265a8fef2133592", "inside" => 1, "overflow" => "none", "padding" => 3, "rotation" => 87, "shadow" => 1, "shape" => "8c73a98a300905900337f535531dfca6"]; |
||
219 | $this->assertEquals($res21, $obj->toArray()); |
||
220 | |||
221 | $obj->setSoftConnector(1); |
||
222 | |||
223 | $res22 = ["backgroundColor" => "930f2a43179a7ae5fc25ed873223e99f", "borderColor" => "97da935a74593c55d78be9d1295aa994", "borderRadius" => 78, "borderWidth" => 47, "className" => "6f66e878c62db60568a3487869695820", "color" => "70dda5dfb8053dc6d1c492574bce9bfd", "connectorColor" => "8bf77ed7251dc34fbae6786923398a9d", "connectorPadding" => 23, "connectorWidth" => 8, "crop" => 0, "defer" => 0, "distance" => 21, "enabled" => 0, "format" => "1ddcb92ade31c8fbd370001f9b29a7d9", "formatter" => "f2ffc59487832cbad265a8fef2133592", "inside" => 1, "overflow" => "none", "padding" => 3, "rotation" => 87, "shadow" => 1, "shape" => "8c73a98a300905900337f535531dfca6", "softConnector" => 1]; |
||
224 | $this->assertEquals($res22, $obj->toArray()); |
||
225 | |||
226 | $obj->setStyle(["style" => "a1b01e734b573fca08eb1a65e6df9a38"]); |
||
227 | |||
228 | $res23 = ["backgroundColor" => "930f2a43179a7ae5fc25ed873223e99f", "borderColor" => "97da935a74593c55d78be9d1295aa994", "borderRadius" => 78, "borderWidth" => 47, "className" => "6f66e878c62db60568a3487869695820", "color" => "70dda5dfb8053dc6d1c492574bce9bfd", "connectorColor" => "8bf77ed7251dc34fbae6786923398a9d", "connectorPadding" => 23, "connectorWidth" => 8, "crop" => 0, "defer" => 0, "distance" => 21, "enabled" => 0, "format" => "1ddcb92ade31c8fbd370001f9b29a7d9", "formatter" => "f2ffc59487832cbad265a8fef2133592", "inside" => 1, "overflow" => "none", "padding" => 3, "rotation" => 87, "shadow" => 1, "shape" => "8c73a98a300905900337f535531dfca6", "softConnector" => 1, "style" => ["style" => "a1b01e734b573fca08eb1a65e6df9a38"]]; |
||
229 | $this->assertEquals($res23, $obj->toArray()); |
||
230 | |||
231 | $obj->setUseHTML(1); |
||
232 | |||
233 | $res24 = ["backgroundColor" => "930f2a43179a7ae5fc25ed873223e99f", "borderColor" => "97da935a74593c55d78be9d1295aa994", "borderRadius" => 78, "borderWidth" => 47, "className" => "6f66e878c62db60568a3487869695820", "color" => "70dda5dfb8053dc6d1c492574bce9bfd", "connectorColor" => "8bf77ed7251dc34fbae6786923398a9d", "connectorPadding" => 23, "connectorWidth" => 8, "crop" => 0, "defer" => 0, "distance" => 21, "enabled" => 0, "format" => "1ddcb92ade31c8fbd370001f9b29a7d9", "formatter" => "f2ffc59487832cbad265a8fef2133592", "inside" => 1, "overflow" => "none", "padding" => 3, "rotation" => 87, "shadow" => 1, "shape" => "8c73a98a300905900337f535531dfca6", "softConnector" => 1, "style" => ["style" => "a1b01e734b573fca08eb1a65e6df9a38"], "useHTML" => 1]; |
||
234 | $this->assertEquals($res24, $obj->toArray()); |
||
235 | |||
236 | $obj->setVerticalAlign("bottom"); |
||
237 | |||
238 | $res25 = ["backgroundColor" => "930f2a43179a7ae5fc25ed873223e99f", "borderColor" => "97da935a74593c55d78be9d1295aa994", "borderRadius" => 78, "borderWidth" => 47, "className" => "6f66e878c62db60568a3487869695820", "color" => "70dda5dfb8053dc6d1c492574bce9bfd", "connectorColor" => "8bf77ed7251dc34fbae6786923398a9d", "connectorPadding" => 23, "connectorWidth" => 8, "crop" => 0, "defer" => 0, "distance" => 21, "enabled" => 0, "format" => "1ddcb92ade31c8fbd370001f9b29a7d9", "formatter" => "f2ffc59487832cbad265a8fef2133592", "inside" => 1, "overflow" => "none", "padding" => 3, "rotation" => 87, "shadow" => 1, "shape" => "8c73a98a300905900337f535531dfca6", "softConnector" => 1, "style" => ["style" => "a1b01e734b573fca08eb1a65e6df9a38"], "useHTML" => 1, "verticalAlign" => "bottom"]; |
||
239 | $this->assertEquals($res25, $obj->toArray()); |
||
240 | |||
241 | $obj->setX(45); |
||
242 | |||
243 | $res26 = ["backgroundColor" => "930f2a43179a7ae5fc25ed873223e99f", "borderColor" => "97da935a74593c55d78be9d1295aa994", "borderRadius" => 78, "borderWidth" => 47, "className" => "6f66e878c62db60568a3487869695820", "color" => "70dda5dfb8053dc6d1c492574bce9bfd", "connectorColor" => "8bf77ed7251dc34fbae6786923398a9d", "connectorPadding" => 23, "connectorWidth" => 8, "crop" => 0, "defer" => 0, "distance" => 21, "enabled" => 0, "format" => "1ddcb92ade31c8fbd370001f9b29a7d9", "formatter" => "f2ffc59487832cbad265a8fef2133592", "inside" => 1, "overflow" => "none", "padding" => 3, "rotation" => 87, "shadow" => 1, "shape" => "8c73a98a300905900337f535531dfca6", "softConnector" => 1, "style" => ["style" => "a1b01e734b573fca08eb1a65e6df9a38"], "useHTML" => 1, "verticalAlign" => "bottom", "x" => 45]; |
||
244 | $this->assertEquals($res26, $obj->toArray()); |
||
245 | |||
246 | $obj->setY(5); |
||
247 | |||
248 | $res27 = ["backgroundColor" => "930f2a43179a7ae5fc25ed873223e99f", "borderColor" => "97da935a74593c55d78be9d1295aa994", "borderRadius" => 78, "borderWidth" => 47, "className" => "6f66e878c62db60568a3487869695820", "color" => "70dda5dfb8053dc6d1c492574bce9bfd", "connectorColor" => "8bf77ed7251dc34fbae6786923398a9d", "connectorPadding" => 23, "connectorWidth" => 8, "crop" => 0, "defer" => 0, "distance" => 21, "enabled" => 0, "format" => "1ddcb92ade31c8fbd370001f9b29a7d9", "formatter" => "f2ffc59487832cbad265a8fef2133592", "inside" => 1, "overflow" => "none", "padding" => 3, "rotation" => 87, "shadow" => 1, "shape" => "8c73a98a300905900337f535531dfca6", "softConnector" => 1, "style" => ["style" => "a1b01e734b573fca08eb1a65e6df9a38"], "useHTML" => 1, "verticalAlign" => "bottom", "x" => 45, "y" => 5]; |
||
249 | $this->assertEquals($res27, $obj->toArray()); |
||
250 | |||
251 | $obj->setZIndex(33); |
||
252 | |||
253 | $res28 = ["backgroundColor" => "930f2a43179a7ae5fc25ed873223e99f", "borderColor" => "97da935a74593c55d78be9d1295aa994", "borderRadius" => 78, "borderWidth" => 47, "className" => "6f66e878c62db60568a3487869695820", "color" => "70dda5dfb8053dc6d1c492574bce9bfd", "connectorColor" => "8bf77ed7251dc34fbae6786923398a9d", "connectorPadding" => 23, "connectorWidth" => 8, "crop" => 0, "defer" => 0, "distance" => 21, "enabled" => 0, "format" => "1ddcb92ade31c8fbd370001f9b29a7d9", "formatter" => "f2ffc59487832cbad265a8fef2133592", "inside" => 1, "overflow" => "none", "padding" => 3, "rotation" => 87, "shadow" => 1, "shape" => "8c73a98a300905900337f535531dfca6", "softConnector" => 1, "style" => ["style" => "a1b01e734b573fca08eb1a65e6df9a38"], "useHTML" => 1, "verticalAlign" => "bottom", "x" => 45, "y" => 5, "zIndex" => 33]; |
||
254 | $this->assertEquals($res28, $obj->toArray()); |
||
255 | } |
||
258 |