WBW\Bundle\CoreBundle\Security\Core\User\UserHelper::hasRoles()

Complexity

Conditions	6
Paths	7

Size

Total Lines	25
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public static function hasRoles($user, $roles, bool $or = true): bool {

        if (false === ($user instanceof UserInterface)) {
            return false;
        }

        if (false === is_array($roles)) {
            $roles = [$roles];
        }

        $result = 1 <= count($roles);

It seems like $roles can also be of type string; however, parameter $value of count() does only seem to accept Countable|array, maybe add an additional type check?

        foreach ($roles as $role) {

            $buffer = in_array($role, $user->getRoles());

            if (true === $buffer && true === $or) {
                $result = $buffer;
                break;
            }

            $result &= $buffer;
        }

        return $result;

The expression return $result could return the type integer which is incompatible with the type-hinted return boolean. Consider adding an additional type-check to rule them out.

    }