WBW\Bundle\CoreBundle\Renderer\FormRenderer::renderOption()

Complexity

Conditions	7
Paths	8

Size

Total Lines	29
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public static function renderOption($option, TranslatorInterface $translator = null): string {

        if (null === $option) {
            return null !== $translator ? $translator->trans("label.empty_selection") : "Empty selection";
        }

        if (true === ($option instanceof TranslatedChoiceLabelInterface)) {
            $output = $option->getTranslatedChoiceLabel($translator);
        } else if (true === ($option instanceof ChoiceLabelInterface)) {
            $output = $option->getChoiceLabel();
        } else {
            $output = "This option must implements [Translated]ChoiceLabelInterface";
        }

        if (true === ($option instanceof AlphabeticalTreeNodeInterface)) {

            $level  = AlphabeticalTreeNodeHelper::getLevel($option);
            $nbsp   = html_entity_decode("&nbsp;");
            $symbol = html_entity_decode(0 === $level ? "&#9472;" : "&#9492;");

            $output = implode("", [
                str_repeat($nbsp, $level * 3),
                $symbol,
                $nbsp,
                $output,
            ]);
        }

        return $output;

The expression return $output could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }