Issues in AbstractUtilityTwigExtension.php - Fixed Issues - Inspection of "Add PHP extensions into Composer" - webeweb/bootstrap-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5072ee...8ba455 )

by WEBEWEB

created 2019-07-22 12:23 UTC

Extension/Utility/AbstractUtilityTwigExtension.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * This file is part of the bootstrap-bundle package.
 *
 * (c) 2018 WEBEWEB
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace WBW\Bundle\BootstrapBundle\Twig\Extension\Utility;

use Symfony\Component\Translation\TranslatorInterface;
use Twig\Environment;
use WBW\Bundle\BootstrapBundle\Twig\Extension\AbstractTwigExtension;
use WBW\Bundle\CoreBundle\Service\TranslatorTrait;

/**
 * Abstract utility Twig extension.
 *
 * @author webeweb <https://github.com/webeweb/>
 * @package WBW\Bundle\BootstrapBundle\Twig\Extension\Utility
 * @abstract
 */
abstract class AbstractUtilityTwigExtension extends AbstractTwigExtension {

    use TranslatorTrait;

    /**
     * Constructor.
     *
     * @param Environment $twigEnvironment The Twig environment.
     * @param TranslatorInterface $translator The translator.
     */
    public function __construct(Environment $twigEnvironment, TranslatorInterface $translator) {
        parent::__construct($twigEnvironment);
        $this->setTranslator($translator);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2
3			/*
4			* This file is part of the bootstrap-bundle package.
5			*
6			* (c) 2018 WEBEWEB
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace WBW\Bundle\BootstrapBundle\Twig\Extension\Utility;
13
14			use Symfony\Component\Translation\TranslatorInterface;
15			use Twig\Environment;
16			use WBW\Bundle\BootstrapBundle\Twig\Extension\AbstractTwigExtension;
17			use WBW\Bundle\CoreBundle\Service\TranslatorTrait;
18
19			/**
20			* Abstract utility Twig extension.
21			*
22			* @author webeweb <https://github.com/webeweb/>
23			* @package WBW\Bundle\BootstrapBundle\Twig\Extension\Utility
24			* @abstract
25			*/
26			abstract class AbstractUtilityTwigExtension extends AbstractTwigExtension {
27
28			use TranslatorTrait;
29
30			/**
31			* Constructor.
32			*
33			* @param Environment $twigEnvironment The Twig environment.
34			* @param TranslatorInterface $translator The translator.
35			*/
36			public function __construct(Environment $twigEnvironment, TranslatorInterface $translator) {
37			parent::__construct($twigEnvironment);
38			$this->setTranslator($translator);
			0 ignored issues – show Documentation introduced 2019-07-05 16:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$translator` is of type `object<Symfony\Component...on\TranslatorInterface>`, but the function expects a `null\|object<WBW\Bundle\C...aseTranslatorInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
39			}
40			}
41

webeweb / bootstrap-bundle

Push — master ( 5072ee...8ba455 )

Extension/Utility/AbstractUtilityTwigExtension.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like