WBW\Bundle\BootstrapBundle\Helper\UserHelper::hasRoles()

Complexity

Conditions	7
Paths	7

Size

Total Lines

26

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function hasRoles($user, $roles, $or = true) {

        // Check the user.
        if (null === $user || false === ($user instanceof UserInterface)) {
            return false;
        }

        // Check the roles.
        if (false === is_array($roles)) {
            $roles = [$roles];
        }

        // Initialize the result.
        $result = 1 <= count($roles);

        // Handle each role.
        foreach ($roles as $role) {
            $result &= in_array($role, $user->getRoles());
            if (true == $result && true === $or) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

                break;
            }
        }

        // Return the result.
        return boolval($result);
    }