Webcreate\Conveyor\Console\Application

Complexity

Total Complexity

23

Size/Duplication

Total Lines	182
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	15

Test Coverage

Coverage

32.17%

Importance

Changes	1
Bugs	0	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	getConveyor()	0	4	1
A	getName()	0	4	1
A	setAutoExit()	0	7	1
A	__construct()	0	10	3
A	getDefaultCommands()	0	19	2
A	getDefaultInputDefinition()	0	9	1
A	getVersion()	0	12	2
C	run()	0	53	10
A	doRun()	0	16	2

<?php

/*
 * This file is part of the Conveyor package.
 *
 * (c) Jeroen Fiege <jeroen@webcreate.nl>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Webcreate\Conveyor\Console;

use Symfony\Component\Console\Application as BaseApplication;
use Symfony\Component\Console\Input\ArgvInput;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\ConsoleOutput;
use Symfony\Component\Console\Output\ConsoleOutputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Webcreate\Conveyor\Conveyor;
use Webcreate\Conveyor\IO\ConsoleIO;

class Application extends BaseApplication

The class Application has a coupling between objects value of 20. Consider to reduce the number of dependencies under 13.

{
    /**
     * @var Conveyor
     */
    protected $conveyor;

    /**
     * @var bool
     */
    protected $originalAutoExit;

    /**
     * @param Conveyor $conveyor
     */
    public function __construct(Conveyor $conveyor)
    {
        $this->conveyor = $conveyor;

        if (function_exists('date_default_timezone_set') && function_exists('date_default_timezone_get')) {
            date_default_timezone_set(@date_default_timezone_get());
        }

        parent::__construct();
    }

    /**
     * @return Conveyor
     */
    public function getConveyor()
    {
        return $this->conveyor;
    }

    /**
     * @inheritdoc
     */
    protected function getDefaultCommands()
    {
        $commands = parent::getDefaultCommands();
        $commands[] = new \Webcreate\Conveyor\Command\VersionsCommand();
        $commands[] = new \Webcreate\Conveyor\Command\BuildCommand();
        $commands[] = new \Webcreate\Conveyor\Command\SimulateCommand();
        $commands[] = new \Webcreate\Conveyor\Command\DeployCommand();
        $commands[] = new \Webcreate\Conveyor\Command\UndeployCommand();
        $commands[] = new \Webcreate\Conveyor\Command\DiffCommand();
        $commands[] = new \Webcreate\Conveyor\Command\InitCommand();
        $commands[] = new \Webcreate\Conveyor\Command\ValidateCommand();
        $commands[] = new \Webcreate\Conveyor\Command\StatusCommand();

        if ('phar:' === substr(__FILE__, 0, 5)) {
            $commands[] = new \Webcreate\Conveyor\Command\UpdateCommand();
        }

        return $commands;

The expression return $commands; seems to be an array, but some of its elements' types (Webcreate\Conveyor\Command\VersionsCommand|Webcreate\Conveyor\Command\BuildCommand|Webcreate\Conveyor\Command\SimulateCommand|Webcreate\Conveyor\Command\DeployCommand|Webcreate\Conveyor\Command\UndeployCommand|Webcreate\Conveyor\Command\DiffCommand|Webcreate\Conveyor\Command\InitCommand|Webcreate\Conveyor\Command\ValidateCommand|Webcreate\Conveyor\Command\StatusCommand|Webcreate\Conveyor\Command\UpdateCommand) are incompatible with the return type of the parent method Symfony\Component\Console\Application::getDefaultCommands of type array<Symfony\Component\Console\Command\HelpCommand|Symfony\Component\Console\Command\ListCommand>.

    }

    /**
     * @inheritdoc
     */
    protected function getDefaultInputDefinition()
    {
        $inputDefinition = parent::getDefaultInputDefinition();
        $inputDefinition->addOption(
            new InputOption('--configuration', '-c', InputOption::VALUE_REQUIRED, 'Configuration file override')
        );

        return $inputDefinition;
    }

    /**
     * @inheritdoc
     */
    public function getName()
    {
        return 'Conveyor';
    }

    /**
     * @inheritdoc
     */
    public function getVersion()
    {
        $versionFilename = 'VERSION';

        if ('phar:' === substr(__FILE__, 0, 5)) {
            $versionFile = 'phar://conveyor.phar/' . $versionFilename;
        } else {
            $versionFile = __DIR__ . '/../../../../' . $versionFilename;
        }

        return trim(file_get_contents($versionFile));
    }

    /**
     * @inheritdoc
     */
    public function run(InputInterface $input = null, OutputInterface $output = null)

This operation has 252 execution paths which exceeds the configured maximum of 200.

    {
        $this->setCatchExceptions(false);

        if (null === $input) {
            $input = new ArgvInput();

Consider using a different name than the parameter $input. This often makes code more readable.

        }

        if (null === $output) {
            $output = new ConsoleOutput();

Consider using a different name than the parameter $output. This often makes code more readable.

        }

        try {
            $statusCode = parent::run($input, $output);
        } catch (\Exception $e) {
            $container = $this->getConveyor()->getContainer();

            if (null !== $container) {
                /** @var $logger \Monolog\Logger */
                $logger = $this->getConveyor()->getContainer()->get('logger');

                $message = sprintf(
                    '%s: %s (uncaught exception) at %s line %s while running console command `%s`',
                    get_class($e),
                    $e->getMessage(),
                    $e->getFile(),
                    $e->getLine(),
                    $this->getCommandName($input)
                );
                $logger->addCritical($message);
            }

            if ($output instanceof ConsoleOutputInterface) {
                $this->renderException($e, $output->getErrorOutput());
            } else {
                $this->renderException($e, $output);
            }
            $statusCode = $e->getCode();

            $statusCode = is_numeric($statusCode) && $statusCode ? $statusCode : 1;
        }

        if ($this->originalAutoExit) {
            if ($statusCode > 255) {
                $statusCode = 255;
            }
            // @codeCoverageIgnoreStart
            exit($statusCode);

The method run() contains an exit expression.

            // @codeCoverageIgnoreEnd
        }

        return $statusCode;
    }

    /**
     * @inheritdoc
     */
    public function doRun(InputInterface $input, OutputInterface $output)
    {
        $io = new ConsoleIO($input, $output, $this->getHelperSet());

Avoid variables with short names like $io. Configured minimum length is 3.

        $conveyor = $this->getConveyor();

        // retrieve the config file option really early so we can still make changes before the di container
        // gets compiled
        $configFile = $input->getParameterOption(array('--configuration', '-c'));
        if ($configFile) {
            $conveyor->setConfigFile($configFile);
        }

        $conveyor->boot($io);

        parent::doRun($input, $output);
    }

    /**
     * @inheritdoc
     */
    public function setAutoExit($bool)
    {
        // parent property is private, so we need to intercept it in a setter
        $this->originalAutoExit = (bool) $bool;

        parent::setAutoExit($bool);
    }
}