Webcreate\Conveyor\Task\ShellTask

Complexity

Total Complexity

16

Size/Duplication

Total Lines	94
Duplicated Lines	19.15 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

51.06%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	getDerivedFiles()	0	8	2
A	getRemovedFiles()	0	8	2
D	execute()	18	45	9
A	simulate()	0	7	2

<?php

/*
 * This file is part of the Conveyor package.
 *
 * (c) Jeroen Fiege <jeroen@webcreate.nl>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Webcreate\Conveyor\Task;

use Symfony\Component\Process\Exception\ProcessFailedException;
use Symfony\Component\Process\Process;

use Webcreate\Conveyor\Task\Result\ExecuteResult;
use Webcreate\Util\Cli;
use Webcreate\Conveyor\IO\IOInterface;
use Webcreate\Conveyor\Repository\Version;

class ShellTask extends Task
{
    protected $cwd;
    protected $cli;
    protected $io;

Avoid variables with short names like $io. Configured minimum length is 3.

    protected $commandline;

    public function __construct($cwd, Cli $cli, IOInterface $io = null)

Avoid variables with short names like $io. Configured minimum length is 3.

    {
        $this->cli = $cli;
        $this->io  = $io;
        $this->cwd = $cwd;
    }

    /**
     * @todo improve output (also @see SshTask)
     *
     * @param $target
     * @param  Version                                                     $version
     * @return ExecuteResult
     * @throws \Symfony\Component\Process\Exception\ProcessFailedException
     */
    public function execute($target, Version $version = null)
    {
        $this->commandline = $this->options['command'];
        foreach ($this->commandline as $command) {
            $this->output(sprintf('Executing: <comment>%s</comment>', $command));

            $hasOutput = false;

            $self = $this;
            $outputter = function ($type, $buffer) use ($self, &$hasOutput) {

This code seems to be duplicated across your project.

                if (false === $self->io->isVerbose()) return;

Please always use braces to surround the code block of IF statements.

It is generally a best practice to always use braces with control structures.

                if (1 || 'out' === $type) {
                    if (!$hasOutput) {
                        $this->io->write('');
                        $this->io->write('');
                        $hasOutput = true;
                    }

                    $lines = explode("\n", $buffer);
                    foreach ($lines as $line) {
                        if ($output = trim($line, "\r\n")) {
                            $self->io->write(sprintf('> %s', $output));
                        }
                    }
                }
            };

            if ($this->cli->execute($command, $outputter, $this->cwd) <> 0) {

$outputter is of type object<Closure>, but the function expects a object<Webcreate\Util\Closure>|string|array|null.

It seems like you are loosely comparing $this->cli->execute($command, $outputter, $this->cwd) of type integer|null to 0; this is ambiguous as not only 0 == 0 is true, but null == 0 is true, too. Consider using a strict comparison ===.

                throw new ProcessFailedException($this->cli->getProcess());
            }
//            elseif ($message = $this->cli->getErrorOutput()) {
//                $messages = explode("\n", $message);
//
//                $self->io->write(sprintf('<comment>%s</comment>', $messages));
//            }
        }

        return new ExecuteResult(
            $this->getDerivedFiles(),
            $this->getRemovedFiles()
        );

//        return $this->cli->getOutput();
    }

    public function simulate($target, Version $version)
    {
        $this->commandline = $this->options['command'];
        foreach ($this->commandline as $command) {
            $this->output(sprintf('Executing: <comment>%s</comment>', $command));
        }
    }

    protected function getDerivedFiles()
    {
        if (isset($this->options['creates'])) {
            return (array) $this->options['creates'];
        }

        return array();
    }

    protected function getRemovedFiles()
    {
        if (isset($this->options['removes'])) {
            return (array) $this->options['removes'];
        }

        return array();
    }
}