Webcreate\Conveyor\Config\Definition\TaskNode

Complexity

Total Complexity

9

Size/Duplication

Total Lines	89
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

75%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	6	6	1
A	setTaskFactory()	4	4	1
B	prepareChildren()	32	32	5
A	validateType()	12	12	2

<?php

/*
 * This file is part of the Conveyor package.
 *
 * (c) Jeroen Fiege <jeroen@webcreate.nl>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Webcreate\Conveyor\Config\Definition;

use Symfony\Component\Config\Definition\ArrayNode;
use Symfony\Component\Config\Definition\ConfigurationInterface;
use Symfony\Component\Config\Definition\Exception\InvalidConfigurationException;
use Symfony\Component\Config\Definition\NodeInterface;
use Webcreate\Conveyor\Factory\TaskFactory;

class TaskNode extends ArrayNode

This class seems to be duplicated in your project.

{
    protected $prepared = false;
    protected $originalChildren = array();

    /**
     * Constructor.
     *
     * @param string        $name
     * @param NodeInterface $parent
     */
    public function __construct($name, NodeInterface $parent = null)
    {
        parent::__construct($name, $parent);

        //$this->setIgnoreExtraKeys(true);
    }

    /**
     * Set task factory
     *
     * @param TaskFactory|null $factory
     */
    public function setTaskFactory($factory)
    {
        $this->taskFactory = $factory;

The property taskFactory does not exist. Did you maybe forget to declare it?

    }

    /**
     * Takes child nodes from a ConfigurtionInterface instance
     * and adds these to this node
     *
     * @param  string                        $type
     * @throws InvalidConfigurationException
     */
    protected function prepareChildren($type)
    {
        // when we hit this function for the first time,
        // we store the original children. Each time we
        // hit this function we reset the children to the
        // original ones.
        if (false === $this->prepared) {
            $this->originalChildren = $this->children;
            $this->prepared = true;
        }

        $tasks = $this->taskFactory->getTasks();

        $this->children = $this->originalChildren;

        if (isset($tasks[$type])) {
            $configuration = $this->taskFactory->configuration($type);

            if ($configuration instanceof ConfigurationInterface) {
                $tree = $configuration->getConfigTreeBuilder()->buildTree();
                foreach ($tree->getChildren() as $child) {
                    $this->addChild($child);
                }
            }
        } else {
            throw new InvalidConfigurationException(sprintf(
                    'Task type "%s" does not exist at path "%s". Did you mean any of %s?', $type,
                    $this->getPath(),
                    implode(', ', array_keys($tasks))
            ));
        }
    }

    /**
     * We hook into the validateType method, this
     * gets called form the normalize method.
     *
     * @param mixed $value
     *
     * @throws InvalidTypeException
     */
    protected function validateType($value)
    {
        if (isset($value['type'])) {
            $this->prepareChildren($value['type']);
        } else {
            // ignore extra keys so the error message will be
            // focused on the missing type field
            $this->setIgnoreExtraKeys(true);
        }

        parent::validateType($value);
    }
}