Webcreate\Conveyor\Config\Definition\Builder\StrategyNodeDefinition

Complexity

Total Complexity

11

Size/Duplication

Total Lines	101
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	6

Test Coverage

Coverage

93.75%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getNodeBuilder()	0	8	2
B	createNode()	0	24	4
A	children()	0	4	1
A	append()	0	6	1
A	setBuilder()	0	4	1
A	setStrategyFactory()	0	6	1

<?php

/*
 * This file is part of the Conveyor package.
 *
 * (c) Jeroen Fiege <jeroen@webcreate.nl>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Webcreate\Conveyor\Config\Definition\Builder;

use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
use Symfony\Component\Config\Definition\Builder\NodeBuilder;
use Symfony\Component\Config\Definition\Builder\NodeDefinition;
use Symfony\Component\Config\Definition\Builder\NodeParentInterface;
use Symfony\Component\Config\Definition\Builder\ParentNodeDefinitionInterface;
use Webcreate\Conveyor\Config\Definition\StrategyNode;
use Webcreate\Conveyor\Factory\StrategyFactory;

/**
 * This class provides a fluent interface for defining an transporter node.
 *
 * @author Jeroen Fiege
 */
class StrategyNodeDefinition extends ArrayNodeDefinition implements
        ParentNodeDefinitionInterface

Expected 4 spaces before interface name; 8 found

{
    protected $nodeBuilder;
    protected $children;

    /**
     * @var StrategyFactory
     */
    protected $strategyFactory;

    public function __construct($name, NodeParentInterface $parent = null)
    {
        parent::__construct($name, $parent);
    }

    /**
     * Returns a node builder to be used to add children and prototype
     *
     * @return NodeBuilder The node builder
     */
    protected function getNodeBuilder()
    {
        if (null === $this->nodeBuilder) {
            $this->nodeBuilder = new NodeBuilder();
        }

        return $this->nodeBuilder->setParent($this);
    }

    /**
     * (non-PHPdoc)
     * @see Symfony\Component\Config\Definition\Builder.NodeDefinition::createNode()
     */
    protected function createNode()
    {
        $node = new StrategyNode($this->name, $this->parent);

It seems like $this->parent can also be of type object<Symfony\Component\Config\Definition\Builder\NodeParentInterface>; however, Webcreate\Conveyor\Config\Definition\StrategyNode::__construct() does only seem to accept null|object<Symfony\Component\Config\Definition\NodeInterface>, maybe add an additional type check?

        $node->setStrategyFactory($this->strategyFactory);

        $node->setAddIfNotSet($this->addDefaults);
        $node->setRequired($this->required);

        foreach ($this->children as $child) {
            $child->parent = $node;

It seems like $node of type object<Webcreate\Conveyor\Config\Definition\StrategyNode> is incompatible with the declared type object<Symfony\Component\Config\Definition\Builder\NodeParentInterface>|null of property $parent.

            $node->addChild($child->getNode());
        }

        if (null !== $this->normalization) {
            $node->setNormalizationClosures($this->normalization->before);
            $node->setXmlRemappings($this->normalization->remappings);
        }

        if (null !== $this->validation) {
            $node->setFinalValidationClosures($this->validation->rules);
        }

        return $node;
    }

    /**
     * (non-PHPdoc)
     * @see Symfony\Component\Config\Definition\Builder.ParentNodeDefinitionInterface::children()
     */
    public function children()
    {
        return $this->getNodeBuilder();
    }

    /**
     * (non-PHPdoc)
     * @see Symfony\Component\Config\Definition\Builder.ParentNodeDefinitionInterface::append()
     */
    public function append(NodeDefinition $node)
    {
        $this->children[$node->name] = $node->setParent($this);

        return $this;
    }

    /**
     * (non-PHPdoc)
     * @see Symfony\Component\Config\Definition\Builder.ParentNodeDefinitionInterface::setBuilder()
     */
    public function setBuilder(NodeBuilder $builder)
    {
        $this->nodeBuilder = $builder;
    }

    /**
     * Set StrategyFactory
     *
     * @param  StrategyFactory|null                                                    $factory
     * @return StrategyNodeDefinition
     */
    public function setStrategyFactory($factory)
    {
        $this->strategyFactory = $factory;

        return $this;
    }
}