LoggerFactory::get() - Code Metrics - webcreate/conveyor - Measure and Improve Code Quality continuously with Scrutinizer

LoggerFactory::get() A
last analyzed 2016-12-08 12:42 UTC

↳ Parent: LoggerFactory

Complexity

Conditions	3
Paths	4

Size

Total Lines	15
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
dl	0
loc	15
ccs	0
cts	12
cp	0
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	8
nc	4
nop	1
crap	12

<?php

/*
 * This file is part of the Conveyor package.
 *
 * (c) Jeroen Fiege <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Webcreate\Conveyor\Factory;

use Monolog\Handler\StreamHandler;
use Monolog\Logger;

class LoggerFactory
{
    /**
     * @param  string $logDir
     * @return Logger
     */
    public static function get($logDir)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (0 === strpos($logDir, '~')) {
            $logDir = $_SERVER['HOME'] . substr($logDir, 1);

        }

        if (false === file_exists($logDir)) {
            mkdir($logDir, 0777, true);
        }

        $logger = new Logger('app');
        $logger->pushHandler(new StreamHandler($logDir . '/app.log', Logger::DEBUG));

        return $logger;
    }
}


1			<?php
2
3			/*
4			* This file is part of the Conveyor package.
5			*
6			* (c) Jeroen Fiege <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Webcreate\Conveyor\Factory;
13
14			use Monolog\Handler\StreamHandler;
15			use Monolog\Logger;
16
17			class LoggerFactory
18			{
19			/**
20			* @param string $logDir
21			* @return Logger
22			*/
23			public static function get($logDir)
			0 ignored issues – show Coding Style introduced 2016-01-14 09:42 UTC by Report Bug Copy Issue Report `get` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
24			{
25			if (0 === strpos($logDir, '~')) {
26			$logDir = $_SERVER['HOME'] . substr($logDir, 1);
			0 ignored issues – show Coding Style introduced 2016-01-14 09:42 UTC by Report Bug Copy Issue Report Consider using a different name than the parameter `$logDir`. This often makes code more readable. Loading history...
27			}
28
29			if (false === file_exists($logDir)) {
30			mkdir($logDir, 0777, true);
31			}
32
33			$logger = new Logger('app');
34			$logger->pushHandler(new StreamHandler($logDir . '/app.log', Logger::DEBUG));
35
36			return $logger;
37			}
38			}
39

webcreate / conveyor

LoggerFactory::get() A last analyzed 2016-12-08 12:42 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

LoggerFactory::get() A
last analyzed 2016-12-08 12:42 UTC