Webcreate\Conveyor\Subscriber\VcsSubscriber

Complexity

Total Complexity

6

Size/Duplication

Total Lines	51
Duplicated Lines	62.75 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

27.27%

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getSubscribedEvents()	0	7	1
A	onVcsPreCheckout()	16	16	2
A	onVcsPreExport()	16	16	2

<?php

/*
 * This file is part of the Conveyor package.
 *
 * (c) Jeroen Fiege <jeroen@webcreate.nl>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Webcreate\Conveyor\Subscriber;

use Symfony\Component\EventDispatcher\EventSubscriberInterface;
use Webcreate\Conveyor\IO\IOInterface;
use Webcreate\Vcs\Common\Event\Data\CheckoutEventData;
use Webcreate\Vcs\Common\Event\Data\ExportEventData;
use Webcreate\Vcs\Common\Event\VcsEvent;
use Webcreate\Vcs\Common\VcsEvents;

class VcsSubscriber implements EventSubscriberInterface
{
    protected $io;

Avoid variables with short names like $io. Configured minimum length is 3.

    public function __construct(IOInterface $io)

Avoid variables with short names like $io. Configured minimum length is 3.

    {
        $this->io = $io;
    }

    public static function getSubscribedEvents()
    {
        return array(
            VcsEvents::PRE_CHECKOUT => array('onVcsPreCheckout'),
            VcsEvents::PRE_EXPORT => array('onVcsPreExport'),
        );
    }

    public function onVcsPreCheckout(VcsEvent $event)

This method seems to be duplicated in your project.

    {
        if (false === $this->io->isVerbose()) return;

Please always use braces to surround the code block of IF statements.

It is generally a best practice to always use braces with control structures.

        /** @var CheckoutEventData $data */
        $data = $event->getData();

        $this->io->write(
            sprintf(
                'Checking out <comment>%s</comment> to <comment>%s</comment>...'
                ,

Space found before comma in function call

                $data->getHead()->getName(),
                $data->getDestination()
            )
        );
    }

    public function onVcsPreExport(VcsEvent $event)

This method seems to be duplicated in your project.

    {
        if (false === $this->io->isVerbose()) return;

Please always use braces to surround the code block of IF statements.

It is generally a best practice to always use braces with control structures.

        /** @var ExportEventData $data */
        $data = $event->getData();

        $this->io->write(
            sprintf(
                'Exporting <comment>%s</comment> to <comment>%s</comment>...'
                ,

Space found before comma in function call

                $data->getHead()->getName(),
                $data->getDestination()
            )
        );
    }
}