Webcreate\Conveyor\Factory\TaskRunnerFactory

Complexity

Total Complexity

5

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Test Coverage

Coverage

0%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	get()	0	13	2
A	getTasksConfig()	0	16	3

<?php

/*
 * This file is part of the Conveyor package.
 *
 * (c) Jeroen Fiege <jeroen@webcreate.nl>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Webcreate\Conveyor\Factory;

use Symfony\Component\EventDispatcher\EventDispatcherInterface;
use Webcreate\Conveyor\Config\YamlConfig;
use Webcreate\Conveyor\IO\IOInterface;
use Webcreate\Conveyor\Task\TaskRunner;

class TaskRunnerFactory
{
    /**
     * @param  string                   $taskConfigPath path to the tasks configuration in the conveyor.yml config
     * @param  TaskFactory              $taskFactory
     * @param  YamlConfig               $config
     * @param  IOInterface              $io
     * @param  EventDispatcherInterface $dispatcher
     * @return TaskRunner
     */
    public static function get($taskConfigPath, TaskFactory $taskFactory, YamlConfig $config, IOInterface $io, EventDispatcherInterface $dispatcher = null)

Avoid variables with short names like $io. Configured minimum length is 3.

    {
        $_config = $config->getConfig();

        $taskRunner = new TaskRunner($io, $dispatcher);

        foreach ((array) self::getTasksConfig($_config, $taskConfigPath) as $t => $taskConfig) {
            $task = $taskFactory->get($taskConfig['type'], $taskConfig);
            $taskRunner->addTask($task);

It seems like $task defined by $taskFactory->get($taskConfig['type'], $taskConfig) on line 36 can be null; however, Webcreate\Conveyor\Task\TaskRunner::addTask() does not accept null, maybe add an additional type check?

        }

        return $taskRunner;
    }

    /**
     * @param  array  $config
     * @param  string $taskConfigPath
     * @return array
     */
    protected static function getTasksConfig(array $config, $taskConfigPath)
    {
        $path = explode('.', $taskConfigPath);

        $currentConfig = $config;

        foreach ($path as $p => $_path) {
            if (!isset($currentConfig[$_path])) {
                return array();
            }

            $currentConfig = $currentConfig[$_path];
        }

        return $currentConfig;
    }
}