Inspection of "Actualizacion en usuarioControlador" - webcol/Calima - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5239d4...d0e8f5 )

by Calima

created 2016-03-13 00:52 UTC

Status

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -4,49 +4,49 @@
 block discarded – undo
  
 class MySqlProvider extends DatabaseProvider
 {
-    public function connect($host, $user, $pass, $dbname){
+    public function connect($host, $user, $pass, $dbname) {
         $this->resource = new mysqli($host, $user, $pass, $dbname);
  
-        if ($this->resource->connect_errno){ // Connection fails
+        if ($this->resource->connect_errno) { // Connection fails
             error_log($this->resource->connect_error);
         }
  
         return $this->resource;
     }
-    public function disconnect(){
+    public function disconnect() {
         return $this->resource->close();
     }
-    public function getErrorNo(){
+    public function getErrorNo() {
         return $this->resource->errno;
     }
-    public function getError(){
+    public function getError() {
         return $this->resource->error;
     }
-    public function query($q){
+    public function query($q) {
         return $this->resource->query($q);
     }
-    public function numRows($resource){
+    public function numRows($resource) {
         $num_rows = 0;
  
-        if ($resource){
+        if ($resource) {
             $num_rows = $resource->num_rows;
         }
  
         return $num_rows;
     }
-    public function fetchArray($result){
+    public function fetchArray($result) {
         return $result->fetch_assoc();
     }
-    public function isConnected(){
+    public function isConnected() {
         return !is_null($this->resource);
     }
-    public function escape($var){
+    public function escape($var) {
         return $this->resource->real_escape_string($var);
     }
-    public function getInsertedID(){
+    public function getInsertedID() {
         return $this->resource->insert_id;
     }
-    public function changeDB ($database){
+    public function changeDB($database) {
         return $this->resource->select_db($database);
     }
     public function setCharset($charset) {

Please login to merge, or discard this patch.

Sistema/librerias/ORMbasico/ORM.php 1 patch

Spacing +20 added lines, -20 removed lines patch added patch discarded remove patch

@@ -8,23 +8,23 @@  discard block
 block discarded – undo
         self::getConnection();
     }
  
-    private static function getConnection (){
+    private static function getConnection() {
         require_once('Database.php');
         self::$database = Database::getConnection(DB_PROVIDER, DB_HOST, DB_USER, DB_PASSWORD, DB_DB);
     }
  
     public static function find($id) {
-        $results = self::where('id',$id);
+        $results = self::where('id', $id);
         return $results[0];
     }
      
     public static function where($field, $value) {  
         $obj = null;
         self::getConnection();
-        $query = "SELECT * FROM ".static::$table." WHERE ".$field." = ?";
-        $results = self::$database->execute($query,null,array($value));
+        $query = "SELECT * FROM " . static::$table . " WHERE " . $field . " = ?";
+        $results = self::$database->execute($query, null, array($value));
  
-        if ($results){
+        if ($results) {
             $class = get_called_class();
             for ($i = 0; $i < sizeof($results); $i++) {
                 $obj[] = new $class($results[$i]);
@@ -38,17 +38,17 @@  discard block
 block discarded – undo
         $objs = null;
         self::getConnection();
  
-        $query = "SELECT * FROM ".static::$table;
+        $query = "SELECT * FROM " . static::$table;
  
-        if ($order){
+        if ($order) {
             $query .= $order;
         }
  
-        $results = self::$database->execute($query,null, null);
+        $results = self::$database->execute($query, null, null);
  
-        if ($results){
+        if ($results) {
             $class = get_called_class();
-            foreach ($results as $index => $obj){
+            foreach ($results as $index => $obj) {
                 $objs[] = new $class($obj);
             }
         }
@@ -56,33 +56,33 @@  discard block
 block discarded – undo
         return $objs;
     }
  
-    public function save(){
+    public function save() {
         $values = get_object_vars($this);
         $filtered = null;
  
-        foreach ($values as $key => $value){
-            if ($value !== null && $value !== '' && strpos($key,'obj_') === false
-                && $key !== 'id'){
+        foreach ($values as $key => $value) {
+            if ($value !== null && $value !== '' && strpos($key, 'obj_') === false
+                && $key !== 'id') {
                 if ($value === false) { $value = 0; }
                 $filtered[$key] = $value;
             }
         }
         $columns = array_keys($filtered);
  
-        if ($this->id){
-            $columns = join (" = ?, ", $columns);
+        if ($this->id) {
+            $columns = join(" = ?, ", $columns);
             $columns .= ' = ?';
-            $query = "UPDATE ".static::$table." SET $columns WHERE id =".$this->id;
+            $query = "UPDATE " . static::$table . " SET $columns WHERE id =" . $this->id;
         }
         else {
             $params = join(", ", array_fill(0, count($columns), "?"));
             $columns = join(", ", $columns);
-            $query = "INSERT INTO ".static::$table." ($columns) VALUES ($params)";
+            $query = "INSERT INTO " . static::$table . " ($columns) VALUES ($params)";
         }
  
-        $result = self::$database->execute($query,null,$filtered);
+        $result = self::$database->execute($query, null, $filtered);
  
-        if ($result){
+        if ($result) {
             $result = array('error' => false, 'message' => self::$database->getInsertedID());
         }
         else {

Please login to merge, or discard this patch.

sistema/librerias/ORMbasico/Database.php 1 patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -4,49 +4,49 @@
 block discarded – undo
  
 class MySqlProvider extends DatabaseProvider
 {
-    public function connect($host, $user, $pass, $dbname){
+    public function connect($host, $user, $pass, $dbname) {
         $this->resource = new mysqli($host, $user, $pass, $dbname);
  
-        if ($this->resource->connect_errno){ // Connection fails
+        if ($this->resource->connect_errno) { // Connection fails
             error_log($this->resource->connect_error);
         }
  
         return $this->resource;
     }
-    public function disconnect(){
+    public function disconnect() {
         return $this->resource->close();
     }
-    public function getErrorNo(){
+    public function getErrorNo() {
         return $this->resource->errno;
     }
-    public function getError(){
+    public function getError() {
         return $this->resource->error;
     }
-    public function query($q){
+    public function query($q) {
         return $this->resource->query($q);
     }
-    public function numRows($resource){
+    public function numRows($resource) {
         $num_rows = 0;
  
-        if ($resource){
+        if ($resource) {
             $num_rows = $resource->num_rows;
         }
  
         return $num_rows;
     }
-    public function fetchArray($result){
+    public function fetchArray($result) {
         return $result->fetch_assoc();
     }
-    public function isConnected(){
+    public function isConnected() {
         return !is_null($this->resource);
     }
-    public function escape($var){
+    public function escape($var) {
         return $this->resource->real_escape_string($var);
     }
-    public function getInsertedID(){
+    public function getInsertedID() {
         return $this->resource->insert_id;
     }
-    public function changeDB ($database){
+    public function changeDB($database) {
         return $this->resource->select_db($database);
     }
     public function setCharset($charset) {

Please login to merge, or discard this patch.

console/Symfony/Component/Console/Tests/Helper/LegacyDialogHelperTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -173,7 +173,7 @@
 block discarded – undo
         $dialog->setHelperSet($helperSet);
 
         $error = 'This is not a color!';
-        $validator = function ($color) use ($error) {
+        $validator = function($color) use ($error) {
             if (!in_array($color, array('white', 'black'))) {
                 throw new \InvalidArgumentException($error);
             }

Please login to merge, or discard this patch.

		@@ -4,49 +4,49 @@
		block discarded – undo
4	4
5	5	class MySqlProvider extends DatabaseProvider
6	6	{
7		- public function connect($host, $user, $pass, $dbname){
	7	+ public function connect($host, $user, $pass, $dbname) {
8	8	$this->resource = new mysqli($host, $user, $pass, $dbname);
9	9
10		- if ($this->resource->connect_errno){ // Connection fails
	10	+ if ($this->resource->connect_errno) { // Connection fails
11	11	error_log($this->resource->connect_error);
12	12	}
13	13
14	14	return $this->resource;
15	15	}
16		- public function disconnect(){
	16	+ public function disconnect() {
17	17	return $this->resource->close();
18	18	}
19		- public function getErrorNo(){
	19	+ public function getErrorNo() {
20	20	return $this->resource->errno;
21	21	}
22		- public function getError(){
	22	+ public function getError() {
23	23	return $this->resource->error;
24	24	}
25		- public function query($q){
	25	+ public function query($q) {
26	26	return $this->resource->query($q);
27	27	}
28		- public function numRows($resource){
	28	+ public function numRows($resource) {
29	29	$num_rows = 0;
30	30
31		- if ($resource){
	31	+ if ($resource) {
32	32	$num_rows = $resource->num_rows;
33	33	}
34	34
35	35	return $num_rows;
36	36	}
37		- public function fetchArray($result){
	37	+ public function fetchArray($result) {
38	38	return $result->fetch_assoc();
39	39	}
40		- public function isConnected(){
	40	+ public function isConnected() {
41	41	return !is_null($this->resource);
42	42	}
43		- public function escape($var){
	43	+ public function escape($var) {
44	44	return $this->resource->real_escape_string($var);
45	45	}
46		- public function getInsertedID(){
	46	+ public function getInsertedID() {
47	47	return $this->resource->insert_id;
48	48	}
49		- public function changeDB ($database){
	49	+ public function changeDB($database) {
50	50	return $this->resource->select_db($database);
51	51	}
52	52	public function setCharset($charset) {

		@@ -8,23 +8,23 @@ discard block
		block discarded – undo
8	8	self::getConnection();
9	9	}
10	10
11		- private static function getConnection (){
	11	+ private static function getConnection() {
12	12	require_once('Database.php');
13	13	self::$database = Database::getConnection(DB_PROVIDER, DB_HOST, DB_USER, DB_PASSWORD, DB_DB);
14	14	}
15	15
16	16	public static function find($id) {
17		- $results = self::where('id',$id);
	17	+ $results = self::where('id', $id);
18	18	return $results[0];
19	19	}
20	20
21	21	public static function where($field, $value) {
22	22	$obj = null;
23	23	self::getConnection();
24		- $query = "SELECT * FROM ".static::$table." WHERE ".$field." = ?";
25		- $results = self::$database->execute($query,null,array($value));
	24	+ $query = "SELECT * FROM " . static::$table . " WHERE " . $field . " = ?";
	25	+ $results = self::$database->execute($query, null, array($value));
26	26
27		- if ($results){
	27	+ if ($results) {
28	28	$class = get_called_class();
29	29	for ($i = 0; $i < sizeof($results); $i++) {
30	30	$obj[] = new $class($results[$i]);
		@@ -38,17 +38,17 @@ discard block
		block discarded – undo
38	38	$objs = null;
39	39	self::getConnection();
40	40
41		- $query = "SELECT * FROM ".static::$table;
	41	+ $query = "SELECT * FROM " . static::$table;
42	42
43		- if ($order){
	43	+ if ($order) {
44	44	$query .= $order;
45	45	}
46	46
47		- $results = self::$database->execute($query,null, null);
	47	+ $results = self::$database->execute($query, null, null);
48	48
49		- if ($results){
	49	+ if ($results) {
50	50	$class = get_called_class();
51		- foreach ($results as $index => $obj){
	51	+ foreach ($results as $index => $obj) {
52	52	$objs[] = new $class($obj);
53	53	}
54	54	}
		@@ -56,33 +56,33 @@ discard block
		block discarded – undo
56	56	return $objs;
57	57	}
58	58
59		- public function save(){
	59	+ public function save() {
60	60	$values = get_object_vars($this);
61	61	$filtered = null;
62	62
63		- foreach ($values as $key => $value){
64		- if ($value !== null && $value !== '' && strpos($key,'obj_') === false
65		- && $key !== 'id'){
	63	+ foreach ($values as $key => $value) {
	64	+ if ($value !== null && $value !== '' && strpos($key, 'obj_') === false
	65	+ && $key !== 'id') {
66	66	if ($value === false) { $value = 0; }
67	67	$filtered[$key] = $value;
68	68	}
69	69	}
70	70	$columns = array_keys($filtered);
71	71
72		- if ($this->id){
73		- $columns = join (" = ?, ", $columns);
	72	+ if ($this->id) {
	73	+ $columns = join(" = ?, ", $columns);
74	74	$columns .= ' = ?';
75		- $query = "UPDATE ".static::$table." SET $columns WHERE id =".$this->id;
	75	+ $query = "UPDATE " . static::$table . " SET $columns WHERE id =" . $this->id;
76	76	}
77	77	else {
78	78	$params = join(", ", array_fill(0, count($columns), "?"));
79	79	$columns = join(", ", $columns);
80		- $query = "INSERT INTO ".static::$table." ($columns) VALUES ($params)";
	80	+ $query = "INSERT INTO " . static::$table . " ($columns) VALUES ($params)";
81	81	}
82	82
83		- $result = self::$database->execute($query,null,$filtered);
	83	+ $result = self::$database->execute($query, null, $filtered);
84	84
85		- if ($result){
	85	+ if ($result) {
86	86	$result = array('error' => false, 'message' => self::$database->getInsertedID());
87	87	}
88	88	else {

		@@ -4,49 +4,49 @@
		block discarded – undo
4	4
5	5	class MySqlProvider extends DatabaseProvider
6	6	{
7		- public function connect($host, $user, $pass, $dbname){
	7	+ public function connect($host, $user, $pass, $dbname) {
8	8	$this->resource = new mysqli($host, $user, $pass, $dbname);
9	9
10		- if ($this->resource->connect_errno){ // Connection fails
	10	+ if ($this->resource->connect_errno) { // Connection fails
11	11	error_log($this->resource->connect_error);
12	12	}
13	13
14	14	return $this->resource;
15	15	}
16		- public function disconnect(){
	16	+ public function disconnect() {
17	17	return $this->resource->close();
18	18	}
19		- public function getErrorNo(){
	19	+ public function getErrorNo() {
20	20	return $this->resource->errno;
21	21	}
22		- public function getError(){
	22	+ public function getError() {
23	23	return $this->resource->error;
24	24	}
25		- public function query($q){
	25	+ public function query($q) {
26	26	return $this->resource->query($q);
27	27	}
28		- public function numRows($resource){
	28	+ public function numRows($resource) {
29	29	$num_rows = 0;
30	30
31		- if ($resource){
	31	+ if ($resource) {
32	32	$num_rows = $resource->num_rows;
33	33	}
34	34
35	35	return $num_rows;
36	36	}
37		- public function fetchArray($result){
	37	+ public function fetchArray($result) {
38	38	return $result->fetch_assoc();
39	39	}
40		- public function isConnected(){
	40	+ public function isConnected() {
41	41	return !is_null($this->resource);
42	42	}
43		- public function escape($var){
	43	+ public function escape($var) {
44	44	return $this->resource->real_escape_string($var);
45	45	}
46		- public function getInsertedID(){
	46	+ public function getInsertedID() {
47	47	return $this->resource->insert_id;
48	48	}
49		- public function changeDB ($database){
	49	+ public function changeDB($database) {
50	50	return $this->resource->select_db($database);
51	51	}
52	52	public function setCharset($charset) {

		@@ -173,7 +173,7 @@
		block discarded – undo
173	173	$dialog->setHelperSet($helperSet);
174	174
175	175	$error = 'This is not a color!';
176		- $validator = function ($color) use ($error) {
	176	+ $validator = function($color) use ($error) {
177	177	if (!in_array($color, array('white', 'black'))) {
178	178	throw new \InvalidArgumentException($error);
179	179	}

GitHub Access Token became invalid

Push — master ( 5239d4...d0e8f5 )

Status

Category

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

Spacing +20 added lines, -20 removed lines patch added patch discarded remove patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

webcol / Calima

GitHub Access Token became invalid

Push — master ( 5239d4...d0e8f5 )

Status

Category

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

Spacing +20 added lines, -20 removed lines patch added patch discarded remove patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch