Sistema\Ayudantes\CFPHPSeguridad

Complexity

Total Complexity

19

Size/Duplication

Total Lines	124
Duplicated Lines	9.68 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

13 Methods

Rating	Name	Duplication	Size	Complexity
A	xsseguro()	0	3	1
A	xecho()	0	3	1
A	filtrarTexto()	0	3	1
A	filtrarCaracteresEspeciales()	0	3	1
A	generarCadenaAleatoria()	0	9	2
A	cifrado()	0	4	1
A	generoTokenDeFormulario()	6	6	1
A	verificoTokenDeFormulario()	6	6	1
A	obtenerDireccionIP()	0	10	3
A	restringirIp()	0	11	2
A	restringirConjuntoIps()	0	11	2
A	restringirRango()	0	11	2
A	emailSeguro()	0	3	1

<?php

/*
 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 *
 * This software consists of voluntary contributions made by many individuals
 * and is licensed under the MIT license. For more information, see
 * @category   
 * @package    sistema/ayudantes
 * @copyright  Copyright (c) 2006 - 2014 webcol.net (http://www.webcol.net/calima)
 * @license	https://github.com/webcol/Calima/blob/master/LICENSE	MIT
 * @version	##BETA 1.0##, ##2014 - 2015##
 * <http://www.calimaframework.com>.
 */

namespace Sistema\Ayudantes;

class CFPHPSeguridad {

//Seguridad
    
    //xss funciones de mitigacion
    function xsseguro($texto,$encoding='UTF-8'){
       return htmlspecialchars($texto,ENT_QUOTES | ENT_HTML401,$encoding);
    }
    function xecho($texto){
       echo xsseguro($texto);
    }
    
    public function filtrarTexto($texto){
        return strip_tags($texto);
    }
    
     
    
    public function filtrarCaracteresEspeciales($texto){
        return htmlspecialchars($texto, ENT_QUOTES);
    }
    
    
    // Genracion de Cadenas Aleatorias
    function generarCadenaAleatoria($longitud = 10) {

The parameter $longitud is not used and could be removed.

        $caracteres = '0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ';
        $longitudCaracteres = strlen($caracteres);
        $cadenaAleatoria = '';
        for ($i = 0; $i < $length; $i++) {

The variable $length does not exist. Did you forget to declare it?

             $cadenaAleatoria .= $caracteres[rand(0, $longitudCaracteres - 1)];
        }
        return $cadenaAleatoria;
    }
    // encriptacion
    function cifrado($clave){
        $cfi=sha1(md5($clave));
        return $clave=Cf_KEY_MD5.$cfi;
    }
    // Protecion CSRF
    public function generoTokenDeFormulario($formulario) {
        $secreta =  Cf_CSRF_SECRET.$this->generarCadenaAleatoria();
        $sid = session_id();
        $token = md5($secreta.$sid.$formulario);
        return $token;
    }
    
    public function verificoTokenDeFormulario($formulario, $token) {
        $secreta =  Cf_CSRF_SECRET.$this->generarCadenaAleatoria();
        $sid = session_id();
        $correcta = md5($secreta.$sid.$formulario);
        return ($token == $correcta);
    }
    
    function obtenerDireccionIP(){

obtenerDireccionIP uses the super-global variable $_SERVER which is generally not recommended.

    if (!empty($_SERVER ['HTTP_CLIENT_IP'] ))
      $ip=$_SERVER ['HTTP_CLIENT_IP'];
    elseif (!empty($_SERVER ['HTTP_X_FORWARDED_FOR'] ))
      $ip=$_SERVER ['HTTP_X_FORWARDED_FOR'];
    else
      $ip=$_SERVER ['REMOTE_ADDR'];

    return $ip;
	}
	
    function restringirIp($ip){
        $ipCliente = $this->obtenerDireccionIP();

        if($ipCliente == $ip){
        return true;
        }
        else{
        header('location: http://www.tusitioweb/redireccion');
        exit;

The method restringirIp() contains an exit expression.

        }
    }
	
	function restringirConjuntoIps($ips){
    $ipCliente = obtenerDireccionIP();

    if (in_array($ipCliente,$ips)){
        return true;
    }
    else{
        header('location: http://direccion_envio_salida');
        exit;

The method restringirConjuntoIps() contains an exit expression.

    }
	}
	
	function restringirRango(){
    $ipCliente = obtenerDireccionIP();

    if(substr($ipCliente, 0, 8 ) == "150.214."){
        return true;
    }
    else{
        header('location: http://direccion_envio_salida');
        exit;

The method restringirRango() contains an exit expression.

    }
	}
        
        
    /**
 *
 * @strip injection chars from email headers
 *
 * @param string $string

There is no parameter named $string. Was it maybe removed?

 *
 * return string
 *
 */
function emailSeguro($cadena) {
     return  preg_replace( '((?:\n|\r|\t|%0A|%0D|%08|%09)+)i' , '', $cadena );
}

/*** example usage 
$from = "sender@example.com
Cc:victim@example.com";

if(strlen($from) < 100)
{
    $from = emailSeguro($from);
}***/
    
}