Completed
Pull Request — master (#72)
by
unknown
01:34
created
lumen-test/tests/acceptance/RouteCommandCept.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@
 block discarded – undo
62 62
 
63 63
 
64 64
 $I->wantTo('run wn:routes in Lumen 5.3+');
65
-if(!file_exists('./routes')) {
65
+if (!file_exists('./routes')) {
66 66
     mkdir('./routes');
67 67
 }
68 68
 $I->writeToFile('./routes/web.php', '<?php
Please login to merge, or discard this patch.
src/Commands/MigrationCommand.php 2 patches
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
         if(! $file){
38 38
             $file = date('Y_m_d_His_') . $snakeName . '_table';
39 39
             $this->deleteOldMigration($snakeName);
40
-        }else{
40
+        } else{
41 41
             $this->deleteOldMigration($file);
42 42
         }
43 43
 
@@ -47,7 +47,9 @@  discard block
 block discarded – undo
47 47
     protected function deleteOldMigration($fileName)
48 48
     {
49 49
         foreach (new \DirectoryIterator("./database/migrations/") as $fileInfo){
50
-            if($fileInfo->isDot()) continue;
50
+            if($fileInfo->isDot()) {
51
+                continue;
52
+            }
51 53
 
52 54
             if(strpos($fileInfo->getFilename(), $fileName) !== FALSE){
53 55
                 unlink($fileInfo->getPathname());
Please login to merge, or discard this patch.
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -34,10 +34,10 @@  discard block
 block discarded – undo
34 34
             ->get();
35 35
 
36 36
         $file = $this->option('file');
37
-        if(! $file){
37
+        if (!$file) {
38 38
             $file = date('Y_m_d_His_') . $snakeName . '_table';
39 39
             $this->deleteOldMigration($snakeName);
40
-        }else{
40
+        } else {
41 41
             $this->deleteOldMigration($file);
42 42
         }
43 43
 
@@ -46,10 +46,10 @@  discard block
 block discarded – undo
46 46
 
47 47
     protected function deleteOldMigration($fileName)
48 48
     {
49
-        foreach (new \DirectoryIterator("./database/migrations/") as $fileInfo){
50
-            if($fileInfo->isDot()) continue;
49
+        foreach (new \DirectoryIterator("./database/migrations/") as $fileInfo) {
50
+            if ($fileInfo->isDot()) continue;
51 51
 
52
-            if(strpos($fileInfo->getFilename(), $fileName) !== FALSE){
52
+            if (strpos($fileInfo->getFilename(), $fileName) !== FALSE) {
53 53
                 unlink($fileInfo->getPathname());
54 54
             }
55 55
         }
@@ -58,12 +58,12 @@  discard block
 block discarded – undo
58 58
     protected function getSchema()
59 59
     {
60 60
         $schema = $this->option('schema');
61
-        if(! $schema){
61
+        if (!$schema) {
62 62
             return $this->spaces(12) . "// Schema declaration";
63 63
         }
64 64
 
65 65
         $items = $schema;
66
-        if( ! $this->option('parsed')){
66
+        if (!$this->option('parsed')) {
67 67
             $items = $this->getArgumentParser('schema')->parse($schema);
68 68
         }
69 69
 
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
         $name = $parts[0]['name'];
98 98
         $parts[1]['args'] = array_merge(["'{$name}'"], $parts[1]['args']);
99 99
         unset($parts[0]);
100
-        $parts = array_map(function($part){
100
+        $parts = array_map(function($part) {
101 101
             return '->' . $part['name'] . '(' . implode(', ', $part['args']) . ')';
102 102
         }, $parts);
103 103
         return "            \$table" . implode('', $parts) . ';';
@@ -106,12 +106,12 @@  discard block
 block discarded – undo
106 106
     protected function getConstraints()
107 107
     {
108 108
         $keys = $this->option('keys');
109
-        if(! $keys){
109
+        if (!$keys) {
110 110
             return $this->spaces(12) . "// Constraints declaration";
111 111
         }
112 112
 
113 113
         $items = $keys;
114
-        if(! $this->option('parsed')){
114
+        if (!$this->option('parsed')) {
115 115
             $items = $this->getArgumentParser('foreign-keys')->parse($keys);
116 116
         }
117 117
 
@@ -125,10 +125,10 @@  discard block
 block discarded – undo
125 125
 
126 126
     protected function getConstraintDeclaration($key)
127 127
     {
128
-        if(! $key['column']){
128
+        if (!$key['column']) {
129 129
             $key['column'] = 'id';
130 130
         }
131
-        if(! $key['table']){
131
+        if (!$key['table']) {
132 132
             $key['table'] = \Illuminate\Support\Str::plural(substr($key['name'], 0, strlen($key['name']) - 3));
133 133
         }
134 134
 
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
             ])
141 141
             ->get();
142 142
 
143
-        if($key['on_delete']){
143
+        if ($key['on_delete']) {
144 144
             $constraint .= PHP_EOL . $this->getTemplate('migration/on-constraint')
145 145
                     ->with([
146 146
                         'event' => 'Delete',
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
                     ->get();
150 150
         }
151 151
 
152
-        if($key['on_update']){
152
+        if ($key['on_update']) {
153 153
             $constraint .= PHP_EOL . $this->getTemplate('migration/on-constraint')
154 154
                     ->with([
155 155
                         'event' => 'Update',
Please login to merge, or discard this patch.
src/Commands/ModelCommand.php 3 patches
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -45,12 +45,12 @@  discard block
 block discarded – undo
45 45
     protected function getAsArrayFields($arg, $isOption = true)
46 46
     {
47 47
     	$arg = ($isOption) ? $this->option($arg) : $this->argument($arg);
48
-        if(is_string($arg)){
48
+        if (is_string($arg)) {
49 49
         	$arg = explode(',', $arg);
50
-        } else if(! is_array($arg)) {
50
+        } else if (!is_array($arg)) {
51 51
             $arg = [];
52 52
         }
53
-        return implode(', ', array_map(function($item){
53
+        return implode(', ', array_map(function($item) {
54 54
             return '"' . $item . '"';
55 55
         }, $arg));
56 56
     }
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
             $this->getRelationsByType('belongsToMany', 'belongs-to-many', true)
70 70
         );
71 71
 
72
-        if(empty($relations)){
72
+        if (empty($relations)) {
73 73
             return "    // Relationships";
74 74
         }
75 75
 
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
     {
81 81
         $relations = [];
82 82
         $option = $this->option($option);
83
-        if($option){
83
+        if ($option) {
84 84
 
85 85
             $items = $this->getArgumentParser('relations')->parse($option);
86 86
 
@@ -88,9 +88,9 @@  discard block
 block discarded – undo
88 88
             $template = $this->getTemplate($template);
89 89
             foreach ($items as $item) {
90 90
                 $item['type'] = $type;
91
-                if(! $item['model']){
91
+                if (!$item['model']) {
92 92
                     $item['model'] = $this->getNamespace() . '\\' . ucwords(\Illuminate\Support\Str::singular($item['name']));
93
-                } else if(strpos($item['model'], '\\') === false ){
93
+                } else if (strpos($item['model'], '\\') === false) {
94 94
                     $item['model'] = $this->getNamespace() . '\\' . $item['model'];
95 95
                 }
96 96
                 $relations[] = $template->with($item)->get();
@@ -102,11 +102,11 @@  discard block
 block discarded – undo
102 102
     protected function getRules()
103 103
     {
104 104
         $rules = $this->option('rules');
105
-        if(! $rules){
105
+        if (!$rules) {
106 106
             return "        // Validation rules";
107 107
         }
108 108
         $items = $rules;
109
-        if(! $this->option('parsed')){
109
+        if (!$this->option('parsed')) {
110 110
             $items = $this->getArgumentParser('rules')->parse($rules);
111 111
         }
112 112
         $rules = [];
Please login to merge, or discard this patch.
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
 
4 4
 class ModelCommand extends BaseCommand {
5 5
 
6
-	protected $signature = 'wn:model
6
+    protected $signature = 'wn:model
7 7
         {name : Name of the model.}
8 8
         {--fillable= : the fillable fields.}
9 9
         {--guarded= : the guarded fields.}
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
         {--force= : override the existing files}
21 21
     ';
22 22
 
23
-	protected $description = 'Generates a model class for a RESTfull resource';
23
+    protected $description = 'Generates a model class for a RESTfull resource';
24 24
 
25 25
     public function handle()
26 26
     {
@@ -46,9 +46,9 @@  discard block
 block discarded – undo
46 46
 
47 47
     protected function getAsArrayFields($arg, $isOption = true)
48 48
     {
49
-    	$arg = ($isOption) ? $this->option($arg) : $this->argument($arg);
49
+        $arg = ($isOption) ? $this->option($arg) : $this->argument($arg);
50 50
         if(is_string($arg)){
51
-        	$arg = explode(',', $arg);
51
+            $arg = explode(',', $arg);
52 52
         } else if(! is_array($arg)) {
53 53
             $arg = [];
54 54
         }
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
 
60 60
     protected function getNamespace()
61 61
     {
62
-    	return str_replace(' ', '\\', ucwords(str_replace('/', ' ', $this->option('path'))));
62
+        return str_replace(' ', '\\', ucwords(str_replace('/', ' ', $this->option('path'))));
63 63
     }
64 64
 
65 65
     protected function getRelations()
Please login to merge, or discard this patch.
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -44,6 +44,9 @@  discard block
 block discarded – undo
44 44
         $this->save($content, "./App/Models/{$name}.php", "{$name} model");
45 45
     }
46 46
 
47
+    /**
48
+     * @param string $arg
49
+     */
47 50
     protected function getAsArrayFields($arg, $isOption = true)
48 51
     {
49 52
     	$arg = ($isOption) ? $this->option($arg) : $this->argument($arg);
@@ -78,6 +81,10 @@  discard block
 block discarded – undo
78 81
         return implode(PHP_EOL, $relations);
79 82
     }
80 83
 
84
+    /**
85
+     * @param string $type
86
+     * @param string $option
87
+     */
81 88
     protected function getRelationsByType($type, $option, $withTimestamps = false)
82 89
     {
83 90
         $relations = [];
Please login to merge, or discard this patch.