JWKSetSource::load() - Code Metrics - Inspection of "Merge remote-tracking branch 'origin/master'" - web-token/jwt-framework - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( 6560de...8483ce )

by Florent

created 2017-11-15 20:32 UTC

JWKSetSource::load() A

↳ Parent: JWKSetSource

Complexity

Conditions	4
Paths	4

Size

Total Lines	14
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	14
rs	9.2
c	0
b	0
f	0
cc	4
eloc	9
nc	4
nop	2

<?php

declare(strict_types=1);

/*
 * The MIT License (MIT)
 *
 * Copyright (c) 2014-2017 Spomky-Labs
 *
 * This software may be modified and distributed under the terms
 * of the MIT license.  See the LICENSE file for details.
 */

namespace Jose\Bundle\KeyManagement\DependencyInjection\Source;

use Jose\Bundle\JoseFramework\DependencyInjection\Source\Source;
use Jose\Bundle\KeyManagement\DependencyInjection\Source\JWKSetSource\JWKSetSource as JWKSetSourceInterface;
use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
use Symfony\Component\Config\FileLocator;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Loader\YamlFileLoader;

/**
 * Class JWKSetSource.
 */
final class JWKSetSource implements Source
{
    /**
     * @var null|JWKSetSourceInterface[]
     */
    private $jwkset_sources = null;

    /**
     * {@inheritdoc}
     */
    public function name(): string
    {
        return 'key_sets';
    }

    /**
     * {@inheritdoc}
     */
    public function load(array $configs, ContainerBuilder $container)
    {
        $sources = $this->getJWKSetSources();
        foreach ($configs[$this->name()] as $name => $itemConfig) {
            foreach ($itemConfig as $sourceName => $sourceConfig) {
                if (array_key_exists($sourceName, $sources)) {
                    $source = $sources[$sourceName];
                    $source->create($container, 'key_set', $name, $sourceConfig);

                } else {
                    throw new \LogicException(sprintf('The JWKSet definition "%s" is not configured.', $name));
                }
            }
        }
    }

    /**
     * {@inheritdoc}
     */
    public function getNodeDefinition(ArrayNodeDefinition $node)
    {
        $sourceNodeBuilder = $node
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            ->children()
                ->arrayNode('key_sets')
                    ->useAttributeAsKey('name')
                    ->prototype('array')
                        ->performNoDeepMerging()
                        ->children();
        foreach ($this->getJWKSetSources() as $name => $source) {
            $sourceNode = $sourceNodeBuilder->arrayNode($name)->canBeUnset();
            $source->addConfiguration($sourceNode);

        }
    }

    /**
     * {@inheritdoc}
     */
    public function prepend(ContainerBuilder $container, array $config): ?array
    {
        return null;
    }

    /**
     * @return JWKSetSource[]
     */
    private function getJWKSetSources(): array
    {
        if (null !== $this->jwkset_sources) {
            return $this->jwkset_sources;
        }

        // load bundled adapter factories
        $tempContainer = new ContainerBuilder();
        $loader = new YamlFileLoader($tempContainer, new FileLocator(__DIR__.'/../../Resources/config'));
        $loader->load('jwkset_sources.yml');

        $services = $tempContainer->findTaggedServiceIds('jose.jwkset_source');
        $jwkset_sources = [];
        foreach (array_keys($services) as $id) {
            $factory = $tempContainer->get($id);
            $jwkset_sources[str_replace('-', '_', $factory->getKeySet())] = $factory;
        }

        return $this->jwkset_sources = $jwkset_sources;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* The MIT License (MIT)
7			*
8			* Copyright (c) 2014-2017 Spomky-Labs
9			*
10			* This software may be modified and distributed under the terms
11			* of the MIT license. See the LICENSE file for details.
12			*/
13
14			namespace Jose\Bundle\KeyManagement\DependencyInjection\Source;
15
16			use Jose\Bundle\JoseFramework\DependencyInjection\Source\Source;
17			use Jose\Bundle\KeyManagement\DependencyInjection\Source\JWKSetSource\JWKSetSource as JWKSetSourceInterface;
18			use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
19			use Symfony\Component\Config\FileLocator;
20			use Symfony\Component\DependencyInjection\ContainerBuilder;
21			use Symfony\Component\DependencyInjection\Loader\YamlFileLoader;
22
23			/**
24			* Class JWKSetSource.
25			*/
26			final class JWKSetSource implements Source
27			{
28			/**
29			* @var null\|JWKSetSourceInterface[]
30			*/
31			private $jwkset_sources = null;
32
33			/**
34			* {@inheritdoc}
35			*/
36			public function name(): string
37			{
38			return 'key_sets';
39			}
40
41			/**
42			* {@inheritdoc}
43			*/
44			public function load(array $configs, ContainerBuilder $container)
45			{
46			$sources = $this->getJWKSetSources();
47			foreach ($configs[$this->name()] as $name => $itemConfig) {
48			foreach ($itemConfig as $sourceName => $sourceConfig) {
49			if (array_key_exists($sourceName, $sources)) {
50			$source = $sources[$sourceName];
51			$source->create($container, 'key_set', $name, $sourceConfig);
			0 ignored issues – show Bug introduced 2017-11-15 20:38 UTC by Report Bug Copy Issue Report The method `create()` does not seem to exist on `object<Jose\Bundle\KeyMa...on\Source\JWKSetSource>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
52			} else {
53			throw new \LogicException(sprintf('The JWKSet definition "%s" is not configured.', $name));
54			}
55			}
56			}
57			}
58
59			/**
60			* {@inheritdoc}
61			*/
62			public function getNodeDefinition(ArrayNodeDefinition $node)
63			{
64			$sourceNodeBuilder = $node
			0 ignored issues – show Bug introduced 2017-10-06 14:35 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Symfony\Component\Config...\Builder\NodeDefinition` as the method `performNoDeepMerging()` does only exist in the following sub-classes of `Symfony\Component\Config...\Builder\NodeDefinition`: `Symfony\Component\Config...der\ArrayNodeDefinition`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
65			->children()
66			->arrayNode('key_sets')
67			->useAttributeAsKey('name')
68			->prototype('array')
69			->performNoDeepMerging()
70			->children();
71			foreach ($this->getJWKSetSources() as $name => $source) {
72			$sourceNode = $sourceNodeBuilder->arrayNode($name)->canBeUnset();
73			$source->addConfiguration($sourceNode);
			0 ignored issues – show Bug introduced 2017-11-15 20:38 UTC by Report Bug Copy Issue Report The method `addConfiguration()` does not seem to exist on `object<Jose\Bundle\KeyMa...on\Source\JWKSetSource>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
74			}
75			}
76
77			/**
78			* {@inheritdoc}
79			*/
80			public function prepend(ContainerBuilder $container, array $config): ?array
81			{
82			return null;
83			}
84
85			/**
86			* @return JWKSetSource[]
87			*/
88			private function getJWKSetSources(): array
89			{
90			if (null !== $this->jwkset_sources) {
91			return $this->jwkset_sources;
92			}
93
94			// load bundled adapter factories
95			$tempContainer = new ContainerBuilder();
96			$loader = new YamlFileLoader($tempContainer, new FileLocator(__DIR__.'/../../Resources/config'));
97			$loader->load('jwkset_sources.yml');
98
99			$services = $tempContainer->findTaggedServiceIds('jose.jwkset_source');
100			$jwkset_sources = [];
101			foreach (array_keys($services) as $id) {
102			$factory = $tempContainer->get($id);
103			$jwkset_sources[str_replace('-', '_', $factory->getKeySet())] = $factory;
104			}
105
106			return $this->jwkset_sources = $jwkset_sources;
107			}
108			}
109

web-token / jwt-framework

Push — master ( 6560de...8483ce )

JWKSetSource::load() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like