InvalidHeaderException - Code Metrics - Inspection of "Merge remote-tracking branch 'origin/master'" - web-token/jwt-framework - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( 6560de...8483ce )

by Florent

created 2017-11-15 20:32 UTC

InvalidHeaderException A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

Metric	Value
wmc	3
lcom	0
cbo	0
dl	0
loc	42
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	__construct()	7	1
A	getHeader()	4	1
A	getValue()	4	1

<?php

declare(strict_types=1);

/*
 * The MIT License (MIT)
 *
 * Copyright (c) 2014-2017 Spomky-Labs
 *
 * This software may be modified and distributed under the terms
 * of the MIT license.  See the LICENSE file for details.
 */

namespace Jose\Component\Checker;

/**
 * Class InvalidHeaderException.
 */
final class InvalidHeaderException extends \Error
{
    /**
     * @var string
     */
    private $header;

    /**
     * @var mixed
     */
    private $value;

    /**
     * InvalidHeaderException constructor.
     * @param string $message
     * @param string $header
     * @param mixed  $value
     */
    public function __construct(string $message, string $header, $value)
    {
        parent::__construct($message);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        $this->header = $header;
        $this->value = $value;
    }

    /**
     * @return string
     */
    public function getHeader(): string
    {
        return $this->header;
    }

    /**
     * @return mixed
     */
    public function getValue()
    {
        return $this->value;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* The MIT License (MIT)
7			*
8			* Copyright (c) 2014-2017 Spomky-Labs
9			*
10			* This software may be modified and distributed under the terms
11			* of the MIT license. See the LICENSE file for details.
12			*/
13
14			namespace Jose\Component\Checker;
15
16			/**
17			* Class InvalidHeaderException.
18			*/
19			final class InvalidHeaderException extends \Error
20			{
21			/**
22			* @var string
23			*/
24			private $header;
25
26			/**
27			* @var mixed
28			*/
29			private $value;
30
31			/**
32			* InvalidHeaderException constructor.
33			* @param string $message
34			* @param string $header
35			* @param mixed $value
36			*/
37			public function __construct(string $message, string $header, $value)
38			{
39			parent::__construct($message);
			0 ignored issues – show Bug introduced 2017-11-15 20:38 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Error` as the method `__construct()` does only exist in the following sub-classes of `Error`: `Jose\Component\Checker\InvalidClaimException`, `Jose\Component\Checker\InvalidHeaderException`, `TypeError`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
40
41			$this->header = $header;
42			$this->value = $value;
43			}
44
45			/**
46			* @return string
47			*/
48			public function getHeader(): string
49			{
50			return $this->header;
51			}
52
53			/**
54			* @return mixed
55			*/
56			public function getValue()
57			{
58			return $this->value;
59			}
60			}
61

web-token / jwt-framework

Push — master ( 6560de...8483ce )

InvalidHeaderException A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like