JWKSource::getJWKSources() - Code Metrics - Inspection of "Key Management Bundle" - web-token/jwt-framework - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( d9377e...587e80 )

by Florent

created 2017-10-09 19:06 UTC

JWKSource::getJWKSources() A

↳ Parent: JWKSource

Complexity

Conditions	3
Paths	3

Size

Total Lines	21
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	21
rs	9.3142
c	0
b	0
f	0
cc	3
eloc	13
nc	3
nop	0

<?php

declare(strict_types=1);

/*
 * The MIT License (MIT)
 *
 * Copyright (c) 2014-2017 Spomky-Labs
 *
 * This software may be modified and distributed under the terms
 * of the MIT license.  See the LICENSE file for details.
 */

namespace Jose\Bundle\KeyManagement\DependencyInjection\Source;

use Jose\Bundle\JoseFramework\DependencyInjection\Source\SourceInterface;
use Jose\Bundle\KeyManagement\DependencyInjection\Source\JWKSource\JWKSourceInterface;
use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
use Symfony\Component\Config\FileLocator;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Loader\YamlFileLoader;

/**
 * Class JWKSource.
 */
final class JWKSource implements SourceInterface
{
    /**
     * @var null|JWKSourceInterface[]
     */
    private $jwkSources = null;

    /**
     * {@inheritdoc}
     */
    public function name(): string
    {
        return 'keys';
    }

    /**
     * {@inheritdoc}
     */
    public function createService(array $config, ContainerBuilder $container)
    {
        $sources = $this->getJWKSources();

        foreach ($config as $name => $itemConfig) {
            foreach ($itemConfig as $sourceName => $sourceConfig) {
                if (array_key_exists($sourceName, $sources)) {
                    $source = $sources[$sourceName];
                    $source->create($container, 'key', $sourceName, $sourceConfig);
                } else {
                    throw new \LogicException(sprintf('The JWK definition "%s" is not configured.', $name));
                }
            }
        }
    }

    /**
     * {@inheritdoc}
     */
    public function getNodeDefinition(ArrayNodeDefinition $node)
    {
        $sourceNodeBuilder = $node
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            ->children()
                ->arrayNode('keys')
                    ->useAttributeAsKey('name')
                    ->prototype('array')
                        ->performNoDeepMerging()
                        ->children();
        foreach ($this->getJWKSources() as $name => $source) {
            $sourceNode = $sourceNodeBuilder->arrayNode($name)->canBeUnset();
            $source->addConfiguration($sourceNode);
        }
    }

    /**
     * {@inheritdoc}
     */
    public function prepend(ContainerBuilder $container, array $config): ?array
    {
        return null;
    }

    /**
     * @return JWKSourceInterface[]
     */
    private function getJWKSources(): array
    {
        if (null !== $this->jwkSources) {
            return $this->jwkSources;
        }

        // load bundled adapter factories
        $tempContainer = new ContainerBuilder();
        $loader = new YamlFileLoader($tempContainer, new FileLocator(__DIR__.'/../../Resources/config'));
        $loader->load('jwk_sources.yml');
        $services = $tempContainer->findTaggedServiceIds('jose.jwk_source');
        $jwkSources = [];
        foreach (array_keys($services) as $id) {
            $factory = $tempContainer->get($id);
            $jwkSources[str_replace('-', '_', $factory->getKey())] = $factory;
        }

        $this->jwkSources = $jwkSources;

        return $jwkSources;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* The MIT License (MIT)
7			*
8			* Copyright (c) 2014-2017 Spomky-Labs
9			*
10			* This software may be modified and distributed under the terms
11			* of the MIT license. See the LICENSE file for details.
12			*/
13
14			namespace Jose\Bundle\KeyManagement\DependencyInjection\Source;
15
16			use Jose\Bundle\JoseFramework\DependencyInjection\Source\SourceInterface;
17			use Jose\Bundle\KeyManagement\DependencyInjection\Source\JWKSource\JWKSourceInterface;
18			use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
19			use Symfony\Component\Config\FileLocator;
20			use Symfony\Component\DependencyInjection\ContainerBuilder;
21			use Symfony\Component\DependencyInjection\Loader\YamlFileLoader;
22
23			/**
24			* Class JWKSource.
25			*/
26			final class JWKSource implements SourceInterface
27			{
28			/**
29			* @var null\|JWKSourceInterface[]
30			*/
31			private $jwkSources = null;
32
33			/**
34			* {@inheritdoc}
35			*/
36			public function name(): string
37			{
38			return 'keys';
39			}
40
41			/**
42			* {@inheritdoc}
43			*/
44			public function createService(array $config, ContainerBuilder $container)
45			{
46			$sources = $this->getJWKSources();
47
48			foreach ($config as $name => $itemConfig) {
49			foreach ($itemConfig as $sourceName => $sourceConfig) {
50			if (array_key_exists($sourceName, $sources)) {
51			$source = $sources[$sourceName];
52			$source->create($container, 'key', $sourceName, $sourceConfig);
53			} else {
54			throw new \LogicException(sprintf('The JWK definition "%s" is not configured.', $name));
55			}
56			}
57			}
58			}
59
60			/**
61			* {@inheritdoc}
62			*/
63			public function getNodeDefinition(ArrayNodeDefinition $node)
64			{
65			$sourceNodeBuilder = $node
			0 ignored issues – show Bug introduced 2017-10-06 14:35 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Symfony\Component\Config...\Builder\NodeDefinition` as the method `performNoDeepMerging()` does only exist in the following sub-classes of `Symfony\Component\Config...\Builder\NodeDefinition`: `Symfony\Component\Config...der\ArrayNodeDefinition`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
66			->children()
67			->arrayNode('keys')
68			->useAttributeAsKey('name')
69			->prototype('array')
70			->performNoDeepMerging()
71			->children();
72			foreach ($this->getJWKSources() as $name => $source) {
73			$sourceNode = $sourceNodeBuilder->arrayNode($name)->canBeUnset();
74			$source->addConfiguration($sourceNode);
75			}
76			}
77
78			/**
79			* {@inheritdoc}
80			*/
81			public function prepend(ContainerBuilder $container, array $config): ?array
82			{
83			return null;
84			}
85
86			/**
87			* @return JWKSourceInterface[]
88			*/
89			private function getJWKSources(): array
90			{
91			if (null !== $this->jwkSources) {
92			return $this->jwkSources;
93			}
94
95			// load bundled adapter factories
96			$tempContainer = new ContainerBuilder();
97			$loader = new YamlFileLoader($tempContainer, new FileLocator(__DIR__.'/../../Resources/config'));
98			$loader->load('jwk_sources.yml');
99			$services = $tempContainer->findTaggedServiceIds('jose.jwk_source');
100			$jwkSources = [];
101			foreach (array_keys($services) as $id) {
102			$factory = $tempContainer->get($id);
103			$jwkSources[str_replace('-', '_', $factory->getKey())] = $factory;
104			}
105
106			$this->jwkSources = $jwkSources;
107
108			return $jwkSources;
109			}
110			}
111

web-token / jwt-framework

Push — master ( d9377e...587e80 )

JWKSource::getJWKSources() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like