Issues in JWSLoader.php - All Issues - Inspection of "Merge pull request #213 from web-token/v2.1" - web-token/jwt-framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7b61ef...71e756 )

by Florent

created 2019-09-11 10:45 UTC

src/Bundle/JoseFramework/Services/JWSLoader.php (2 issues)

Labels

Bug 2

Severity

Major 2

Florent Morselli 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);

/*
 * The MIT License (MIT)
 *
 * Copyright (c) 2014-2019 Spomky-Labs
 *
 * This software may be modified and distributed under the terms
 * of the MIT license.  See the LICENSE file for details.
 */

namespace Jose\Bundle\JoseFramework\Services;

use Jose\Bundle\JoseFramework\Event\JWSLoadingFailureEvent;
use Jose\Bundle\JoseFramework\Event\JWSLoadingSuccessEvent;
use Jose\Component\Checker\HeaderCheckerManager;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Jose\Component\Core\JWKSet;
use Jose\Component\Signature\JWS;
use Jose\Component\Signature\JWSLoader as BaseJWSLoader;
use Jose\Component\Signature\JWSVerifier;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Jose\Component\Signature\Serializer\JWSSerializerManager;
use Psr\EventDispatcher\EventDispatcherInterface;
use Throwable;

final class JWSLoader extends BaseJWSLoader
{
    /**
     * @var EventDispatcherInterface
     */
    private $eventDispatcher;

    public function __construct(JWSSerializerManager $serializerManager, JWSVerifier $jwsVerifier, ?HeaderCheckerManager $headerCheckerManager, EventDispatcherInterface $eventDispatcher)
    {
        parent::__construct($serializerManager, $jwsVerifier, $headerCheckerManager);
        $this->eventDispatcher = $eventDispatcher;
    }

    public function loadAndVerifyWithKeySet(string $token, JWKSet $keyset, ?int &$signature, ?string $payload = null): JWS
    {
        try {
            $jws = parent::loadAndVerifyWithKeySet($token, $keyset, $signature, $payload);
            $this->eventDispatcher->dispatch(new JWSLoadingSuccessEvent(
                $token,
                $jws,
                $keyset,
                $signature
            ));

            return $jws;
        } catch (Throwable $throwable) {
            $this->eventDispatcher->dispatch(new JWSLoadingFailureEvent(
                $token,
                $keyset,
                $throwable
            ));

            throw $throwable;
        }
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* The MIT License (MIT)
7			*
8			* Copyright (c) 2014-2019 Spomky-Labs
9			*
10			* This software may be modified and distributed under the terms
11			* of the MIT license. See the LICENSE file for details.
12			*/
13
14			namespace Jose\Bundle\JoseFramework\Services;
15
16			use Jose\Bundle\JoseFramework\Event\JWSLoadingFailureEvent;
17			use Jose\Bundle\JoseFramework\Event\JWSLoadingSuccessEvent;
18			use Jose\Component\Checker\HeaderCheckerManager;
			0 ignored issues – show Bug introduced 2019-07-11 06:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this This use statement conflicts with another class in this namespace, `Jose\Bundle\JoseFramewor...es\HeaderCheckerManager`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
19			use Jose\Component\Core\JWKSet;
20			use Jose\Component\Signature\JWS;
21			use Jose\Component\Signature\JWSLoader as BaseJWSLoader;
22			use Jose\Component\Signature\JWSVerifier;
			0 ignored issues – show Bug introduced 2019-07-11 06:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this This use statement conflicts with another class in this namespace, `Jose\Bundle\JoseFramework\Services\JWSVerifier`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
23			use Jose\Component\Signature\Serializer\JWSSerializerManager;
24			use Psr\EventDispatcher\EventDispatcherInterface;
25			use Throwable;
26
27			final class JWSLoader extends BaseJWSLoader
28			{
29			/**
30			* @var EventDispatcherInterface
31			*/
32			private $eventDispatcher;
33
34			public function __construct(JWSSerializerManager $serializerManager, JWSVerifier $jwsVerifier, ?HeaderCheckerManager $headerCheckerManager, EventDispatcherInterface $eventDispatcher)
35			{
36			parent::__construct($serializerManager, $jwsVerifier, $headerCheckerManager);
37			$this->eventDispatcher = $eventDispatcher;
38			}
39
40			public function loadAndVerifyWithKeySet(string $token, JWKSet $keyset, ?int &$signature, ?string $payload = null): JWS
41			{
42			try {
43			$jws = parent::loadAndVerifyWithKeySet($token, $keyset, $signature, $payload);
44			$this->eventDispatcher->dispatch(new JWSLoadingSuccessEvent(
45			$token,
46			$jws,
47			$keyset,
48			$signature
49			));
50
51			return $jws;
52			} catch (Throwable $throwable) {
53			$this->eventDispatcher->dispatch(new JWSLoadingFailureEvent(
54			$token,
55			$keyset,
56			$throwable
57			));
58
59			throw $throwable;
60			}
61			}
62			}
63

web-token / jwt-framework

Push — master ( 7b61ef...71e756 )

src/Bundle/JoseFramework/Services/JWSLoader.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like