WebComplete\mvc\router\Router::dispatch()

Complexity

Conditions	6
Paths	6

Size

Total Lines	24
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function dispatch(string $method, string $uri): Route
    {
        $route = null;
        $dispatcher = $this->configureDispatcher();
        $routeInfo = $dispatcher->dispatch($method, $uri);
        switch ($routeInfo[0]) {
            case Dispatcher::NOT_FOUND:
                throw new NotFoundException('Route not found');
                break;
            case Dispatcher::METHOD_NOT_ALLOWED:
                throw new NotAllowedException('Route not allowed');
                break;
            case Dispatcher::FOUND:
                if (!isset($routeInfo[1][0])) {
                    throw new Exception('Controller class name expected');
                }
                if (!isset($routeInfo[1][1])) {
                    throw new Exception('Action method name expected');
                }
                $route = new Route($routeInfo[1][0], $routeInfo[1][1], $routeInfo[2]);
                break;
        }

        return $route;

The expression return $route could return the type null which is incompatible with the type-hinted return WebComplete\mvc\router\Route. Consider adding an additional type-check to rule them out.

    }