| Total Complexity | 61 |
| Total Lines | 334 |
| Duplicated Lines | 0 % |
| Changes | 0 | ||
Complex classes like AbstractForm often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use AbstractForm, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 5 | abstract class AbstractForm |
||
| 6 | { |
||
| 7 | const REQUIRED = 'required'; |
||
| 8 | |||
| 9 | protected $data = []; |
||
| 10 | protected $errors = []; |
||
| 11 | protected $defaultError = 'error'; |
||
| 12 | protected $filtersObject; |
||
| 13 | protected $validatorsObject; |
||
| 14 | private $rules; |
||
| 15 | private $filters; |
||
| 16 | |||
| 17 | /** |
||
| 18 | * AbstractForm constructor. |
||
| 19 | * |
||
| 20 | * @param null|array $rules |
||
| 21 | * @param null|array $filters |
||
| 22 | * @param $filtersObject |
||
| 23 | * @param $validatorsObject |
||
| 24 | */ |
||
| 25 | public function __construct($rules = null, $filters = null, $validatorsObject = null, $filtersObject = null) |
||
| 26 | { |
||
| 27 | if (is_object($filtersObject)) { |
||
| 28 | $this->filtersObject = $filtersObject; |
||
| 29 | } |
||
| 30 | if (is_object($validatorsObject)) { |
||
| 31 | $this->validatorsObject = $validatorsObject; |
||
| 32 | } |
||
| 33 | |||
| 34 | $this->rules = is_array($rules) ? array_merge($this->rules(), $rules) : $this->rules(); |
||
| 35 | |||
| 36 | $this->filters = is_array($filters) ? array_merge($this->filters(), $filters) : $this->filters(); |
||
| 37 | } |
||
| 38 | |||
| 39 | /** |
||
| 40 | * @return array [[field, validator, params, message], ...] |
||
| 41 | * |
||
| 42 | * validator - is a string equals to method of ValidatorsObject, method of the form or callable. |
||
| 43 | * Validator should be declared as ($value, $params) : bool |
||
| 44 | * @see \WebComplete\form\Validators |
||
| 45 | * |
||
| 46 | * required - is an internal validator, checks the field is not empty |
||
| 47 | * * (asterisk) - rule for all fields (declared in rules or filter) |
||
| 48 | * |
||
| 49 | * example |
||
| 50 | * ``` |
||
| 51 | * [ |
||
| 52 | * [['name', 'email'], 'required', [], 'Field is required'], |
||
| 53 | * ['name', 'string', ['min' => 2, 'max' => 50], 'Incorrect name'], |
||
| 54 | * ['email', 'email', [], 'Incorrect email'], |
||
| 55 | * [['description', 'label']], // safe fields |
||
| 56 | * ['price', 'methodValidator', [], 'Incorrect'], |
||
| 57 | * ['some', [SomeValidator::class, 'method'], ['customParam' => 100], 'Incorrect'], |
||
| 58 | * [['*'], 'regex', ['pattern' => '/^[a-z]$/'], 'Field is required'], |
||
| 59 | * ] |
||
| 60 | * ``` |
||
| 61 | */ |
||
| 62 | abstract protected function rules(): array; |
||
| 63 | |||
| 64 | /** |
||
| 65 | * @return array [[field, filter, params], ...] |
||
| 66 | * |
||
| 67 | * filter - is a string equals to method of FiltersObject, method of the form or callable |
||
| 68 | * Filter should be declared as ($value, $params) : mixed, and return filtered value |
||
| 69 | * @see \WebComplete\form\Filters |
||
| 70 | * |
||
| 71 | * * (asterisk) - rule for all fields (declared in rules or filter) |
||
| 72 | * |
||
| 73 | * example |
||
| 74 | * ``` |
||
| 75 | * [ |
||
| 76 | * [['first_name', 'last_name'], 'capitalize'], |
||
| 77 | * ['description', 'stripTags'], |
||
| 78 | * ['content', 'stripJs'], |
||
| 79 | * ['email', 'replace', ['pattern' => 'email.com', 'to' => 'gmail.com']], |
||
| 80 | * ['*', 'trim'], |
||
| 81 | * ] |
||
| 82 | * ``` |
||
| 83 | * |
||
| 84 | */ |
||
| 85 | abstract protected function filters(): array; |
||
| 86 | |||
| 87 | /** |
||
| 88 | * @return bool |
||
| 89 | * @throws \WebComplete\form\FormException |
||
| 90 | */ |
||
| 91 | public function validate(): bool |
||
| 92 | { |
||
| 93 | /** @var array[] $definitions */ |
||
| 94 | $definitions = $this->normalize($this->rules); |
||
| 95 | |||
| 96 | $this->resetErrors(); |
||
| 97 | foreach ($definitions as $field => $fieldDefinitions) { |
||
| 98 | foreach ($fieldDefinitions as $definition) { |
||
| 99 | if ($definition[0] === self::REQUIRED && $this->isEmpty($this->getValue($field))) { |
||
| 100 | $this->addError($field, $definition[3] ?? $this->defaultError); |
||
| 101 | } |
||
| 102 | } |
||
| 103 | } |
||
| 104 | foreach ($this->getData() as $field => $value) { |
||
| 105 | if (isset($definitions[$field])) { |
||
| 106 | foreach ($definitions[$field] as $definition) { |
||
| 107 | $defName = array_shift($definition); |
||
| 108 | $defParams = array_merge([$value], [array_shift($definition)], [$this]); |
||
| 109 | $defMessage = array_shift($definition) ?: $this->defaultError; |
||
| 110 | |||
| 111 | if ($defName !== self::REQUIRED && !$this->isEmpty($value) |
||
| 112 | && !$this->call($defName, $defParams, $this->validatorsObject, true)) { |
||
| 113 | $this->addError($field, $defMessage); |
||
| 114 | } |
||
| 115 | } |
||
| 116 | } |
||
| 117 | } |
||
| 118 | |||
| 119 | return !$this->hasErrors(); |
||
| 120 | } |
||
| 121 | |||
| 122 | /** |
||
| 123 | * @return array |
||
| 124 | */ |
||
| 125 | public function getData(): array |
||
| 126 | { |
||
| 127 | return $this->data; |
||
| 128 | } |
||
| 129 | |||
| 130 | /** |
||
| 131 | * @param array $data |
||
| 132 | * |
||
| 133 | * @return $this |
||
| 134 | * @throws \WebComplete\form\FormException |
||
| 135 | */ |
||
| 136 | public function setData(array $data) |
||
| 141 | } |
||
| 142 | |||
| 143 | /** |
||
| 144 | * @param $field |
||
| 145 | * |
||
| 146 | * @return mixed|null |
||
| 147 | */ |
||
| 148 | public function getValue($field) |
||
| 151 | } |
||
| 152 | |||
| 153 | /** |
||
| 154 | * @param $field |
||
| 155 | * @param $value |
||
| 156 | * @param bool $filter |
||
| 157 | * |
||
| 158 | * @throws \WebComplete\form\FormException |
||
| 159 | */ |
||
| 160 | public function setValue($field, $value, $filter = true): void |
||
| 161 | { |
||
| 162 | if ($filter) { |
||
| 163 | $data = $this->filter([$field => $value]); |
||
| 164 | $value = $data[$field] ?? null; |
||
| 165 | } |
||
| 166 | $this->data[$field] = $value; |
||
| 167 | } |
||
| 168 | |||
| 169 | /** |
||
| 170 | * @param string $field |
||
| 171 | */ |
||
| 172 | public function resetErrors($field = null): void |
||
| 173 | { |
||
| 174 | if ($field) { |
||
|
|
|||
| 175 | unset($this->errors[$field]); |
||
| 176 | } else { |
||
| 177 | $this->errors = []; |
||
| 178 | } |
||
| 179 | } |
||
| 180 | |||
| 181 | /** |
||
| 182 | * @param $field |
||
| 183 | * @param $error |
||
| 184 | */ |
||
| 185 | public function addError($field, $error): void |
||
| 186 | { |
||
| 187 | if (!isset($this->errors[$field])) { |
||
| 188 | $this->errors[$field] = []; |
||
| 189 | } |
||
| 190 | $this->errors[$field][] = $error; |
||
| 191 | } |
||
| 192 | |||
| 193 | /** |
||
| 194 | * @param string|null $field |
||
| 195 | * |
||
| 196 | * @return bool |
||
| 197 | */ |
||
| 198 | public function hasErrors($field = null): bool |
||
| 199 | { |
||
| 200 | return count($this->getErrors($field)) > 0; |
||
| 201 | } |
||
| 202 | |||
| 203 | /** |
||
| 204 | * @param string|null $field |
||
| 205 | * |
||
| 206 | * @return array |
||
| 207 | */ |
||
| 208 | public function getErrors($field = null): array |
||
| 215 | } |
||
| 216 | |||
| 217 | /** |
||
| 218 | * @return array |
||
| 219 | */ |
||
| 220 | public function getFirstErrors(): array |
||
| 230 | } |
||
| 231 | |||
| 232 | /** |
||
| 233 | * @param $field |
||
| 234 | * |
||
| 235 | * @return string|null |
||
| 236 | */ |
||
| 237 | public function getFirstError($field): ?string |
||
| 238 | { |
||
| 239 | return isset($this->errors[$field]) && $this->errors[$field] ? reset($this->errors[$field]) : null; |
||
| 240 | } |
||
| 241 | |||
| 242 | /** |
||
| 243 | * @param array $data |
||
| 244 | * |
||
| 245 | * @return array |
||
| 246 | * @throws \WebComplete\form\FormException |
||
| 247 | */ |
||
| 248 | protected function filter(array $data): array |
||
| 249 | { |
||
| 250 | $filtersDefinitions = $this->normalize($this->filters); |
||
| 251 | $rulesDefinitions = $this->normalize($this->rules); |
||
| 252 | |||
| 253 | foreach ($data as $field => $value) { |
||
| 254 | if (!isset($rulesDefinitions[$field]) && !isset($filtersDefinitions[$field])) { |
||
| 255 | unset($data[$field]); |
||
| 256 | continue; |
||
| 257 | } |
||
| 258 | |||
| 259 | $fieldDefinitions = $filtersDefinitions[$field] ?? []; |
||
| 260 | if (isset($filtersDefinitions['*'])) { |
||
| 261 | $fieldDefinitions = array_merge($fieldDefinitions, $filtersDefinitions['*']); |
||
| 262 | } |
||
| 263 | |||
| 264 | foreach ($fieldDefinitions as $definition) { |
||
| 265 | $defName = array_shift($definition); |
||
| 266 | $defParams = array_merge([$value], [array_shift($definition)], [$this]); |
||
| 267 | $data[$field] = $this->call($defName, $defParams, $this->filtersObject, $value); |
||
| 268 | } |
||
| 269 | } |
||
| 270 | |||
| 271 | return $data; |
||
| 272 | } |
||
| 273 | |||
| 274 | /** |
||
| 275 | * @param $value |
||
| 276 | * |
||
| 277 | * @return bool |
||
| 278 | */ |
||
| 279 | protected function isEmpty($value): bool |
||
| 280 | { |
||
| 281 | return $value === null || $value === '' || (is_array($value) && !count($value)); |
||
| 282 | } |
||
| 283 | |||
| 284 | /** |
||
| 285 | * @param $definitions |
||
| 286 | * |
||
| 287 | * @return array |
||
| 288 | */ |
||
| 289 | private function normalize($definitions): array |
||
| 310 | } |
||
| 311 | |||
| 312 | /** |
||
| 313 | * @param $defName |
||
| 314 | * @param $defParams |
||
| 315 | * @param $object |
||
| 316 | * @param $default |
||
| 317 | * |
||
| 318 | * @return mixed|null |
||
| 319 | * @throws FormException |
||
| 320 | */ |
||
| 321 | private function call($defName, $defParams, $object, $default) |
||
| 341 |
In PHP, under loose comparison (like
==, or!=, orswitchconditions), values of different types might be equal.For
stringvalues, the empty string''is a special case, in particular the following results might be unexpected: