Issues in Translates.php (master) - Issues in master - weareneopix/laravel-model-translation - Measure and Improve Code Quality continuously with Scrutinizer

Issues (17)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Translates.php (9 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace WeAreNeopix\LaravelModelTranslation;

use Illuminate\Support\Facades\App;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Builder;
use Illuminate\Database\Eloquent\SoftDeletes;

trait Translates
{
	/**
	 * The language the model is currently loaded in.
	 *
	 * @var string
	 */
	protected $selectedLanguage;

	/**
	 * Array of the model's attributes that should be translated.
	 *
	 * @var array
	 */
	// protected $translatable = [];

	/**
	 * Array that holds the translated values while saving is performed.
	 *
	 * @var array
	 */
	protected $translatedAttributes = [];

	/**
	 * Returns the Model identifier used for storing translations in combination with the instance identifier.
	 *
	 * @return string
	 */
	public function getModelIdentifier(): string
	{
		return static::class;
	}

	/**
	 * Returns the instance identifier used for storing translations in combination with the model identifier.
	 *
	 * @return string
	 */
	public function getInstanceIdentifier(): string
	{
		return (string) $this->getKey();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
	}

	/**
	 * Returns the attribute name of the instance identifier.
	 *
	 * @return string
	 */
	protected function getInstanceIdentifierName(): string
	{
		return (string) $this->getKeyName();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
	}

	/**
	 * Set the $translatable array effectively changing which attributes are translatable.
	 * It is highly recommended you avoid using this method, unless absolutely necessary.
	 *
	 * @param array $translatable
	 * @return self
	 */
	public function setTranslatable(array $translatable): self
	{
		$this->translatable = $translatable;
class MyClass { }

$x = new MyClass();
$x->foo = true;

		return $this;
	}

	/**
	 * Return all the translatable attribute names or only the ones present in the first argument.
	 *
	 * @param array $only
	 * @return array
	 */
	public function getTranslatable(array $only = []): array
	{
		return (empty($only))
			? $this->translatable
			: array_intersect($this->translatable, $only);
	}

	/**
	 * Set the current language on the instance.
	 * Automatically loads the language if it hasn't been loaded previously.
	 *
	 * @param  string $language
	 * @return self
	 */
	public function setLanguage(string $language): self
	{
		$this->selectedLanguage = $language;

		// We load the language automatically to avoid interferences between languages
		$this->loadLanguage($language);

		return $this;
	}

	/**
	 * Checks if a language has been previously loaded and is present in the $loadedLanguages array.
	 *
	 * @param  string $language
	 * @return bool
	 */
	public function languageLoaded(string $language): bool
	{
		return $this->selectedLanguage == $language;
	}

	/**
	 * Load a language and store it in the $loadedLanguages array.
	 *
	 * @param  string $language
	 * @return self
	 */
	public function loadLanguage(string $language): array
	{
		$translations = Translation::getTranslationsForModel($this, $language);
		$this->setTranslations($translations);

		return $translations;
	}

	/**
	 * Set the provided data as a loaded language.
	 *
	 * @param  array $translations
	 * @return self
	 */
	public function setTranslations(array $translations): self
	{
		/*
		 * We perform this translation in order to ensure
		 * that even the translations that aren't present
		 * get overridden within the attributes array
		 */
		$translations = collect($this->translatable)->mapWithKeys(
		function ($attribute) use ($translations) {
			$translation = $translations[$attribute] ?? null;

			return [
				$attribute => $translation,
			];
		}
	)->toArray();

		$this->attributes = array_merge($this->attributes, $translations);


		return $this;
	}

	/**
	 * Reload only the languages that have already been loaded.
	 *
	 * @return self
	 */
	public function reloadTranslations(): self
	{
		$language = $this->getActiveLanguage();

		$this->loadLanguage($language);

		return $this;
	}

	/**
	 * Return the currently used language. Defaults to the app locale if $selectedLanguage is null.
	 *
	 * @return string
	 */
	public function getActiveLanguage(): string
	{
		return $this->selectedLanguage ?? App::getLocale();
	}

	/**
	 * Override Laravel's refresh() method to refresh the translations as well.
	 *
	 * @return self
	 */
	public function refresh(): self
	{
		parent::refresh();

		$this->reloadTranslations();

		return $this;
	}

	/**
	 * Override Laravel's getAttribute() method to check if the requested attribute is translatable.
	 * If the attribute is translatable and the language not loaded, it will load the language.
	 *
	 * @return mixed
	 */
	public function getAttribute($attribute)
	{
		$activeLanguage = $this->getActiveLanguage();

		if ($this->attributeIsTranslatable($attribute) && ! $this->languageLoaded($activeLanguage)) {
			$this->loadLanguage($activeLanguage);
		}

		return parent::getAttribute($attribute);
	}

	/**
	 * Checks whether an attribute is translatable.
	 *
	 * @return bool
	 */
	public function attributeIsTranslatable($attribute)
	{
		return in_array($attribute, $this->translatable);
	}

	/**
	 * Persist the translations using the loaded TranslationDriver.
	 *
	 * @return void
	 */
	protected function persistTranslations()
	{
		Translation::patchTranslationsForModel($this, $this->getActiveLanguage(), $this->translatedAttributes);
	}

	/**
	 * Merge the translated attributes with the translated ones.
	 *
	 * @return void
	 */
	protected function mergeTranslationsWithAttributes()
	{
		$this->attributes = array_merge($this->attributes, $this->translatedAttributes);

	}

	/**
	 * Separate the translatable attribute values from the $attributes array.
	 *
	 * @return array
	 */
	public function separateTranslationsFromAttributes(): array
	{
		$attributes = collect($this->attributes);


		// Extract the translated values
		$translatables = $attributes->only($this->translatable);
		$this->translatedAttributes = $translatables->toArray();

		// Keep only the non-translatable attributes
		$this->attributes = $attributes->forget($this->translatable)->toArray();


		return $this->translatedAttributes;
	}

	/**
	 * Remove all translations from the persistent storage.
	 * This is called after the model is deleted.
	 *
	 * @param  string $language
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
	 * @return bool
	 */
	public function deleteTranslations(...$languages): bool
	{
		if (empty($languages)) {
			return Translation::deleteAllTranslationsForModel($this);
		}

		return Translation::deleteLanguagesForModel($this, $languages);
	}

	/**
	 * Check if the class uses the SoftDeletes trait.
	 *
	 * @return bool
	 */
	protected function usesSoftDelete(): bool
	{
		return in_array(SoftDeletes::class, class_uses_recursive(static::class));
	}

	/**
	 * Register model event listeners which ensure that the translatable attributes are synced
	 * when the model is being saved, deleted or restored.
	 */
	public static function bootTranslates()
	{
		static::saving(
			function (Model $model) {
				$model->separateTranslationsFromAttributes();
			}
		);

		// We have to persist the translations after the model has been saved
		// to avoid the case when saving a new model which doesn't exist prior to saving.
		static::saved(
			function (Model $model) {
				$model->persistTranslations();

				$model->mergeTranslationsWithAttributes();
			}
		);

		static::deleted(
			function (Model $model) {
				if ($model->usesSoftDelete() && ! $model->forceDeleting) {
					return true;
				}
				$model->deleteTranslations();
			}
		);
	}

	/**
	 * We make an accessor for this in order to make it possible to add it to the $appends model property.
	 *
	 * @return array
	 */
	public function getAvailableLanguagesAttribute()
	{
		return Translation::getAvailableLanguagesForModel($this);
	}

	/**
	 * We make an accessor for this in order to make it possible to add it to the $appends model property.
	 *
	 * @return string
	 */
	public function getSelectedLanguageAttribute()
	{
		return $this->getActiveLanguage();
	}

	/**
	 * Constrain a query to Models Models available in the provided language.
	 *
	 * @param \Illuminate\Database\Eloquent\Builder $query
	 * @param string $language
	 * @return \Illuminate\Database\Eloquent\Builder
	 */
	public function scopeInLanguage(Builder $query, string $language)
	{
		$availableModelIds = Translation::getModelsAvailableInLanguage($this->getModelIdentifier(), $language);
		$constraint = $this->getTable().'.'.$this->getInstanceIdentifierName();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

		return $query->whereIn($constraint, $availableModelIds);
	}
}


GitHub Access Token became invalid

Issues (17)

Security Analysis not enabled

src/Translates.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1			<?php
2
3			namespace WeAreNeopix\LaravelModelTranslation;
4
5			use Illuminate\Support\Facades\App;
6			use Illuminate\Database\Eloquent\Model;
7			use Illuminate\Database\Eloquent\Builder;
8			use Illuminate\Database\Eloquent\SoftDeletes;
9
10			trait Translates
11			{
12			/**
13			* The language the model is currently loaded in.
14			*
15			* @var string
16			*/
17			protected $selectedLanguage;
18
19			/**
20			* Array of the model's attributes that should be translated.
21			*
22			* @var array
23			*/
24			// protected $translatable = [];
25
26			/**
27			* Array that holds the translated values while saving is performed.
28			*
29			* @var array
30			*/
31			protected $translatedAttributes = [];
32
33			/**
34			* Returns the Model identifier used for storing translations in combination with the instance identifier.
35			*
36			* @return string
37			*/
38			public function getModelIdentifier(): string
39			{
40			return static::class;
41			}
42
43			/**
44			* Returns the instance identifier used for storing translations in combination with the model identifier.
45			*
46			* @return string
47			*/
48			public function getInstanceIdentifier(): string
49			{
50			return (string) $this->getKey();
			0 ignored issues – show Bug introduced 2019-03-05 15:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `getKey()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
51			}
52
53			/**
54			* Returns the attribute name of the instance identifier.
55			*
56			* @return string
57			*/
58			protected function getInstanceIdentifierName(): string
59			{
60			return (string) $this->getKeyName();
			0 ignored issues – show Bug introduced 2019-03-05 15:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `getKeyName()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
61			}
62
63			/**
64			* Set the $translatable array effectively changing which attributes are translatable.
65			* It is highly recommended you avoid using this method, unless absolutely necessary.
66			*
67			* @param array $translatable
68			* @return self
69			*/
70			public function setTranslatable(array $translatable): self
71			{
72			$this->translatable = $translatable;
			0 ignored issues – show Bug introduced 2019-03-05 15:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `translatable` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
73
74			return $this;
75			}
76
77			/**
78			* Return all the translatable attribute names or only the ones present in the first argument.
79			*
80			* @param array $only
81			* @return array
82			*/
83			public function getTranslatable(array $only = []): array
84			{
85			return (empty($only))
86			? $this->translatable
87			: array_intersect($this->translatable, $only);
88			}
89
90			/**
91			* Set the current language on the instance.
92			* Automatically loads the language if it hasn't been loaded previously.
93			*
94			* @param string $language
95			* @return self
96			*/
97			public function setLanguage(string $language): self
98			{
99			$this->selectedLanguage = $language;
100
101			// We load the language automatically to avoid interferences between languages
102			$this->loadLanguage($language);
103
104			return $this;
105			}
106
107			/**
108			* Checks if a language has been previously loaded and is present in the $loadedLanguages array.
109			*
110			* @param string $language
111			* @return bool
112			*/
113			public function languageLoaded(string $language): bool
114			{
115			return $this->selectedLanguage == $language;
116			}
117
118			/**
119			* Load a language and store it in the $loadedLanguages array.
120			*
121			* @param string $language
122			* @return self
123			*/
124			public function loadLanguage(string $language): array
125			{
126			$translations = Translation::getTranslationsForModel($this, $language);
127			$this->setTranslations($translations);
128
129			return $translations;
130			}
131
132			/**
133			* Set the provided data as a loaded language.
134			*
135			* @param array $translations
136			* @return self
137			*/
138			public function setTranslations(array $translations): self
139			{
140			/*
141			* We perform this translation in order to ensure
142			* that even the translations that aren't present
143			* get overridden within the attributes array
144			*/
145			$translations = collect($this->translatable)->mapWithKeys(
146			function ($attribute) use ($translations) {
147			$translation = $translations[$attribute] ?? null;
148
149			return [
150			$attribute => $translation,
151			];
152			}
153			)->toArray();
154
155			$this->attributes = array_merge($this->attributes, $translations);
			0 ignored issues – show Bug introduced 2019-03-05 15:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `attributes` does not seem to exist. Did you mean `translatedAttributes`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
156
157			return $this;
158			}
159
160			/**
161			* Reload only the languages that have already been loaded.
162			*
163			* @return self
164			*/
165			public function reloadTranslations(): self
166			{
167			$language = $this->getActiveLanguage();
168
169			$this->loadLanguage($language);
170
171			return $this;
172			}
173
174			/**
175			* Return the currently used language. Defaults to the app locale if $selectedLanguage is null.
176			*
177			* @return string
178			*/
179			public function getActiveLanguage(): string
180			{
181			return $this->selectedLanguage ?? App::getLocale();
182			}
183
184			/**
185			* Override Laravel's refresh() method to refresh the translations as well.
186			*
187			* @return self
188			*/
189			public function refresh(): self
190			{
191			parent::refresh();
192
193			$this->reloadTranslations();
194
195			return $this;
196			}
197
198			/**
199			* Override Laravel's getAttribute() method to check if the requested attribute is translatable.
200			* If the attribute is translatable and the language not loaded, it will load the language.
201			*
202			* @return mixed
203			*/
204			public function getAttribute($attribute)
205			{
206			$activeLanguage = $this->getActiveLanguage();
207
208			if ($this->attributeIsTranslatable($attribute) && ! $this->languageLoaded($activeLanguage)) {
209			$this->loadLanguage($activeLanguage);
210			}
211
212			return parent::getAttribute($attribute);
213			}
214
215			/**
216			* Checks whether an attribute is translatable.
217			*
218			* @return bool
219			*/
220			public function attributeIsTranslatable($attribute)
221			{
222			return in_array($attribute, $this->translatable);
223			}
224
225			/**
226			* Persist the translations using the loaded TranslationDriver.
227			*
228			* @return void
229			*/
230			protected function persistTranslations()
231			{
232			Translation::patchTranslationsForModel($this, $this->getActiveLanguage(), $this->translatedAttributes);
233			}
234
235			/**
236			* Merge the translated attributes with the translated ones.
237			*
238			* @return void
239			*/
240			protected function mergeTranslationsWithAttributes()
241			{
242			$this->attributes = array_merge($this->attributes, $this->translatedAttributes);
			0 ignored issues – show Bug introduced 2019-03-05 15:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `attributes` does not seem to exist. Did you mean `translatedAttributes`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
243			}
244
245			/**
246			* Separate the translatable attribute values from the $attributes array.
247			*
248			* @return array
249			*/
250			public function separateTranslationsFromAttributes(): array
251			{
252			$attributes = collect($this->attributes);
			0 ignored issues – show Bug introduced 2019-03-05 15:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `attributes` does not seem to exist. Did you mean `translatedAttributes`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
253
254			// Extract the translated values
255			$translatables = $attributes->only($this->translatable);
256			$this->translatedAttributes = $translatables->toArray();
257
258			// Keep only the non-translatable attributes
259			$this->attributes = $attributes->forget($this->translatable)->toArray();
			0 ignored issues – show Bug introduced 2019-03-05 15:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `attributes` does not seem to exist. Did you mean `translatedAttributes`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
260
261			return $this->translatedAttributes;
262			}
263
264			/**
265			* Remove all translations from the persistent storage.
266			* This is called after the model is deleted.
267			*
268			* @param string $language
			0 ignored issues – show Documentation introduced 2019-03-05 15:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$language`. Did you maybe mean `$languages`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
269			* @return bool
270			*/
271			public function deleteTranslations(...$languages): bool
272			{
273			if (empty($languages)) {
274			return Translation::deleteAllTranslationsForModel($this);
275			}
276
277			return Translation::deleteLanguagesForModel($this, $languages);
278			}
279
280			/**
281			* Check if the class uses the SoftDeletes trait.
282			*
283			* @return bool
284			*/
285			protected function usesSoftDelete(): bool
286			{
287			return in_array(SoftDeletes::class, class_uses_recursive(static::class));
288			}
289
290			/**
291			* Register model event listeners which ensure that the translatable attributes are synced
292			* when the model is being saved, deleted or restored.
293			*/
294			public static function bootTranslates()
295			{
296			static::saving(
297			function (Model $model) {
298			$model->separateTranslationsFromAttributes();
299			}
300			);
301
302			// We have to persist the translations after the model has been saved
303			// to avoid the case when saving a new model which doesn't exist prior to saving.
304			static::saved(
305			function (Model $model) {
306			$model->persistTranslations();
307
308			$model->mergeTranslationsWithAttributes();
309			}
310			);
311
312			static::deleted(
313			function (Model $model) {
314			if ($model->usesSoftDelete() && ! $model->forceDeleting) {
315			return true;
316			}
317			$model->deleteTranslations();
318			}
319			);
320			}
321
322			/**
323			* We make an accessor for this in order to make it possible to add it to the $appends model property.
324			*
325			* @return array
326			*/
327			public function getAvailableLanguagesAttribute()
328			{
329			return Translation::getAvailableLanguagesForModel($this);
330			}
331
332			/**
333			* We make an accessor for this in order to make it possible to add it to the $appends model property.
334			*
335			* @return string
336			*/
337			public function getSelectedLanguageAttribute()
338			{
339			return $this->getActiveLanguage();
340			}
341
342			/**
343			* Constrain a query to Models Models available in the provided language.
344			*
345			* @param \Illuminate\Database\Eloquent\Builder $query
346			* @param string $language
347			* @return \Illuminate\Database\Eloquent\Builder
348			*/
349			public function scopeInLanguage(Builder $query, string $language)
350			{
351			$availableModelIds = Translation::getModelsAvailableInLanguage($this->getModelIdentifier(), $language);
352			$constraint = $this->getTable().'.'.$this->getInstanceIdentifierName();
			0 ignored issues – show Bug introduced 2019-03-05 15:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `getTable()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
353
354			return $query->whereIn($constraint, $availableModelIds);
355			}
356			}
357

weareneopix / laravel-model-translation

GitHub Access Token became invalid

Issues (17)

Security Analysis not enabled

src/Translates.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like