wearebraid / shorten

app/Middleware/Api.php

<?php

namespace App\Middleware;

use App\Models\Redirect;

This use statement conflicts with another class in this namespace, App\Middleware\Redirect. Consider defining an alias.

use Zend\Diactoros\Response\JsonResponse;
use Psr\Http\Message\ServerRequestInterface;
use Interop\Http\ServerMiddleware\DelegateInterface;
use Interop\Http\ServerMiddleware\MiddlewareInterface;

class Api implements MiddlewareInterface
{
    /**
     * The request object.
     *
     * @var Psr\Http\Message\ServerRequestInterface

The type App\Middleware\Psr\Http\Message\ServerRequestInterface was not found. Did you mean Psr\Http\Message\ServerRequestInterface? If so, make sure to prefix the type with \.

     */
    protected $request;
    /**
     * Return the current request.
     *
     * @return Psr\Http\Message\ServerRequestInterface
     */
    public function getRequest()
    {
        return $this->request;
    }

    /**
     * Set the current request object.
     *
     * @return void
     */
    public function setRequest(ServerRequestInterface $request)
    {
        $route = strtoupper($request->getMethod()) . ' ' . strtolower($request->getUri()->getPath());
        $this->request = $request->withAttribute('route', $route);

It seems like $request->withAttribute('route', $route) of type Psr\Http\Message\ServerRequestInterface is incompatible with the declared type App\Middleware\Psr\Http\Message\ServerRequestInterface of property $request.

    }

    /**
     * Checks if the current request is an authorized api request.
     *
     * @return boolean
     */
    public function isApi()
    {
        $this->request = $this->request->withAttribute('isApi', !!$this->request->getHeaderLine('Authorization'));
        return $this->request->getAttribute('isApi');
    }

    /**
     * Check if the current request is authorized for api access.
     *
     * @return boolean
     */
    public function isAuthorized()
    {
        $auth = substr($this->request->getHeaderLine('Authorization'), 7);
        return $this->request->getAttribute('config')['api_secret'] === $auth;
    }

    /**
     * List all redirects.
     *
     * @return void
     */
    public function show()
    {
        return new JsonResponse(Redirect::orderBy('created_at', 'DESC')->get());

The expression return new Zend\Diactoros\Response\JsonResponse(App\Models\Redirect::orderBy('created_at', 'DESC')->get()) returns the type Zend\Diactoros\Response\JsonResponse which is incompatible with the documented return type void.

    }

    /**
     * Create a new redirect.
     *
     * @return App\Models\Create

The type App\Middleware\App\Models\Create was not found. Maybe you did not declare it correctly or list all dependencies?

     */
    public function create()
    {
        $body = $this->request->getAttribute('body');
        if (isset($body['url'])) {
            return new JsonResponse(Redirect::createUnique($body['url']));

The expression return new Zend\Diactoros\Response\JsonResponse(App\Models\Redirect::createUnique($body['url'])) returns the type Zend\Diactoros\Response\JsonResponse which is incompatible with the documented return type App\Middleware\App\Models\Create.

        }
        return new JsonResponse([

The expression return new Zend\Diactoros\Response\JsonResponse(array('message' => 'Request must include json body with url property.'), 400) returns the type Zend\Diactoros\Response\JsonResponse which is incompatible with the documented return type App\Middleware\App\Models\Create.

            'message' => 'Request must include json body with url property.'
        ], 400);
    }

    /**
     * Respond to the api request.
     *
     * @return Zend\Diactoros\Response\JsonResponse

The type App\Middleware\Zend\Diactoros\Response\JsonResponse was not found. Did you mean Zend\Diactoros\Response\JsonResponse? If so, make sure to prefix the type with \.

     */
    public function response()
    {
        if ($this->isAuthorized()) {
            switch ($this->request->getAttribute('route')) {
                case "GET /redirects":
                    return $this->show();

The expression return $this->show() returns the type void which is incompatible with the documented return type App\Middleware\Zend\Diactoros\Response\JsonResponse.

Are you sure the usage of $this->show() targeting App\Middleware\Api::show() seems to always return null.

                case "POST /redirects":
                    return $this->create();
                default:
                    return new JsonResponse(['status' => 'No such api endpoint'], 404);

The expression return new Zend\Diactoros\Response\JsonResponse(array('status' => 'No such api endpoint'), 404) returns the type Zend\Diactoros\Response\JsonResponse which is incompatible with the documented return type App\Middleware\Zend\Diactoros\Response\JsonResponse.

            }
        }
        return new JsonResponse(['message' => 'Not authorized'], 403);

The expression return new Zend\Diactoros\Response\JsonResponse(array('message' => 'Not authorized'), 403) returns the type Zend\Diactoros\Response\JsonResponse which is incompatible with the documented return type App\Middleware\Zend\Diactoros\Response\JsonResponse.

    }

    /**
     * PSR-15 middleware callback
     *
     * @param ServerRequestInterface $request
     * @param DelegateInterface $delegate
     * @return Psr\Http\Message\ServerRequestInterface
     */
    public function process(ServerRequestInterface $request, DelegateInterface $delegate)
    {
        $this->setRequest($request);
        return ($this->isApi()) ? $this->response() : $delegate->process($this->getRequest());

The expression return $this->isApi() ? $this->response() : $delegate->process($this->getRequest()) also could return the type Psr\Http\Message\ResponseInterface which is incompatible with the documented return type App\Middleware\Psr\Http\Message\ServerRequestInterface.

    }
}