App\Models\Redirect

Complexity

Total Complexity

3

Size/Duplication

Total Lines	54
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getUrlAttribute()	0	3	1
A	createUnique()	0	8	2

<?php

namespace App\Models;

use Illuminate\Database\Eloquent\Model;

class Redirect extends Model
{
    /**
     * Allow these attributes to be filled.
     *
     * @var array
     */
    protected $fillable = [
        'hash',
        'redirect_to',
    ];

    /**
     * The url attribute of a particular.
     *
     * @var array
     */
    protected $appends = [
        'url'
    ];

    /**
     * Hide unnecessary or private fields.
     *
     * @return array
     */
    protected $hidden = [
        'created_at',
        'updated_at'
    ];

    /**
     * Get the url attribute.
     *
     * @return void
     */
    public function getUrlAttribute()
    {
        return config()['base_url'] . '/' . $this->hash;

The expression return config()['base_url'] . '/' . $this->hash returns the type string which is incompatible with the documented return type void.

The property hash does not seem to exist on App\Models\Redirect. Are you sure there is no database migration missing?

    }

    /**
     * Creates an absolutely unique hash for a given url.
     *
     * @return void
     */
    public static function createUnique($url)
    {
        do {
            $hash = bin2hex(openssl_random_pseudo_bytes(4));
        } while (static::where('hash', $hash)->first());
        return static::create([

The expression return static::create(array('hash' => $hash, 'redirect_to' => $url)) returns the type App\Models\Redirect which is incompatible with the documented return type void.

            'hash' => $hash,
            'redirect_to' => $url
        ]);
    }
}