Issues in Packager.php (master) - Issues in master - wapmorgan/php-rpm-packager - Measure and Improve Code Quality continuously with Scrutinizer

Issues (28)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Packager.php (28 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace wapmorgan\rpm;

use PharData;
use DirectoryIterator;

class Packager {
    private $_spec;
    private $mountPoints = array();
    private $outputPath;

    /**
     * Set the control file
     *
     * This file contains the base package information
     *
     * @param Spec $spec
     * @return \wapmorgan\rpm\Spec
     */
    public function setSpec(Spec $spec)
    {
        $this->_spec = $spec;
        return $this;
    }

    /**
     * Return the actual spec file
     *
     * @return Spec
     */
    public function getSpec()
    {
        return $this->_spec;
    }

    public function setOutputPath($path) {
        $this->outputPath = $path;
        return $this;
    }

    public function getOutputPath() {
        return $this->outputPath;
    }

    public function addMount($sourcePath, $destinationPath) {
        $this->mountPoints[$sourcePath] = $destinationPath;
        return $this;
    }

    public function movePackage($dest) {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
        return rename($_SERVER['HOME'].'/rpmbuild/RPMS/'.$this->_spec->BuildArch.'/'.$this->_spec->Name.'-'.$this->_spec->Version.'-'.$this->_spec->Release.'.'.$this->_spec->BuildArch.'.rpm', $dest);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function run() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
        if (!is_dir($_SERVER['HOME'].'/rpmbuild/SOURCES'))

            mkdir($_SERVER['HOME'].'/rpmbuild/SOURCES', 0777);
        if (!is_dir($_SERVER['HOME'].'/rpmbuild/SPECS'))

            mkdir($_SERVER['HOME'].'/rpmbuild/SPECS', 0777);

        if (file_exists($this->getOutputPath())) {
            $iterator = new DirectoryIterator($this->getOutputPath());
            foreach ($iterator as $path) {
                if ($path != '.' && $path != '..') {
                    echo "OUTPUT DIRECTORY MUST BE EMPTY! Something exists, exit immediately!" . PHP_EOL;
                    exit();

                }
            }
        }

        if (!is_dir($this->getOutputPath()))
            mkdir($this->getOutputPath(), 0777);

        foreach ($this->mountPoints as $path => $dest) {
            $this->pathToPath($path, $this->getOutputPath().DIRECTORY_SEPARATOR.$dest);
        }

        $spec = $this->_spec;
        $spec->setPrep('%autosetup -c package');
        $install_section = 'rm -rf %{buildroot}'."\n".'mkdir -p %{buildroot}'."\n".'cp -rp * %{buildroot}';
        $spec->setInstall($install_section);

        $files_section = null;
        foreach ($this->mountPoints as $sourcePath => $destinationPath) {
            if (is_dir($sourcePath)) {
                $files_section .= (strlen($files_section) > 0 ? "\n" : null).rtrim($destinationPath, '/').'/';
            } else {
                $files_section .= (strlen($files_section) > 0 ? "\n" : null).'%attr('.substr(sprintf('%o', fileperms($sourcePath)), -4).',root,root) '.$destinationPath;
            }
        }

        $spec->setFiles($files_section);
        // $used_dirs = array();

        // foreach ($this->mountPoints as $source => $dest) {

        //     if (is_dir($source)) {

        //         $files[] = $dest;

        //     } else {

        //         $dir = dirname($dest);

        //         // directory exists on a real machine - add files one by one
        //         if (is_dir($dir)) {

        //             $files[] = $dest;

        //         } else { // add all files within directory

        //             if (!in_array($dir, $files)) {

        //                 $files[] = $dir;

        //             }
        //         }
        //     }
        // }
        // $spec->setFiles(implode("\n", $files));


        if (file_exists($_SERVER['HOME'].'/rpmbuild/SOURCES/'.$this->_spec->Name.'.tar')) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            unlink($_SERVER['HOME'].'/rpmbuild/SOURCES/'.$this->_spec->Name.'.tar');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
        $tar = new PharData($_SERVER['HOME'].'/rpmbuild/SOURCES/'.$this->_spec->Name.'.tar');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $tar->buildFromDirectory($this->outputPath);
        $spec->setKey('Source0', $this->_spec->Name.'.tar');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        file_put_contents($_SERVER['HOME'].'/rpmbuild/SPECS/'.$this->_spec->Name.'.spec', (string)$this->_spec);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        return $this;
    }

    public function build() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
        $command = 'rpmbuild -bb '.$_SERVER['HOME'].'/rpmbuild/SPECS/'.$this->_spec->Name.'.spec';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        return $command;
    }

    private function pathToPath($path, $dest) {
        if (is_dir($path)) {
            $iterator = new DirectoryIterator($path);
            foreach ($iterator as $element) {
                if ($element != '.' && $element != '..') {
                    $fullPath = $path . DIRECTORY_SEPARATOR . $element;
                    if (is_dir($fullPath)) {
                        $this->pathToPath($fullPath, $dest . DIRECTORY_SEPARATOR . $element);
                    } else {
                        $this->copy($fullPath, $dest . DIRECTORY_SEPARATOR . $element);
                    }
                }
            }
        } else if (is_file($path)) {
            $this->copy($path, $dest);
        }
    }

    private function copy($source, $dest) {
        $destFolder = dirname($dest);
        if (!file_exists($destFolder)) {
            mkdir($destFolder, 0777, true);
        }
        copy($source, $dest);
        if (fileperms($source) != fileperms($dest))
            chmod($dest, fileperms($source));
    }
}

1		<?php
2		namespace wapmorgan\rpm;
3
4		use PharData;
5		use DirectoryIterator;
6
7		class Packager {
8		private $_spec;
9		private $mountPoints = array();
10		private $outputPath;
11
12		/**
13		* Set the control file
14		*
15		* This file contains the base package information
16		*
17		* @param Spec $spec
18		* @return \wapmorgan\rpm\Spec
19		*/
20		public function setSpec(Spec $spec)
21		{
22		$this->_spec = $spec;
23		return $this;
24		}
25
26		/**
27		* Return the actual spec file
28		*
29		* @return Spec
30		*/
31		public function getSpec()
32		{
33		return $this->_spec;
34		}
35
36		public function setOutputPath($path) {
37		$this->outputPath = $path;
38		return $this;
39		}
40
41		public function getOutputPath() {
42		return $this->outputPath;
43		}
44
45		public function addMount($sourcePath, $destinationPath) {
46		$this->mountPoints[$sourcePath] = $destinationPath;
47		return $this;
48		}
49
50		public function movePackage($dest) {
		0 ignored issues – show Coding Style introduced 2018-02-13 21:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this `movePackage` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
51		return rename($_SERVER['HOME'].'/rpmbuild/RPMS/'.$this->_spec->BuildArch.'/'.$this->_spec->Name.'-'.$this->_spec->Version.'-'.$this->_spec->Release.'.'.$this->_spec->BuildArch.'.rpm', $dest);
		0 ignored issues – show Documentation introduced 2016-03-25 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `BuildArch` does not exist on `object<wapmorgan\rpm\Spec>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2016-03-25 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `Name` does not exist on `object<wapmorgan\rpm\Spec>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2016-03-25 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `Version` does not exist on `object<wapmorgan\rpm\Spec>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2016-03-25 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `Release` does not exist on `object<wapmorgan\rpm\Spec>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
52		}
53
54		public function run() {
		0 ignored issues – show Coding Style introduced 2018-02-13 21:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this `run` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
55	View Code Duplication	if (!is_dir($_SERVER['HOME'].'/rpmbuild/SOURCES'))
		0 ignored issues – show Duplication introduced 2016-03-25 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
56		mkdir($_SERVER['HOME'].'/rpmbuild/SOURCES', 0777);
57	View Code Duplication	if (!is_dir($_SERVER['HOME'].'/rpmbuild/SPECS'))
		0 ignored issues – show Duplication introduced 2016-03-25 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
58		mkdir($_SERVER['HOME'].'/rpmbuild/SPECS', 0777);
59
60		if (file_exists($this->getOutputPath())) {
61		$iterator = new DirectoryIterator($this->getOutputPath());
62		foreach ($iterator as $path) {
63		if ($path != '.' && $path != '..') {
64		echo "OUTPUT DIRECTORY MUST BE EMPTY! Something exists, exit immediately!" . PHP_EOL;
65		exit();
		0 ignored issues – show Coding Style Compatibility introduced 2016-03-25 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `run()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
66		}
67		}
68		}
69
70		if (!is_dir($this->getOutputPath()))
71		mkdir($this->getOutputPath(), 0777);
72
73		foreach ($this->mountPoints as $path => $dest) {
74		$this->pathToPath($path, $this->getOutputPath().DIRECTORY_SEPARATOR.$dest);
75		}
76
77		$spec = $this->_spec;
78		$spec->setPrep('%autosetup -c package');
79		$install_section = 'rm -rf %{buildroot}'."\n".'mkdir -p %{buildroot}'."\n".'cp -rp * %{buildroot}';
80		$spec->setInstall($install_section);
81
82		$files_section = null;
83		foreach ($this->mountPoints as $sourcePath => $destinationPath) {
84		if (is_dir($sourcePath)) {
85		$files_section .= (strlen($files_section) > 0 ? "\n" : null).rtrim($destinationPath, '/').'/';
86		} else {
87		$files_section .= (strlen($files_section) > 0 ? "\n" : null).'%attr('.substr(sprintf('%o', fileperms($sourcePath)), -4).',root,root) '.$destinationPath;
88		}
89		}
90
91		$spec->setFiles($files_section);
92		// $used_dirs = array();
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-25 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this `56%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
93		// foreach ($this->mountPoints as $source => $dest) {
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-25 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this `56%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
94		// if (is_dir($source)) {
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-25 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this `64%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
95		// $files[] = $dest;
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-25 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this `56%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
96		// } else {
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-25 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
97		// $dir = dirname($dest);
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-25 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
98		// // directory exists on a real machine - add files one by one
99		// if (is_dir($dir)) {
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-25 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this `64%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
100		// $files[] = $dest;
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-25 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this `56%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
101		// } else { // add all files within directory
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-25 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this `43%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
102		// if (!in_array($dir, $files)) {
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-25 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
103		// $files[] = $dir;
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-25 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this `56%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
104		// }
105		// }
106		// }
107		// }
108		// $spec->setFiles(implode("\n", $files));
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-25 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this `72%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
109
110		if (file_exists($_SERVER['HOME'].'/rpmbuild/SOURCES/'.$this->_spec->Name.'.tar')) {
		0 ignored issues – show Documentation introduced 2016-03-25 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `Name` does not exist on `object<wapmorgan\rpm\Spec>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
111		unlink($_SERVER['HOME'].'/rpmbuild/SOURCES/'.$this->_spec->Name.'.tar');
		0 ignored issues – show Documentation introduced 2016-03-25 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `Name` does not exist on `object<wapmorgan\rpm\Spec>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
112		}
113		$tar = new PharData($_SERVER['HOME'].'/rpmbuild/SOURCES/'.$this->_spec->Name.'.tar');
		0 ignored issues – show Documentation introduced 2016-03-25 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `Name` does not exist on `object<wapmorgan\rpm\Spec>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
114		$tar->buildFromDirectory($this->outputPath);
115		$spec->setKey('Source0', $this->_spec->Name.'.tar');
		0 ignored issues – show Documentation introduced 2016-03-25 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `Name` does not exist on `object<wapmorgan\rpm\Spec>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
116
117		file_put_contents($_SERVER['HOME'].'/rpmbuild/SPECS/'.$this->_spec->Name.'.spec', (string)$this->_spec);
		0 ignored issues – show Documentation introduced 2016-03-25 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `Name` does not exist on `object<wapmorgan\rpm\Spec>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
118
119		return $this;
120		}
121
122		public function build() {
		0 ignored issues – show Coding Style introduced 2018-02-13 21:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this `build` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
123		$command = 'rpmbuild -bb '.$_SERVER['HOME'].'/rpmbuild/SPECS/'.$this->_spec->Name.'.spec';
		0 ignored issues – show Documentation introduced 2016-03-25 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `Name` does not exist on `object<wapmorgan\rpm\Spec>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
124		return $command;
125		}
126
127		private function pathToPath($path, $dest) {
128		if (is_dir($path)) {
129		$iterator = new DirectoryIterator($path);
130		foreach ($iterator as $element) {
131		if ($element != '.' && $element != '..') {
132		$fullPath = $path . DIRECTORY_SEPARATOR . $element;
133		if (is_dir($fullPath)) {
134		$this->pathToPath($fullPath, $dest . DIRECTORY_SEPARATOR . $element);
135		} else {
136		$this->copy($fullPath, $dest . DIRECTORY_SEPARATOR . $element);
137		}
138		}
139		}
140		} else if (is_file($path)) {
141		$this->copy($path, $dest);
142		}
143		}
144
145		private function copy($source, $dest) {
146		$destFolder = dirname($dest);
147		if (!file_exists($destFolder)) {
148		mkdir($destFolder, 0777, true);
149		}
150		copy($source, $dest);
151		if (fileperms($source) != fileperms($dest))
152		chmod($dest, fileperms($source));
153		}
154		}

wapmorgan / php-rpm-packager

Issues (28)

Security Analysis no request data

src/Packager.php (28 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like