wapmorgan / UnifiedArchive

src/Commands/ExtractFilesCommand.php

<?php

namespace wapmorgan\UnifiedArchive\Commands;

use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

class ExtractFilesCommand extends BaseArchiveCommand
{
    protected static $defaultName = 'files:extract';

    protected function configure()
    {
        parent::configure();
        $this
            ->setDescription('Extracts archive contents by selector')
            ->setHelp('Extracts all archive contents by selector.')
            ->addArgument('outputDir', InputArgument::REQUIRED, 'Folder to extract contents')
            ->addArgument('entrySelector', InputArgument::OPTIONAL, 'Prefix of entry selector. Default is null, means root of archive')
        ;
    }

    public function execute(InputInterface $input, OutputInterface $output)
    {
        $output_dir = $input->getArgument('outputDir');
        if (!is_dir($output_dir)) {

It seems like $output_dir can also be of type null and string[]; however, parameter $filename of is_dir() does only seem to accept string, maybe add an additional type check?

            mkdir($output_dir, 0777, true);

It seems like $output_dir can also be of type null and string[]; however, parameter $directory of mkdir() does only seem to accept string, maybe add an additional type check?

        } else if (!is_writable($output_dir)) {

It seems like $output_dir can also be of type null and string[]; however, parameter $filename of is_writable() does only seem to accept string, maybe add an additional type check?

            chmod($output_dir, 0777);

It seems like $output_dir can also be of type null and string[]; however, parameter $filename of chmod() does only seem to accept string, maybe add an additional type check?

        }
        $archive = $this->getArchive($input, $output);
        $entry_selector = $input->getArgument('entrySelector');

        $archive->extract($output_dir, $entry_selector, true);

It seems like $output_dir can also be of type string[]; however, parameter $outputFolder of wapmorgan\UnifiedArchive\UnifiedArchive::extract() does only seem to accept string, maybe add an additional type check?

        $output->writeln('<info>Extracted:</info> ' . implode(', ', $entry_selector) . ' (' . count($entry_selector) . ') file(s)');

        return 0;
    }
}