wapmorgan / UnifiedArchive

src/Commands/ExtractArchiveCommand.php

<?php

namespace wapmorgan\UnifiedArchive\Commands;

use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

class ExtractArchiveCommand extends BaseArchiveCommand
{
    protected static $defaultName = 'archive:extract';

    protected function configure()
    {
        parent::configure();
        $this
            ->setDescription('Extracts all archive contents and overwrites existing files')
            ->setHelp('Extracts all archive contents and overwrites existing files.')
            ->addArgument('outputDir', InputArgument::REQUIRED, 'Folder to extract contents')
        ;
    }

    public function execute(InputInterface $input, OutputInterface $output)
    {
        $output_dir = $input->getArgument('outputDir');
        if (!is_dir($output_dir)) {

It seems like $output_dir can also be of type null and string[]; however, parameter $filename of is_dir() does only seem to accept string, maybe add an additional type check?

            mkdir($output_dir, 0777, true);

It seems like $output_dir can also be of type null and string[]; however, parameter $directory of mkdir() does only seem to accept string, maybe add an additional type check?

        } else if (!is_writable($output_dir)) {

It seems like $output_dir can also be of type null and string[]; however, parameter $filename of is_writable() does only seem to accept string, maybe add an additional type check?

            chmod($output_dir, 0777);

It seems like $output_dir can also be of type null and string[]; however, parameter $filename of chmod() does only seem to accept string, maybe add an additional type check?

        }
        $archive = $this->getArchive($input, $output);

        if (disk_free_space($output_dir) < $archive->getOriginalSize()) {

It seems like $output_dir can also be of type null and string[]; however, parameter $directory of disk_free_space() does only seem to accept string, maybe add an additional type check?

            throw new \LogicException('Archive size ' . implode($this->formatSize($archive->getOriginalSize())) . ' is more that available on disk '
                                      . implode($this->formatSize(disk_free_space($output_dir))));
        }
        $archive->extract($output_dir, $entry_selector, true);

It seems like $output_dir can also be of type string[]; however, parameter $outputFolder of wapmorgan\UnifiedArchive\UnifiedArchive::extract() does only seem to accept string, maybe add an additional type check?

        $output->writeln('<info>Extracted all archive contents (' . implode($this->formatSize($archive->getOriginalSize())) . ')</info>');

        return 0;
    }
}