wapmorgan / UnifiedArchive

src/Commands/CommentCommand.php

<?php

namespace wapmorgan\UnifiedArchive\Commands;

use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

class CommentCommand extends BaseArchiveCommand
{
    protected static $defaultName = 'archive:comment';

    protected function configure()
    {
        parent::configure();
        $this
            ->setDescription('Sets comment on archive')
            ->setHelp('Sets comment on archive.')
            ->addArgument('comment', InputArgument::REQUIRED, 'Comment')
        ;
    }

    public function execute(InputInterface $input, OutputInterface $output)
    {
        $archive = $this->getArchive($input, $output);
        $comment = $input->getArgument('comment');
        if (empty($comment)) {
            $comment = null;
        }

        if (!empty($previous_comment = $archive->getComment())) {

Are you sure the assignment to $previous_comment is correct as $archive->getComment() targeting wapmorgan\UnifiedArchive\UnifiedArchive::getComment() seems to always return null.

            $output->writeln('Comment "' . $previous_comment . '" replaced', OutputInterface::OUTPUT_RAW);
        } else if ($comment === null) {
            $output->writeln('Comment deleted', OutputInterface::OUTPUT_RAW);
        } else {
            $output->writeln('Comment set', OutputInterface::OUTPUT_RAW);
        }

        $archive->setComment($comment);

It seems like $comment can also be of type string[]; however, parameter $comment of wapmorgan\UnifiedArchive\UnifiedArchive::setComment() does only seem to accept null|string, maybe add an additional type check?

        return 0;
    }
}