wapmorgan / UnifiedArchive

src/Commands/BaseArchiveCommand.php

<?php

namespace wapmorgan\UnifiedArchive\Commands;

use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;
use wapmorgan\UnifiedArchive\Abilities;
use wapmorgan\UnifiedArchive\Drivers\Basic\BasicDriver;
use wapmorgan\UnifiedArchive\Formats;

class BaseArchiveCommand extends BaseCommand
{
    protected function configure()
    {
        parent::configure();
        $this
            ->addArgument('archive', InputArgument::REQUIRED, 'Archive file')
            ->addOption('password', null, InputOption::VALUE_REQUIRED, 'Password for archive')
        ;
    }

    /**
     * @param InputInterface $input
     * @param OutputInterface $output
     * @return \wapmorgan\UnifiedArchive\UnifiedArchive
     * @throws \Exception
     */
    protected function getArchive(InputInterface $input, OutputInterface $output)
    {
        $file = realpath($input->getArgument('archive'));

It seems like $input->getArgument('archive') can also be of type null and string[]; however, parameter $path of realpath() does only seem to accept string, maybe add an additional type check?

        $output->writeln('<comment>Opening ' . $file . '</comment>', OutputInterface::VERBOSITY_VERY_VERBOSE);
        if (!is_file($file)) {
            throw new \InvalidArgumentException('File ' . $input->getArgument('archive') . ' is not accessible');

Are you sure $input->getArgument('archive') of type null|string|string[] can be used in concatenation?

        }
        $output->writeln('<comment>Format ' . Formats::detectArchiveFormat($file) . '</comment>', OutputInterface::VERBOSITY_VERY_VERBOSE);
        $password = $input->getOption('password');
        if (empty($password)) {
            $password = null;
        } else {
            $output->writeln('<comment>Passing password: ' . strlen($password).'</comment>', OutputInterface::VERBOSITY_VERY_VERBOSE);
        }
        $archive = $this->open($file, $password);
        $output->writeln('<comment>Driver ' . $archive->getDriverType() . '</comment>', OutputInterface::VERBOSITY_VERBOSE);
        $output->writeln('<comment>Driver abilities: ' . implode(', ', $this->getDriverFormatAbilities($archive->getDriverType(), $archive->getFormat())) . '</comment>', OutputInterface::VERBOSITY_VERBOSE);

$archive->getDriverType() of type string is incompatible with the type wapmorgan\UnifiedArchive\Drivers\Basic\BasicDriver expected by parameter $driver of wapmorgan\UnifiedArchive\Commands\BaseArchiveCommand::getDriverFormatAbilities().

        return $archive;
    }

    /**
     * @param BasicDriver $driver
     * @param $format
     * @return array
     */
    protected function getDriverFormatAbilities($driver, $format)
    {
        $abilities = $driver::getFormatAbilities($format);
        return array_keys(array_intersect(Abilities::$abilitiesLabels, $abilities));
    }
}