wapmorgan / UnifiedArchive

src/PclZipInterface.php

Braces +99 added lines, -57 removed lines

@@ -142,8 +142,11 @@ 
      */
     public function create($content)
     {
-        if (is_array($content)) $paths_list = $content;
-        else $paths_list = explode(',', $content);
+        if (is_array($content)) {
+         $paths_list = $content;
+        } else {
+         $paths_list = explode(',', $content);
+        }
 
         $options = $this->makeOptionsFromArguments(func_get_args());
 
@@ -151,8 +154,9 @@ 
         $filters = $this->createFilters($options);
         list($preAddCallback, $postAddCallback) = $this->extractCallbacks($options, PCLZIP_CB_PRE_ADD, PCLZIP_CB_POST_ADD);
 
-        if (!empty($comment = $this->buildComment($options, null)))
-            $this->archive->setComment($comment);
+        if (!empty($comment = $this->buildComment($options, null))) {
+                    $this->archive->setComment($comment);
+        }
 
         // scan filesystem for files list
         return $this->addSnippets($paths_list, $filters, $preAddCallback, $postAddCallback);
@@ -172,16 +176,18 @@ 
             $localname = $fileToAdd;
             $filename = $fileToAdd;
 
-            foreach ($filters as $filter)
-                call_user_func($filter, $localname, $filename);
+            foreach ($filters as $filter) {
+                            call_user_func($filter, $localname, $filename);
+            }
 
             $file_header = $this->createFileHeader($localname, $filename);
             if (call_user_func($preAddCallback, $file_header) == 1) {
                 //
                 // Check for max length > 255
                 //
-                if (strlen(basename($file_header->stored_filename)) > 255)
-                    $file_header->status = 'filename_too_long';
+                if (strlen(basename($file_header->stored_filename)) > 255) {
+                                    $file_header->status = 'filename_too_long';
+                }
                 if (is_file($filename)) {
                     $this->archive->add([
                         $file_header->stored_filename => $file_header->filename,
@@ -253,27 +259,35 @@ 
         }
 
         // filters initiation
-        if (isset($options[PCLZIP_OPT_PATH]))
-            $extractPath = rtrim($options[PCLZIP_OPT_PATH], '/');
-        else $extractPath = rtrim(getcwd(), '/');
+        if (isset($options[PCLZIP_OPT_PATH])) {
+                    $extractPath = rtrim($options[PCLZIP_OPT_PATH], '/');
+        } else {
+         $extractPath = rtrim(getcwd(), '/');
+        }
 
         $filters = $this->createFilters($options);
         list($preExtractCallback, $postExtractCallback) = $this->extractCallbacks($options, PCLZIP_CB_PRE_EXTRACT, PCLZIP_CB_POST_EXTRACT);
         $selectFilter = $this->createSelector($options);
 
-        if (isset($options[PCLZIP_OPT_EXTRACT_AS_STRING]))
-            $anotherOutputFormat = PCLZIP_OPT_EXTRACT_AS_STRING;
-        else if (isset($options[PCLZIP_OPT_EXTRACT_IN_OUTPUT]))
-            $anotherOutputFormat = PCLZIP_OPT_EXTRACT_IN_OUTPUT;
-        else $anotherOutputFormat = false;
+        if (isset($options[PCLZIP_OPT_EXTRACT_AS_STRING])) {
+                    $anotherOutputFormat = PCLZIP_OPT_EXTRACT_AS_STRING;
+        } else if (isset($options[PCLZIP_OPT_EXTRACT_IN_OUTPUT])) {
+                    $anotherOutputFormat = PCLZIP_OPT_EXTRACT_IN_OUTPUT;
+        } else {
+         $anotherOutputFormat = false;
+        }
 
-        if (isset($options[PCLZIP_OPT_REPLACE_NEWER]))
-            $doNotReplaceNewer = false;
-        else $doNotReplaceNewer = true;
+        if (isset($options[PCLZIP_OPT_REPLACE_NEWER])) {
+                    $doNotReplaceNewer = false;
+        } else {
+         $doNotReplaceNewer = true;
+        }
 
-        if (isset($options[PCLZIP_OPT_EXTRACT_DIR_RESTRICTION]))
-            $restrictExtractDir = $options[PCLZIP_OPT_EXTRACT_DIR_RESTRICTION];
-        else $restrictExtractDir = false;
+        if (isset($options[PCLZIP_OPT_EXTRACT_DIR_RESTRICTION])) {
+                    $restrictExtractDir = $options[PCLZIP_OPT_EXTRACT_DIR_RESTRICTION];
+        } else {
+         $restrictExtractDir = false;
+        }
 
         $report = array();
         foreach ($this->listContent() as $file_header) {
@@ -344,8 +358,10 @@ 
             // extract content
             else if ($anotherOutputFormat === false) {
                 // apply path filters
-                foreach ($filters as $filter) call_user_func($filter,
+                foreach ($filters as $filter) {
+                 call_user_func($filter,
                     $file_header->stored_filename, $file_header->filename);
+                }
                 // dir extraction process
                 if ($file_header->folder) {
                     // if dir doesn't exist
@@ -436,15 +452,19 @@ 
      */
     public function add($content)
     {
-        if (is_array($content)) $paths_list = $content;
-        else $paths_list = explode(',', $content);
+        if (is_array($content)) {
+         $paths_list = $content;
+        } else {
+         $paths_list = explode(',', $content);
+        }
 
         $options = $this->makeOptionsFromArguments(func_get_args());
         $filters = $this->createFilters($options);
         list($preAddCallback, $postAddCallback) = $this->extractCallbacks($options, PCLZIP_CB_PRE_ADD, PCLZIP_CB_POST_ADD);
 
-        if (!empty($comment = $this->buildComment($options, $this->archive->getComment())))
-            $this->archive->setComment($comment);
+        if (!empty($comment = $this->buildComment($options, $this->archive->getComment()))) {
+                    $this->archive->setComment($comment);
+        }
 
         // scan filesystem for files list
         return $this->addSnippets($paths_list, $filters, $preAddCallback, $postAddCallback);
@@ -516,8 +536,12 @@ 
         }
 
         $tempDir = tempnam(PCLZIP_TEMPORARY_DIR, 'merging');
-        if (file_exists($tempDir)) unlink($tempDir);
-        if (!mkdir($tempDir)) return 0;
+        if (file_exists($tempDir)) {
+         unlink($tempDir);
+        }
+        if (!mkdir($tempDir)) {
+         return 0;
+        }
 
         // go through archive content list and copy all files
         foreach ($a->getFiles() as $filename) {
@@ -545,8 +569,11 @@ 
 
         call_user_func(function ($directory) {
             foreach (glob($directory.'/*') as $f) {
-                if (is_dir($f)) call_user_func(__FUNCTION__, $f);
-                else unlink($f);
+                if (is_dir($f)) {
+                 call_user_func(__FUNCTION__, $f);
+                } else {
+                 unlink($f);
+                }
             }
         }, $tempDir);
 
@@ -571,18 +598,21 @@ 
     {
         $filters = array();
         if (isset($options[PCLZIP_OPT_REMOVE_PATH])
-            && !isset($options[PCLZIP_OPT_REMOVE_ALL_PATH]))
-            $filters[] = function (&$key, &$value) use ($options) {
+            && !isset($options[PCLZIP_OPT_REMOVE_ALL_PATH])) {
+                    $filters[] = function (&$key, &$value) use ($options) {
                 $key = str_replace($key, null, $key);
+        }
             };
-        if (isset($options[PCLZIP_OPT_REMOVE_ALL_PATH]))
-            $filters[] = function (&$key, &$value) {
+        if (isset($options[PCLZIP_OPT_REMOVE_ALL_PATH])) {
+                    $filters[] = function (&$key, &$value) {
                 $key = basename($key);
+        }
             };
-        if (isset($options[PCLZIP_OPT_ADD_PATH]))
-            $filters[] = function (&$key, &$value) use ($options) {
+        if (isset($options[PCLZIP_OPT_ADD_PATH])) {
+                    $filters[] = function (&$key, &$value) use ($options) {
                 $key = rtrim($options[PCLZIP_OPT_ADD_PATH], '/') . '/' .
                     ltrim($key, '/');
+        }
             };
         return $filters;
     }
@@ -597,11 +627,13 @@ 
     {
         $preCallback = $postCallback = function () { return true; };
 
-        if (isset($options[$preCallbackConst]) && is_callable($options[$preCallbackConst]))
-            $preCallback = $options[$preCallbackConst];
+        if (isset($options[$preCallbackConst]) && is_callable($options[$preCallbackConst])) {
+                    $preCallback = $options[$preCallbackConst];
+        }
 
-        if (isset($options[$postCallbackConst]) && is_callable($options[$postCallbackConst]))
-            $postCallback = $options[$postCallbackConst];
+        if (isset($options[$postCallbackConst]) && is_callable($options[$postCallbackConst])) {
+                    $postCallback = $options[$postCallbackConst];
+        }
 
         return [$preCallback, $postCallback];
     }
@@ -615,7 +647,9 @@ 
         // @todo create version for 5.5 of ARRAY_FILTER_USE_KEY function or drop 5.5 support
         $keys = array_filter($options, function ($v) {return ($v%2) == 0;}, ARRAY_FILTER_USE_KEY);
         $values = array_filter($options, function ($v) {return ($v%2) == 1;}, ARRAY_FILTER_USE_KEY);
-        if (count($values) < count($keys)) $values[] = true;
+        if (count($values) < count($keys)) {
+         $values[] = true;
+        }
         return array_combine($keys, $values);
     }
 
@@ -658,9 +692,12 @@ 
         $allowedIndexes = array();
         foreach ($indexes as $rule) {
             $parts = explode('-', $rule);
-            if (count($parts) == 1) $allowedIndexes[] = $rule;
-            else $allowedIndexes = array_merge(
+            if (count($parts) == 1) {
+             $allowedIndexes[] = $rule;
+            } else {
+             $allowedIndexes = array_merge(
                 range($parts[0], $parts[1]), $allowedIndexes);
+            }
         }
 
         return function ($key, $value, $index) use ($allowedIndexes) {
@@ -735,21 +772,26 @@ 
     protected function createSelector(array $options)
     {
         // exact matching
-        if (isset($options[PCLZIP_OPT_BY_NAME]))
-            $selectFilter = $this->createByNameSelector($options[PCLZIP_OPT_BY_NAME]);
+        if (isset($options[PCLZIP_OPT_BY_NAME])) {
+                    $selectFilter = $this->createByNameSelector($options[PCLZIP_OPT_BY_NAME]);
+        }
         // <ereg> rule
-        else if (isset($options[PCLZIP_OPT_BY_EREG]) && function_exists('ereg'))
-            $selectFilter = $this->createByEregSelector($options[PCLZIP_OPT_BY_EREG]);
+        else if (isset($options[PCLZIP_OPT_BY_EREG]) && function_exists('ereg')) {
+                    $selectFilter = $this->createByEregSelector($options[PCLZIP_OPT_BY_EREG]);
+        }
         // <preg_match> rule
-        else if (isset($options[PCLZIP_OPT_BY_PREG]))
-            $selectFilter = $this->createByPregSelector($options[PCLZIP_OPT_BY_PREG]);
+        else if (isset($options[PCLZIP_OPT_BY_PREG])) {
+                    $selectFilter = $this->createByPregSelector($options[PCLZIP_OPT_BY_PREG]);
+        }
         // index rule
-        else if (isset($options[PCLZIP_OPT_BY_INDEX]))
-            $selectFilter = $this->createByIndexSelector($options[PCLZIP_OPT_BY_INDEX]);
+        else if (isset($options[PCLZIP_OPT_BY_INDEX])) {
+                    $selectFilter = $this->createByIndexSelector($options[PCLZIP_OPT_BY_INDEX]);
+        }
         // no rule
-        else
-            $selectFilter = function () {
+        else {
+                    $selectFilter = function () {
                 return self::SELECT_FILTER_PASS;
+        }
             };
         return $selectFilter;
     }
@@ -785,9 +827,9 @@ 
     protected function buildComment(array $options, $currentComment)
     {
         $comment = null;
-        if (isset($options[PCLZIP_OPT_COMMENT]))
-            $comment = $options[PCLZIP_OPT_COMMENT];
-        else if (isset($options[PCLZIP_OPT_ADD_COMMENT])) {;
+        if (isset($options[PCLZIP_OPT_COMMENT])) {
+                    $comment = $options[PCLZIP_OPT_COMMENT];
+        } else if (isset($options[PCLZIP_OPT_ADD_COMMENT])) {;
             $comment = $currentComment . $options[PCLZIP_OPT_ADD_COMMENT];
         } else if (isset($options[PCLZIP_OPT_PREPEND_COMMENT])) {
             $comment = $options[PCLZIP_OPT_PREPEND_COMMENT] . $currentComment;

src/UnifiedArchive.php

Braces +21 added lines, -15 removed lines

@@ -459,13 +459,15 @@ 
      */
     public function getFiles($filter = null)
     {
-        if ($filter === null)
-            return $this->files;
+        if ($filter === null) {
+                    return $this->files;
+        }
 
         $result = [];
         foreach ($this->files as $file) {
-            if (fnmatch($filter, $file))
-                $result[] = $file;
+            if (fnmatch($filter, $file)) {
+                            $result[] = $file;
+            }
         }
         return $result;
     }
@@ -667,9 +669,9 @@ 
         if (is_array($nodes)) {
             foreach ($nodes as $destination => $source) {
                 // new format
-                if (is_numeric($destination))
-                    $destination = $source;
-                else {
+                if (is_numeric($destination)) {
+                                    $destination = $source;
+                } else {
                     // old format
                     if (is_string($source) && !file_exists($source)) {
                         list($destination, $source) = [$source, $destination];
@@ -728,8 +730,9 @@ 
         // $map[$destination] = rtrim($source, '/*');
         // do not map root archive folder
 
-        if ($destination !== null)
-            $map[$destination] = null;
+        if ($destination !== null) {
+                    $map[$destination] = null;
+        }
 
         foreach (glob($source, GLOB_MARK) as $node) {
             if (in_array(substr($node, -1), ['/', '\\'], true) && $recursive) {
@@ -975,8 +978,9 @@ 
      */
     public static function archiveDirectory($directory, $archiveName, $compressionLevel = BasicDriver::COMPRESSION_AVERAGE, $password = null)
     {
-        if (!is_dir($directory) || !is_readable($directory))
-            throw new InvalidArgumentException($directory . ' is not a valid directory to archive');
+        if (!is_dir($directory) || !is_readable($directory)) {
+                    throw new InvalidArgumentException($directory . ' is not a valid directory to archive');
+        }
 
         return static::create($directory, $archiveName, $compressionLevel, $password) > 0;
     }
@@ -1137,8 +1141,9 @@ 
      */
     public function addFile($file, $inArchiveName = null)
     {
-        if (!is_file($file))
-            throw new InvalidArgumentException($file . ' is not a valid file to add in archive');
+        if (!is_file($file)) {
+                    throw new InvalidArgumentException($file . ' is not a valid file to add in archive');
+        }
 
         return ($inArchiveName !== null
                 ? $this->add([$inArchiveName => $file])
@@ -1158,8 +1163,9 @@ 
      */
     public function addDirectory($directory, $inArchivePath = null)
     {
-        if (!is_dir($directory) || !is_readable($directory))
-            throw new InvalidArgumentException($directory . ' is not a valid directory to add in archive');
+        if (!is_dir($directory) || !is_readable($directory)) {
+                    throw new InvalidArgumentException($directory . ' is not a valid directory to add in archive');
+        }
 
         return ($inArchivePath !== null
                 ? $this->add([$inArchivePath => $directory])

src/Commands/InfoCommand.php

Braces +3 added lines, -2 removed lines

@@ -34,8 +34,9 @@
         $output->writeln("\t". 'uncompressed: '.implode(' ', $this->formatSize($archive->getOriginalSize(), 2)));
         $output->writeln("\t" . 'compressed: ' . implode(' ', $this->formatSize($archive->getCompressedSize(), 2)));
         $output->writeln("\t" . 'ratio: <info>' . round($archive->getOriginalSize() / $archive->getCompressedSize(), 6) . '/1 (' . floor($archive->getCompressedSize() / $archive->getOriginalSize() * 100) . '%</info>)');
-        if ($archive->getDriver()->checkAbility(Abilities::GET_COMMENT) && !empty($comment = $archive->getComment()))
-            $output->writeln('Comment: <comment>' . $comment . '</comment>');
+        if ($archive->getDriver()->checkAbility(Abilities::GET_COMMENT) && !empty($comment = $archive->getComment())) {
+                    $output->writeln('Comment: <comment>' . $comment . '</comment>');
+        }
 
         return 0;
     }