wapmorgan\UnifiedArchive\Commands\InfoCommand

Complexity

Total Complexity

4

Size/Duplication

Total Lines	30
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	execute()	0	14	3
A	configure()	0	6	1

<?php

namespace wapmorgan\UnifiedArchive\Commands;

use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

class InfoCommand extends BaseArchiveCommand
{
    protected static $defaultName = 'archive:info';

    protected function configure()
    {
        parent::configure();
        $this
            ->setDescription('Renders archive info')
            ->setHelp('Renders archive info.')
        ;
    }

    /**
     * @throws \Exception
     */
    public function execute(InputInterface $input, OutputInterface $output)
    {
        $file = realpath($input->getArgument('archive'));

It seems like $input->getArgument('archive') can also be of type null and string[]; however, parameter $path of realpath() does only seem to accept string, maybe add an additional type check?

        $archive = $this->getArchive($input, $output);

        $output->writeln('Filename: ' . $file . ' (changed <comment>' . $this->formatDate(filemtime($file)) . '</comment>)');
        $output->writeln('Type: <info>' . $archive->getFormat() . '</info>, mime <info>' . $archive->getMimeType() . '</info> (via driver <comment>' . $archive->getDriverType() . '</comment>)');
        $output->writeln('Contains: ' . $archive->countFiles() . ' file' . ($archive->countFiles() > 1 ? 's' : null));
        $output->writeln('Size:');
        $output->writeln("\t". 'uncompressed: '.implode(' ', $this->formatSize($archive->getOriginalSize(), 2)));
        $output->writeln("\t" . 'compressed: ' . implode(' ', $this->formatSize($archive->getCompressedSize(), 2)));
        $output->writeln("\t" . 'ratio: <info>' . round($archive->getOriginalSize() / $archive->getCompressedSize(), 6) . '/1 (' . floor($archive->getCompressedSize() / $archive->getOriginalSize() * 100) . '%</info>)');
        if (!empty($comment = $archive->getComment()))

Are you sure the assignment to $comment is correct as $archive->getComment() targeting wapmorgan\UnifiedArchive\UnifiedArchive::getComment() seems to always return null.

            $output->writeln('Comment: <comment>' . $comment . '</comment>');
    }
}