wapmorgan\UnifiedArchive\Commands\CreateCommand::execute()

Complexity

Conditions	25
Paths	148

Size

Total Lines	143
Code Lines	101

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

<?php
    public function execute(InputInterface $input, OutputInterface $output)
    {
        $archive_file = $input->getArgument('archive');
        $files_to_pack = $input->getArgument('file');

        $password = $input->getOption('password');
        $compression = $input->getOption('compression');
        if (!isset(static::$compressionLevels[$compression])) {
            throw new \InvalidArgumentException('Compression "' . $compression . '" is not valid');
        }
        $compression = static::$compressionLevels[$compression];
        $path = $input->getOption('path');
        if (!in_array($path, ['full', 'root', 'relative', 'basename'], true)) {
            throw new \InvalidArgumentException('Path can not have this value');
        }
        $dry_run = $input->getOption('dry-run');
        $comment = $input->getOption('comment');
        $stdout = $input->getOption('stdout');

        if (file_exists($archive_file)) {

It seems like $archive_file can also be of type null and string[]; however, parameter $filename of file_exists() does only seem to accept string, maybe add an additional type check?

            if (is_dir($archive_file))

It seems like $archive_file can also be of type null and string[]; however, parameter $filename of is_dir() does only seem to accept string, maybe add an additional type check?

                throw new \InvalidArgumentException($archive_file . ' is a directory!');

Are you sure $archive_file of type null|string|string[] can be used in concatenation?

            else {
                throw new \InvalidArgumentException('File "' . $archive_file . '" already exists!');
            }
        }

        $files_list = [];

        foreach ($files_to_pack as $i => $file_to_pack) {
            $file_to_pack = realpath($file_to_pack);
            switch ($path) {
                case 'full':
                    $destination = ltrim($file_to_pack, '/');
                    $files_list[$destination] = $file_to_pack;
                    if (!$stdout) {
                        $output->writeln(
                            '<comment>' . $file_to_pack . ' => ' . $destination . '</comment>',
                            OutputInterface::VERBOSITY_VERBOSE
                        );
                    }
                    break;
                case 'root':
                    if (is_dir($file_to_pack)) {
                        if (!$stdout) {
                            $output->writeln(
                                '<comment>' . $file_to_pack . ' => root</comment>',
                                OutputInterface::VERBOSITY_VERBOSE
                            );
                        }
                        if (!isset($files_list[''])) {
                            $files_list[''] = $file_to_pack;
                        } elseif (is_string($files_list[''])) {
                            $files_list[''] = [$files_list[''], $file_to_pack];
                        } else {
                            $files_list[''][] = $file_to_pack;
                        }
                    } else {
                        if (!$stdout) {
                            $output->writeln(
                                '<comment>' . $file_to_pack . ' => ' . basename($file_to_pack) . '</comment>',
                                OutputInterface::VERBOSITY_VERBOSE
                            );
                        }
                        $files_list[basename($file_to_pack)] = $file_to_pack;
                    }
                    break;
                case 'relative':
                    $destination = ltrim($file_to_pack, '/.');
                    $files_list[$destination] = $file_to_pack;
                    if (!$stdout) {
                        $output->writeln(
                            '<comment>' . $file_to_pack . ' => ' . $destination . '</comment>',
                            OutputInterface::VERBOSITY_VERBOSE
                        );
                    }
                    break;
                case 'basename':
                    $destination = basename($file_to_pack);
                    $files_list[$destination] = $file_to_pack;
                    if (!$stdout) {
                        $output->writeln(
                            '<comment>' . $file_to_pack . ' => ' . $destination . '</comment>',
                            OutputInterface::VERBOSITY_VERBOSE
                        );
                    }
                    break;
            }
        }

        $information = UnifiedArchive::prepareForArchiving($files_list, $archive_file);

It seems like $archive_file can also be of type string[]; however, parameter $archiveName of wapmorgan\UnifiedArchive\UnifiedArchive::prepareForArchiving() does only seem to accept null|string, maybe add an additional type check?

        if ($dry_run) {
            $output->writeln('Format: <info>' . $information['type'] . '</info>');
            $output->writeln('Original size: <info>' . implode($this->formatSize($information['totalSize'])) . '</info>');
            $output->writeln('Files: <info>' . $information['numberOfFiles'] . '</info>');
            foreach ($information['files'] as $destination => $source) {
                // is folder
                if ($source === null) {
                    continue;
                }

                $output->writeln($source . ' => <comment>' . $destination . '</comment>');
            }
            return 0;
        }

        ProgressBar::setFormatDefinition('archiving', '  %current%/%max% [%bar%] %percent:3s%% %elapsed:6s%: %message%');

        if ($stdout) {
            $archived_files = UnifiedArchive::createInString($files_list, $archive_file, $compression, $password);

The assignment to $archived_files is dead and can be removed.

It seems like $password can also be of type string[]; however, parameter $password of wapmorgan\UnifiedArchive\UnifiedArchive::createInString() does only seem to accept null|string, maybe add an additional type check?

        }
        $progressBar = new ProgressBar($output, $information['numberOfFiles']);
        $progressBar->setFormat('archiving');
        $progressBar->start();
        $archived_files = UnifiedArchive::create($files_list, $archive_file, $compression, $password, function ($currentFile, $totalFiles, $fsFilename, $archiveFilename)
        use ($progressBar) {
            if ($fsFilename === null) {
                $progressBar->setMessage('Creating ' . $archiveFilename);
            } else {
                $progressBar->setMessage($fsFilename);
            }
            $progressBar->advance();
        });
        $progressBar->finish();
        $progressBar->clear();
        $output->writeln('');

        if (!$archived_files) {
            throw new \RuntimeException('archiveFiles result is false');
        }

        $archive = $this->open($archive_file);
        if (!empty($comment)) {
            $archive->setComment($comment);
        }

        $output->writeln(
            'Created <info>' . $archive_file . '</info> with <comment>' . $archived_files . '</comment> file(s) ('
            . implode($this->formatSize($archive->getOriginalSize())) . ') of total size '
            . implode($this->formatSize(filesize($archive_file)))
        );

        return 0;
    }