wapmorgan\UnifiedArchive\Commands\TestCommand

Complexity

Total Complexity

5

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	configure()	0	7	1
A	execute()	0	21	4

<?php

namespace wapmorgan\UnifiedArchive\Commands;

use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

class TestCommand extends BaseArchiveCommand
{
    protected static $defaultName = 'files:test';

    protected function configure()
    {
        parent::configure();
        $this
            ->setDescription('Tests archive contents')
            ->setHelp('Tests archive contents.')
            ->addArgument('filter', InputArgument::OPTIONAL, 'Files filter (as for fnmatch). If no * passed in filter, it will be added at the end of filter')
        ;
    }

    public function execute(InputInterface $input, OutputInterface $output)
    {
        $archive = $this->getArchive($input, $output);
        $files = $archive->getFileNames($input->getArgument('filter'));

It seems like $input->getArgument('filter') can also be of type string[]; however, parameter $filter of wapmorgan\UnifiedArchive\UnifiedArchive::getFileNames() does only seem to accept null|string, maybe add an additional type check?

        $errored = [];
        foreach ($files as $file) {
            $output->write($file . ' ... ');
            if ($archive->test($file) === true) {
                $output->writeln('<info>ok</info>');
            } else {
                $errored[] = $file;
                $output->writeln('<error>error</error>');
            }
        }

        if (!empty($errored)) {
            return 1;
        }

        return 0;
    }
}