wapmorgan / UnifiedArchive

src/Commands/DriversCommand.php

Spacing +2 added lines, -2 removed lines

@@ -35,13 +35,13 @@
             if (!empty($install)) {
                 $notInstalled[] = [$driverClass, $description, $install];
             } else {
-                $output->writeln($formatter->formatSection($driverClass, $description) . ': ' . implode(', ', $driverClass::getSupportedFormats()));
+                $output->writeln($formatter->formatSection($driverClass, $description).': '.implode(', ', $driverClass::getSupportedFormats()));
             }
         }
 
         if (!empty($notInstalled)) {
             foreach ($notInstalled as $data) {
-                $output->writeln($formatter->formatSection($data[0], $data[1] . ': ' . implode(', ', $data[0]::getSupportedFormats()), 'error'));
+                $output->writeln($formatter->formatSection($data[0], $data[1].': '.implode(', ', $data[0]::getSupportedFormats()), 'error'));
                 $data[2] = preg_replace('~`(.+?)`~', '<options=bold,underscore>$1</>', $data[2]);
                 $output->writeln($formatter->formatSection($data[0], $data[2], 'comment'));
             }

src/Commands/FormatsCommand.php

Spacing +2 added lines, -2 removed lines

@@ -36,9 +36,9 @@
                 $driver = '\\'.$driver;
             }
             if (!class_exists($driver) || !is_a($driver, BasicDriver::class, true)) {
-                throw new \InvalidArgumentException('Class "' . $driver . '" not found or not in BasicDriver children');
+                throw new \InvalidArgumentException('Class "'.$driver.'" not found or not in BasicDriver children');
             }
-            $output->writeln('Supported format by <info>' . $driver . '</info>');
+            $output->writeln('Supported format by <info>'.$driver.'</info>');
 
             $table->setHeaders(['format', 'stream', 'create', 'append', 'update', 'encrypt']);
             foreach ($driver::getSupportedFormats() as $i => $format) {

src/Drivers/SevenZip.php

Spacing +3 added lines, -3 removed lines

@@ -105,7 +105,7 @@ 
     public static function getInstallationInstruction()
     {
         if (!class_exists('\Archive7z\Archive7z'))
-            return 'install library [gemorroj/archive7z]: `composer require gemorroj/archive7z`' . "\n"
+            return 'install library [gemorroj/archive7z]: `composer require gemorroj/archive7z`'."\n"
                 . ' and console program p7zip [7za]: `apt install p7zip-full` - depends on OS';
 
         if (Archive7z::getBinaryVersion() === false)
@@ -147,8 +147,8 @@ 
             $information->files[] = $can_get_unix_path
                 ? $entry->getUnixPath()
                 : str_replace('\\', '/', $entry->getPath());
-            $information->compressedFilesSize += (int)$entry->getPackedSize();
-            $information->uncompressedFilesSize += (int)$entry->getSize();
+            $information->compressedFilesSize += (int) $entry->getPackedSize();
+            $information->uncompressedFilesSize += (int) $entry->getSize();
         }
         return $information;
     }

Braces +30 added lines, -20 removed lines

@@ -58,12 +58,14 @@ 
     public static function checkFormatSupport($format)
     {
         $available = class_exists('\Archive7z\Archive7z') && Archive7z::getBinaryVersion() !== false;
-        if (!$available)
-            return false;
+        if (!$available) {
+                    return false;
+        }
 
         // in 4.0.0 version it was supporting only 7z
-        if (!Archive7z::supportsAllFormats())
-            return $format === Formats::SEVEN_ZIP;
+        if (!Archive7z::supportsAllFormats()) {
+                    return $format === Formats::SEVEN_ZIP;
+        }
 
         switch ($format) {
             case Formats::SEVEN_ZIP:
@@ -104,12 +106,14 @@ 
      */
     public static function getInstallationInstruction()
     {
-        if (!class_exists('\Archive7z\Archive7z'))
-            return 'install library [gemorroj/archive7z]: `composer require gemorroj/archive7z`' . "\n"
+        if (!class_exists('\Archive7z\Archive7z')) {
+                    return 'install library [gemorroj/archive7z]: `composer require gemorroj/archive7z`' . "\n"
                 . ' and console program p7zip [7za]: `apt install p7zip-full` - depends on OS';
+        }
 
-        if (Archive7z::getBinaryVersion() === false)
-            return 'install console program p7zip [7za]: `apt install p7zip-full` - depends on OS';
+        if (Archive7z::getBinaryVersion() === false) {
+                    return 'install console program p7zip [7za]: `apt install p7zip-full` - depends on OS';
+        }
 
         return null;
     }
@@ -122,8 +126,9 @@ 
         try {
             $this->format = $format;
             $this->sevenZip = new Archive7z($archiveFileName, null, null);
-            if ($password !== null)
-                $this->sevenZip->setPassword($password);
+            if ($password !== null) {
+                            $this->sevenZip->setPassword($password);
+            }
         } catch (\Archive7z\Exception $e) {
             throw new Exception('Could not open 7Zip archive: '.$e->getMessage(), $e->getCode(), $e);
         }
@@ -141,8 +146,9 @@ 
                 continue;
             }
 
-            if (!isset($can_get_unix_path))
-                $can_get_unix_path = method_exists($entry, 'getUnixPath');
+            if (!isset($can_get_unix_path)) {
+                            $can_get_unix_path = method_exists($entry, 'getUnixPath');
+            }
 
             $information->files[] = $can_get_unix_path
                 ? $entry->getUnixPath()
@@ -160,8 +166,9 @@ 
     {
         $files = [];
         foreach ($this->sevenZip->getEntries() as $entry) {
-            if ($entry->isDirectory())
-                continue;
+            if ($entry->isDirectory()) {
+                            continue;
+            }
             $files[] = $entry->getPath();
         }
         return $files;
@@ -302,8 +309,9 @@ 
     public function addFileFromString($inArchiveName, $content)
     {
         $tmp_file = tempnam(sys_get_temp_dir(), 'ua');
-        if (!$tmp_file)
-            throw new ArchiveModificationException('Could not create temporarily file');
+        if (!$tmp_file) {
+                    throw new ArchiveModificationException('Could not create temporarily file');
+        }
 
         file_put_contents($tmp_file, $content);
         $this->sevenZip->addEntry($tmp_file, true);
@@ -353,8 +361,9 @@ 
             $total_files = count($files);
 
             $seven_zip = new Archive7z($archiveFileName);
-            if ($password !== null)
-                $seven_zip->setPassword($password);
+            if ($password !== null) {
+                            $seven_zip->setPassword($password);
+            }
             $seven_zip->setCompressionLevel($compressionLevelMap[$compressionLevel]);
             foreach ($files as $localName => $filename) {
                 if ($filename !== null) {
@@ -386,8 +395,9 @@ 
             Formats::TAR,
             Formats::LZMA,
             Formats::ZIP]
-        ))
-            return self::canRenameFiles();
+        )) {
+                    return self::canRenameFiles();
+        }
 
         return false;
     }

src/Drivers/OneFile/Lzma.php

Spacing +2 added lines, -2 removed lines

@@ -12,7 +12,7 @@ 
  */
 class Lzma extends OneFileDriver
 {
-    const FORMAT_SUFFIX =  'xz';
+    const FORMAT_SUFFIX = 'xz';
 
     /**
      * @return array
@@ -50,7 +50,7 @@ 
     public static function getInstallationInstruction()
     {
         return !extension_loaded('xz')
-            ? 'install [xz] extension' . "\n" . 'For 5.x: https://github.com/payden/php-xz' . "\n" . 'For 7.x: https://github.com/codemasher/php-ext-xz'
+            ? 'install [xz] extension'."\n".'For 5.x: https://github.com/payden/php-xz'."\n".'For 7.x: https://github.com/codemasher/php-ext-xz'
             : null;
     }
 

src/PclZipInterface.php

Spacing +19 added lines, -19 removed lines

@@ -272,7 +272,7 @@ 
 
         $report = array();
         foreach ($this->listContent() as $file_header) {
-            $file_header = (object)$file_header;
+            $file_header = (object) $file_header;
             // add file information to report
             $report[] = $file_header;
             // refuse by select rule
@@ -406,7 +406,7 @@ 
         }
 
         foreach ($report as $i => $reportItem) {
-            $report[$i] = (array)$reportItem;
+            $report[$i] = (array) $reportItem;
         }
 
         return $report;
@@ -457,7 +457,7 @@ 
 
         $report = [];
         foreach ($this->listContent() as $file_header) {
-            $file_header = (object)$file_header;
+            $file_header = (object) $file_header;
             // select by select rule
             if (call_user_func($selectFilter, $file_header->stored_filename,
                     $file_header->filename, $file_header->index)
@@ -477,7 +477,7 @@ 
         }
 
         foreach ($report as $i => $reportItem) {
-            $report[$i] = (array)$reportItem;
+            $report[$i] = (array) $reportItem;
         }
 
         return $report;
@@ -539,7 +539,7 @@ 
             }
         }
 
-        call_user_func(function ($directory) {
+        call_user_func(function($directory) {
             foreach (glob($directory.'/*') as $f) {
                 if (is_dir($f)) call_user_func(__FUNCTION__, $f);
                 else unlink($f);
@@ -568,16 +568,16 @@ 
         $filters = array();
         if (isset($options[PCLZIP_OPT_REMOVE_PATH])
             && !isset($options[PCLZIP_OPT_REMOVE_ALL_PATH]))
-            $filters[] = function (&$key, &$value) use ($options) {
+            $filters[] = function(&$key, &$value) use ($options) {
                 $key = str_replace($key, null, $key);
             };
         if (isset($options[PCLZIP_OPT_REMOVE_ALL_PATH]))
-            $filters[] = function (&$key, &$value) {
+            $filters[] = function(&$key, &$value) {
                 $key = basename($key);
             };
         if (isset($options[PCLZIP_OPT_ADD_PATH]))
-            $filters[] = function (&$key, &$value) use ($options) {
-                $key = rtrim($options[PCLZIP_OPT_ADD_PATH], '/') . '/' .
+            $filters[] = function(&$key, &$value) use ($options) {
+                $key = rtrim($options[PCLZIP_OPT_ADD_PATH], '/').'/'.
                     ltrim($key, '/');
             };
         return $filters;
@@ -591,7 +591,7 @@ 
      */
     private function extractCallbacks(array $options, $preCallbackConst, $postCallbackConst)
     {
-        $preCallback = $postCallback = function () { return true; };
+        $preCallback = $postCallback = function() { return true; };
 
         if (isset($options[$preCallbackConst]) && is_callable($options[$preCallbackConst]))
             $preCallback = $options[$preCallbackConst];
@@ -608,8 +608,8 @@ 
      */
     private function makeKeyValueArrayFromList(array $options)
     {
-        $keys = array_filter($options, function ($v) {return ($v%2) == 0;}, ARRAY_FILTER_USE_KEY);
-        $values = array_filter($options, function ($v) {return ($v%2) == 1;}, ARRAY_FILTER_USE_KEY);
+        $keys = array_filter($options, function($v) {return ($v % 2) == 0; }, ARRAY_FILTER_USE_KEY);
+        $values = array_filter($options, function($v) {return ($v % 2) == 1; }, ARRAY_FILTER_USE_KEY);
         if (count($values) < count($keys)) $values[] = true;
         return array_combine($keys, $values);
     }
@@ -658,7 +658,7 @@ 
                 range($parts[0], $parts[1]), $allowedIndexes);
         }
 
-        return function ($key, $value, $index) use ($allowedIndexes) {
+        return function($key, $value, $index) use ($allowedIndexes) {
             return in_array($index, $allowedIndexes)
                 ? self::SELECT_FILTER_PASS
                 : self::SELECT_FILTER_REFUSE;
@@ -675,7 +675,7 @@ 
             ? $names
             : explode(',', $names);
 
-        return function ($key, $value) use ($allowedNames) {
+        return function($key, $value) use ($allowedNames) {
             foreach ($allowedNames as $name) {
                 // select directory with nested files
                 if (in_array(substr($name, -1), ['/', '\\'])) {
@@ -703,7 +703,7 @@ 
      */
     protected function createByEregSelector($regex)
     {
-        return function ($key, $value) use ($regex) {
+        return function($key, $value) use ($regex) {
             return (ereg($regex, $key) !== false)
                 ? self::SELECT_FILTER_PASS
                 : self::SELECT_FILTER_REFUSE;
@@ -716,7 +716,7 @@ 
      */
     protected function createByPregSelector($regex)
     {
-        return function ($key, $value) use ($regex) {
+        return function($key, $value) use ($regex) {
             return preg_match($regex, $key)
                 ? self::SELECT_FILTER_PASS
                 : self::SELECT_FILTER_REFUSE;
@@ -743,7 +743,7 @@ 
             $selectFilter = $this->createByIndexSelector($options[PCLZIP_OPT_BY_INDEX]);
         // no rule
         else
-            $selectFilter = function () {
+            $selectFilter = function() {
                 return self::SELECT_FILTER_PASS;
             };
         return $selectFilter;
@@ -783,9 +783,9 @@ 
         if (isset($options[PCLZIP_OPT_COMMENT]))
             $comment = $options[PCLZIP_OPT_COMMENT];
         else if (isset($options[PCLZIP_OPT_ADD_COMMENT])) {;
-            $comment = $currentComment . $options[PCLZIP_OPT_ADD_COMMENT];
+            $comment = $currentComment.$options[PCLZIP_OPT_ADD_COMMENT];
         } else if (isset($options[PCLZIP_OPT_PREPEND_COMMENT])) {
-            $comment = $options[PCLZIP_OPT_PREPEND_COMMENT] . $currentComment;
+            $comment = $options[PCLZIP_OPT_PREPEND_COMMENT].$currentComment;
         }
         return $comment;
     }

Braces +99 added lines, -57 removed lines

@@ -137,8 +137,11 @@ 
      */
     public function create($content)
     {
-        if (is_array($content)) $paths_list = $content;
-        else $paths_list = explode(',', $content);
+        if (is_array($content)) {
+         $paths_list = $content;
+        } else {
+         $paths_list = explode(',', $content);
+        }
 
         $options = $this->makeOptionsFromArguments(func_get_args());
 
@@ -146,8 +149,9 @@ 
         $filters = $this->createFilters($options);
         list($preAddCallback, $postAddCallback) = $this->extractCallbacks($options, PCLZIP_CB_PRE_ADD, PCLZIP_CB_POST_ADD);
 
-        if (!empty($comment = $this->buildComment($options, null)))
-            $this->archive->setComment($comment);
+        if (!empty($comment = $this->buildComment($options, null))) {
+                    $this->archive->setComment($comment);
+        }
 
         // scan filesystem for files list
         return $this->addSnippets($paths_list, $filters, $preAddCallback, $postAddCallback);
@@ -167,16 +171,18 @@ 
             $localname = $fileToAdd;
             $filename = $fileToAdd;
 
-            foreach ($filters as $filter)
-                call_user_func($filter, $localname, $filename);
+            foreach ($filters as $filter) {
+                            call_user_func($filter, $localname, $filename);
+            }
 
             $file_header = $this->createFileHeader($localname, $filename);
             if (call_user_func($preAddCallback, $file_header) == 1) {
                 //
                 // Check for max length > 255
                 //
-                if (strlen(basename($file_header->stored_filename)) > 255)
-                    $file_header->status = 'filename_too_long';
+                if (strlen(basename($file_header->stored_filename)) > 255) {
+                                    $file_header->status = 'filename_too_long';
+                }
                 if (is_file($filename)) {
                     $this->archive->addFiles([
                         $file_header->stored_filename => $file_header->filename,
@@ -248,27 +254,35 @@ 
         }
 
         // filters initiation
-        if (isset($options[PCLZIP_OPT_PATH]))
-            $extractPath = rtrim($options[PCLZIP_OPT_PATH], '/');
-        else $extractPath = rtrim(getcwd(), '/');
+        if (isset($options[PCLZIP_OPT_PATH])) {
+                    $extractPath = rtrim($options[PCLZIP_OPT_PATH], '/');
+        } else {
+         $extractPath = rtrim(getcwd(), '/');
+        }
 
         $filters = $this->createFilters($options);
         list($preExtractCallback, $postExtractCallback) = $this->extractCallbacks($options, PCLZIP_CB_PRE_EXTRACT, PCLZIP_CB_POST_EXTRACT);
         $selectFilter = $this->createSelector($options);
 
-        if (isset($options[PCLZIP_OPT_EXTRACT_AS_STRING]))
-            $anotherOutputFormat = PCLZIP_OPT_EXTRACT_AS_STRING;
-        else if (isset($options[PCLZIP_OPT_EXTRACT_IN_OUTPUT]))
-            $anotherOutputFormat = PCLZIP_OPT_EXTRACT_IN_OUTPUT;
-        else $anotherOutputFormat = false;
+        if (isset($options[PCLZIP_OPT_EXTRACT_AS_STRING])) {
+                    $anotherOutputFormat = PCLZIP_OPT_EXTRACT_AS_STRING;
+        } else if (isset($options[PCLZIP_OPT_EXTRACT_IN_OUTPUT])) {
+                    $anotherOutputFormat = PCLZIP_OPT_EXTRACT_IN_OUTPUT;
+        } else {
+         $anotherOutputFormat = false;
+        }
 
-        if (isset($options[PCLZIP_OPT_REPLACE_NEWER]))
-            $doNotReplaceNewer = false;
-        else $doNotReplaceNewer = true;
+        if (isset($options[PCLZIP_OPT_REPLACE_NEWER])) {
+                    $doNotReplaceNewer = false;
+        } else {
+         $doNotReplaceNewer = true;
+        }
 
-        if (isset($options[PCLZIP_OPT_EXTRACT_DIR_RESTRICTION]))
-            $restrictExtractDir = $options[PCLZIP_OPT_EXTRACT_DIR_RESTRICTION];
-        else $restrictExtractDir = false;
+        if (isset($options[PCLZIP_OPT_EXTRACT_DIR_RESTRICTION])) {
+                    $restrictExtractDir = $options[PCLZIP_OPT_EXTRACT_DIR_RESTRICTION];
+        } else {
+         $restrictExtractDir = false;
+        }
 
         $report = array();
         foreach ($this->listContent() as $file_header) {
@@ -339,8 +353,10 @@ 
             // extract content
             else if ($anotherOutputFormat === false) {
                 // apply path filters
-                foreach ($filters as $filter) call_user_func($filter,
+                foreach ($filters as $filter) {
+                 call_user_func($filter,
                     $file_header->stored_filename, $file_header->filename);
+                }
                 // dir extraction process
                 if ($file_header->folder) {
                     // if dir doesn't exist
@@ -431,15 +447,19 @@ 
      */
     public function add($content)
     {
-        if (is_array($content)) $paths_list = $content;
-        else $paths_list = explode(',', $content);
+        if (is_array($content)) {
+         $paths_list = $content;
+        } else {
+         $paths_list = explode(',', $content);
+        }
 
         $options = $this->makeOptionsFromArguments(func_get_args());
         $filters = $this->createFilters($options);
         list($preAddCallback, $postAddCallback) = $this->extractCallbacks($options, PCLZIP_CB_PRE_ADD, PCLZIP_CB_POST_ADD);
 
-        if (!empty($comment = $this->buildComment($options, $this->archive->getComment())))
-            $this->archive->setComment($comment);
+        if (!empty($comment = $this->buildComment($options, $this->archive->getComment()))) {
+                    $this->archive->setComment($comment);
+        }
 
         // scan filesystem for files list
         return $this->addSnippets($paths_list, $filters, $preAddCallback, $postAddCallback);
@@ -511,8 +531,12 @@ 
         }
 
         $tempDir = tempnam(PCLZIP_TEMPORARY_DIR, 'merging');
-        if (file_exists($tempDir)) unlink($tempDir);
-        if (!mkdir($tempDir)) return 0;
+        if (file_exists($tempDir)) {
+         unlink($tempDir);
+        }
+        if (!mkdir($tempDir)) {
+         return 0;
+        }
 
         // go through archive content list and copy all files
         foreach ($a->getFileNames() as $filename) {
@@ -541,8 +565,11 @@ 
 
         call_user_func(function ($directory) {
             foreach (glob($directory.'/*') as $f) {
-                if (is_dir($f)) call_user_func(__FUNCTION__, $f);
-                else unlink($f);
+                if (is_dir($f)) {
+                 call_user_func(__FUNCTION__, $f);
+                } else {
+                 unlink($f);
+                }
             }
         }, $tempDir);
 
@@ -567,18 +594,21 @@ 
     {
         $filters = array();
         if (isset($options[PCLZIP_OPT_REMOVE_PATH])
-            && !isset($options[PCLZIP_OPT_REMOVE_ALL_PATH]))
-            $filters[] = function (&$key, &$value) use ($options) {
+            && !isset($options[PCLZIP_OPT_REMOVE_ALL_PATH])) {
+                    $filters[] = function (&$key, &$value) use ($options) {
                 $key = str_replace($key, null, $key);
+        }
             };
-        if (isset($options[PCLZIP_OPT_REMOVE_ALL_PATH]))
-            $filters[] = function (&$key, &$value) {
+        if (isset($options[PCLZIP_OPT_REMOVE_ALL_PATH])) {
+                    $filters[] = function (&$key, &$value) {
                 $key = basename($key);
+        }
             };
-        if (isset($options[PCLZIP_OPT_ADD_PATH]))
-            $filters[] = function (&$key, &$value) use ($options) {
+        if (isset($options[PCLZIP_OPT_ADD_PATH])) {
+                    $filters[] = function (&$key, &$value) use ($options) {
                 $key = rtrim($options[PCLZIP_OPT_ADD_PATH], '/') . '/' .
                     ltrim($key, '/');
+        }
             };
         return $filters;
     }
@@ -593,11 +623,13 @@ 
     {
         $preCallback = $postCallback = function () { return true; };
 
-        if (isset($options[$preCallbackConst]) && is_callable($options[$preCallbackConst]))
-            $preCallback = $options[$preCallbackConst];
+        if (isset($options[$preCallbackConst]) && is_callable($options[$preCallbackConst])) {
+                    $preCallback = $options[$preCallbackConst];
+        }
 
-        if (isset($options[$postCallbackConst]) && is_callable($options[$postCallbackConst]))
-            $postCallback = $options[$postCallbackConst];
+        if (isset($options[$postCallbackConst]) && is_callable($options[$postCallbackConst])) {
+                    $postCallback = $options[$postCallbackConst];
+        }
 
         return [$preCallback, $postCallback];
     }
@@ -610,7 +642,9 @@ 
     {
         $keys = array_filter($options, function ($v) {return ($v%2) == 0;}, ARRAY_FILTER_USE_KEY);
         $values = array_filter($options, function ($v) {return ($v%2) == 1;}, ARRAY_FILTER_USE_KEY);
-        if (count($values) < count($keys)) $values[] = true;
+        if (count($values) < count($keys)) {
+         $values[] = true;
+        }
         return array_combine($keys, $values);
     }
 
@@ -653,9 +687,12 @@ 
         $allowedIndexes = array();
         foreach ($indexes as $rule) {
             $parts = explode('-', $rule);
-            if (count($parts) == 1) $allowedIndexes[] = $rule;
-            else $allowedIndexes = array_merge(
+            if (count($parts) == 1) {
+             $allowedIndexes[] = $rule;
+            } else {
+             $allowedIndexes = array_merge(
                 range($parts[0], $parts[1]), $allowedIndexes);
+            }
         }
 
         return function ($key, $value, $index) use ($allowedIndexes) {
@@ -730,21 +767,26 @@ 
     protected function createSelector(array $options)
     {
         // exact matching
-        if (isset($options[PCLZIP_OPT_BY_NAME]))
-            $selectFilter = $this->createByNameSelector($options[PCLZIP_OPT_BY_NAME]);
+        if (isset($options[PCLZIP_OPT_BY_NAME])) {
+                    $selectFilter = $this->createByNameSelector($options[PCLZIP_OPT_BY_NAME]);
+        }
         // <ereg> rule
-        else if (isset($options[PCLZIP_OPT_BY_EREG]) && function_exists('ereg'))
-            $selectFilter = $this->createByEregSelector($options[PCLZIP_OPT_BY_EREG]);
+        else if (isset($options[PCLZIP_OPT_BY_EREG]) && function_exists('ereg')) {
+                    $selectFilter = $this->createByEregSelector($options[PCLZIP_OPT_BY_EREG]);
+        }
         // <preg_match> rule
-        else if (isset($options[PCLZIP_OPT_BY_PREG]))
-            $selectFilter = $this->createByPregSelector($options[PCLZIP_OPT_BY_PREG]);
+        else if (isset($options[PCLZIP_OPT_BY_PREG])) {
+                    $selectFilter = $this->createByPregSelector($options[PCLZIP_OPT_BY_PREG]);
+        }
         // index rule
-        else if (isset($options[PCLZIP_OPT_BY_INDEX]))
-            $selectFilter = $this->createByIndexSelector($options[PCLZIP_OPT_BY_INDEX]);
+        else if (isset($options[PCLZIP_OPT_BY_INDEX])) {
+                    $selectFilter = $this->createByIndexSelector($options[PCLZIP_OPT_BY_INDEX]);
+        }
         // no rule
-        else
-            $selectFilter = function () {
+        else {
+                    $selectFilter = function () {
                 return self::SELECT_FILTER_PASS;
+        }
             };
         return $selectFilter;
     }
@@ -780,9 +822,9 @@ 
     protected function buildComment(array $options, $currentComment)
     {
         $comment = null;
-        if (isset($options[PCLZIP_OPT_COMMENT]))
-            $comment = $options[PCLZIP_OPT_COMMENT];
-        else if (isset($options[PCLZIP_OPT_ADD_COMMENT])) {;
+        if (isset($options[PCLZIP_OPT_COMMENT])) {
+                    $comment = $options[PCLZIP_OPT_COMMENT];
+        } else if (isset($options[PCLZIP_OPT_ADD_COMMENT])) {;
             $comment = $currentComment . $options[PCLZIP_OPT_ADD_COMMENT];
         } else if (isset($options[PCLZIP_OPT_PREPEND_COMMENT])) {
             $comment = $options[PCLZIP_OPT_PREPEND_COMMENT] . $currentComment;