LastNamesInflection - Code Metrics - Inspection of "Fix #65" - wapmorgan/Morphos - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#66)

unknown

created 2020-01-29 03:40 UTC

LastNamesInflection A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	240
Duplicated Lines	22.08 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

95.24%

Importance

Changes

Metric	Value
dl	53
loc	240
ccs	120
cts	126
cp	0.9524
rs	9.44
c	0
b	0
f	0
wmc	37
lcom	1
cbo	4

4 Methods

Rating	Name	Duplication	Size	Complexity
C	isMutable()	15	57	14
A	detectGender()	0	12	3
F	getCases()	38	129	18
A	getCase()	0	10	2

How to fix Duplicated Code

<?php
namespace morphos\Russian;

use morphos\S;

/**
 * Rules are from http://gramma.ru/SPR/?id=2.8
 */
class LastNamesInflection extends \morphos\NamesInflection implements Cases
{
    use RussianLanguage, CasesHelper;

    protected static $menPostfixes = ['ов', 'ев' ,'ин' ,'ын', 'ой', 'ий'];
    protected static $womenPostfixes = ['ва', 'на', 'ая', 'яя'];

    /**
     * @param $name
     * @param null $gender
     * @return bool
     */
    public static function isMutable($name, $gender = null)
    {
        $name = S::lower($name);
        if ($gender === null) {
            $gender = static::detectGender($name);
        }
        // составная фамилия - разбить на части и проверить по отдельности
        if (strpos($name, '-') !== false) {
            foreach (explode('-', $name) as $part) {
                if (static::isMutable($part, $gender))
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                    return true;
            }
            return false;
        }

        if (in_array(S::slice($name, -1), ['а', 'я'], true)) {
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            return true;
        }
        
        // Несклоняемые фамилии независимо от пола (Токаревских)
        if (in_array(S::slice($name, -2), ['их'], true))
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            return false;

        if ($gender == static::MALE) {
            // Несклоняемые фамилии (Фоминых, Седых / Стецко, Писаренко)
            if (in_array(S::slice($name, -2), ['ых', 'ко'], true))
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                return false;

            // Несклоняемые, образованные из родительного падежа личного или прозвищного имени главы семьи
            // суффиксы: ово, аго
            if (in_array(S::slice($name, -3), ['ово', 'аго'], true))
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                return false;

            // Типичные суффикс мужских фамилий
            if (in_array(S::slice($name, -2), ['ов', 'ев', 'ин', 'ын', 'ий', 'ой'], true)) {
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                return true;
            }

            // Согласная на конце
            if (static::isConsonant(S::slice($name, -1))) {
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                return true;
            }

            // Мягкий знак на конце
            if (S::slice($name, -1) == 'ь') {
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                return true;
            }

        } else {

            // Типичные суффиксы женских фамилий
            if (in_array(S::slice($name, -2), ['ва', 'на', 'ая'], true)) {
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                return true;
            }
        }

        return false;
    }

    /**
     * @param $name
     * @return null|string
     */
    public static function detectGender($name)
    {
        $name = S::lower($name);
        if (in_array(S::slice($name, -2), static::$menPostfixes, true)) {
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            return static::MALE;
        }
        if (in_array(S::slice($name, -2), static::$womenPostfixes, true)) {
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            return static::FEMALE;
        }

        return null;
    }

    /**
     * @param $name
     * @param null|string $gender
     * @return array
     */
    public static function getCases($name, $gender = null)
    {
        $name = S::lower($name);
        if ($gender === null) {
            $gender = static::detectGender($name);
        }

        // составная фамилия - разбить на части и склонять по отдельности
        if (strpos($name, '-') !== false) {
            $parts = explode('-', $name);
            $cases = [];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            foreach ($parts as $i => $part) {
                $parts[$i] = static::getCases($part, $gender);
            }

            return static::composeCasesFromWords($parts, '-');
        }

        if (static::isMutable($name, $gender)) {
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            if ($gender == static::MALE) {
                if (in_array(S::slice($name, -2), ['ов', 'ев', 'ин', 'ын'], true)) {
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                    $prefix = S::name($name);
                    return [
                        static::IMENIT => $prefix,
                        static::RODIT => $prefix.'а',
                        static::DAT => $prefix.'у',
                        static::VINIT => $prefix.'а',
                        static::TVORIT => $prefix.'ым',
                        static::PREDLOJ => $prefix.'е'
                    ];
                } elseif (in_array(S::slice($name, -4), ['ский', 'ской', 'цкий', 'цкой'], true)) {
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                    $prefix = S::name(S::slice($name, 0, -2));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                    return [
                        static::IMENIT => S::name($name),
                        static::RODIT => $prefix.'ого',
                        static::DAT => $prefix.'ому',
                        static::VINIT => $prefix.'ого',
                        static::TVORIT => $prefix.'им',
                        static::PREDLOJ => $prefix.'ом'
                    ];
                // Верхний / Убогий / Толстой
                // Верхнего / Убогого / Толстого
                // Верхнему / Убогому / Толстому
                // Верхним / Убогим / Толстым
                // О Верхнем / Об Убогом / О Толстом
                } else if (in_array(S::slice($name, -2), ['ой', 'ый', 'ий'], true)) {
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                    $prefix = S::name(S::slice($name, 0, -2));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                    return [
                        static::IMENIT => S::name($name),
                        static::RODIT => $prefix.'ого',
                        static::DAT => $prefix.'ому',
                        static::VINIT => $prefix.'ого',
                        static::TVORIT => $prefix.'ым',
                        static::PREDLOJ => $prefix.'ом'
                    ];
                }

            } else {
                if (in_array(S::slice($name, -3), ['ова', 'ева', 'ина', 'ына'], true)) {
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                    $prefix = S::name(S::slice($name, 0, -1));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                    return [
                        static::IMENIT => S::name($name),
                        static::RODIT => $prefix.'ой',
                        static::DAT => $prefix.'ой',
                        static::VINIT => $prefix.'у',
                        static::TVORIT => $prefix.'ой',
                        static::PREDLOJ => $prefix.'ой'
                    ];
                }

                if (in_array(S::slice($name, -2), ['ая'], true)) {
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                    $prefix = S::name(S::slice($name, 0, -2));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                    return [
                        static::IMENIT => S::name($name),
                        static::RODIT => $prefix.'ой',
                        static::DAT => $prefix.'ой',
                        static::VINIT => $prefix.'ую',
                        static::TVORIT => $prefix.'ой',
                        static::PREDLOJ => $prefix.'ой'
                    ];
                }
            }

            if (S::slice($name, -1) == 'я') {
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                $prefix = S::name(S::slice($name, 0, -1));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                return [
                    static::IMENIT => S::name($name),
                    static::RODIT => $prefix.'и',
                    static::DAT => $prefix.'е',
                    static::VINIT => $prefix.'ю',
                    static::TVORIT => $prefix.'ей',
                    static::PREDLOJ => $prefix.'е'
                ];
            } elseif (S::slice($name, -1) == 'а') {
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                $prefix = S::name(S::slice($name, 0, -1));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                return [
                    static::IMENIT => S::name($name),
                    static::RODIT => $prefix.(static::isDeafConsonant(S::slice($name, -2, -1)) ? 'и' : 'ы'),
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                    static::DAT => $prefix.'е',
                    static::VINIT => $prefix.'у',
                    static::TVORIT => $prefix.'ой',
                    static::PREDLOJ => $prefix.'е'
                ];
            } elseif (static::isConsonant(S::slice($name, -1)) && S::slice($name, -2) != 'ых') {
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                $prefix = S::name($name);
                return [
                    static::IMENIT => S::name($name),
                    static::RODIT => $prefix.'а',
                    static::DAT => $prefix.'у',
                    static::VINIT => $prefix.'а',
                    static::TVORIT => $prefix.'ом',
                    static::PREDLOJ => $prefix.'е'
                ];
            } elseif (S::slice($name, -1) == 'ь' && $gender == static::MALE) {
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                $prefix = S::name(S::slice($name, 0, -1));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                return [
                    static::IMENIT => S::name($name),
                    static::RODIT => $prefix.'я',
                    static::DAT => $prefix.'ю',
                    static::VINIT => $prefix.'я',
                    static::TVORIT => $prefix.'ем',
                    static::PREDLOJ => $prefix.'е'
                ];
            }
        }

        $name = S::name($name);
        return array_fill_keys([static::IMENIT, static::RODIT, static::DAT, static::VINIT, static::TVORIT, static::PREDLOJ], $name);
    }

    /**
     * @param $name
     * @param $case
     * @param null $gender
     * @return string
     * @throws \Exception
     */
    public static function getCase($name, $case, $gender = null)
    {
        if (!static::isMutable($name, $gender)) {
            return $name;
        } else {
            $case = static::canonizeCase($case);
            $forms = static::getCases($name, $gender);
            return $forms[$case];
        }
    }
}


1			<?php
2			namespace morphos\Russian;
3
4			use morphos\S;
5
6			/**
7			* Rules are from http://gramma.ru/SPR/?id=2.8
8			*/
9			class LastNamesInflection extends \morphos\NamesInflection implements Cases
10			{
11			use RussianLanguage, CasesHelper;
12
13			protected static $menPostfixes = ['ов', 'ев' ,'ин' ,'ын', 'ой', 'ий'];
14			protected static $womenPostfixes = ['ва', 'на', 'ая', 'яя'];
15
16			/**
17			* @param $name
18			* @param null $gender
19			* @return bool
20			*/
21	60		public static function isMutable($name, $gender = null)
22			{
23	60		$name = S::lower($name);
24	60		if ($gender === null) {
25			$gender = static::detectGender($name);
26			}
27			// составная фамилия - разбить на части и проверить по отдельности
28	60		if (strpos($name, '-') !== false) {
29	3		foreach (explode('-', $name) as $part) {
30	3		if (static::isMutable($part, $gender))
			0 ignored issues – show Bug introduced 2019-01-13 20:54 UTC by Report Bug Copy Issue Report It seems like `$gender` defined by `static::detectGender($name)` on line `25` can also be of type `string`; however, `morphos\Russian\LastNamesInflection::isMutable()` does only seem to accept `null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
31	3		return true;
32			}
33			return false;
34			}
35
36	60	View Code Duplication	if (in_array(S::slice($name, -1), ['а', 'я'], true)) {
			0 ignored issues – show Duplication introduced 2018-06-20 17:53 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Bug introduced 2018-11-17 00:20 UTC by Report Bug Copy Issue Report It seems like `$name` defined by `\morphos\S::lower($name)` on line `23` can also be of type `boolean`; however, `morphos\S::slice()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
37	22		return true;
38			}

wapmorgan / Morphos

Pull Request — master (#66)

LastNamesInflection A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like